Skip to contentSkip to conversation

ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

PATCH In review Leonardo Bras 2 participants 7 messages Apr 2, 2020 – Apr 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2

On reboot, all memory that was previously added using object_add and device_add is placed in this DIMM area.

The new SPAPR_LMB_FLAGS_HOTREMOVABLE flag helps Linux to put this memory in the correct memory zone, so no unmovable allocations are made there, allowing the object to be easily hot-removed by device_del and object_del.

This new flag was accepted in Power Architecture documentation.

---
Changes since v1:
- Flag name changed from SPAPR_LMB_FLAGS_HOTPLUGGED to SPAPR_LMB_FLAGS_HOTREMOVABLE

---
 hw/ppc/spapr.c         | 3 ++-
 include/hw/ppc/spapr.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
hw/ppc/spapr.c +2 -1
index 9a2bd501aa..fe662e297e 100644
@@ -446,7 +446,8 @@ static int spapr_dt_dynamic_memory_v2(SpaprMachineState *spapr, void *fdt,
         g_assert(drc);
         elem = spapr_get_drconf_cell(size / lmb_size, addr,
                                      spapr_drc_index(drc), node,
-                                     SPAPR_LMB_FLAGS_ASSIGNED);
+                                     (SPAPR_LMB_FLAGS_ASSIGNED |
+                                      SPAPR_LMB_FLAGS_HOTREMOVABLE);
         QSIMPLEQ_INSERT_TAIL(&drconf_queue, elem, entry);
         nr_entries++;
         cur_addr = addr + size;
include/hw/ppc/spapr.h +1 -0
index 42d64a0368..93e0d43051 100644
@@ -880,6 +880,7 @@ int spapr_rtc_import_offset(SpaprRtcState *rtc, int64_t legacy_offset);
 #define SPAPR_LMB_FLAGS_ASSIGNED 0x00000008
 #define SPAPR_LMB_FLAGS_DRC_INVALID 0x00000020
 #define SPAPR_LMB_FLAGS_RESERVED 0x00000080
+#define SPAPR_LMB_FLAGS_HOTREMOVABLE 0x00000100
 
 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg);
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · Leonardo Bras

On reboot, all memory that was previously added using object_add and device_add is placed in this DIMM area.

The new SPAPR_LMB_FLAGS_HOTREMOVABLE flag helps Linux to put this memory in the correct memory zone, so no unmovable allocations are made there, allowing the object to be easily hot-removed by device_del and object_del.

Quoted 4 lines

This new flag was accepted in Power Architecture documentation.

The change looks reasonable. Is there a PAPR RFC I can see describing the new bit, though?

Quoted 35 lines

---
Changes since v1:
- Flag name changed from SPAPR_LMB_FLAGS_HOTPLUGGED to SPAPR_LMB_FLAGS_HOTREMOVABLE

---
 hw/ppc/spapr.c         | 3 ++-
 include/hw/ppc/spapr.h | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
hw/ppc/spapr.c +2 -1
index 9a2bd501aa..fe662e297e 100644
@@ -446,7 +446,8 @@ static int spapr_dt_dynamic_memory_v2(SpaprMachineState *spapr, void *fdt,
         g_assert(drc);
         elem = spapr_get_drconf_cell(size / lmb_size, addr,
                                      spapr_drc_index(drc), node,
-                                     SPAPR_LMB_FLAGS_ASSIGNED);
+                                     (SPAPR_LMB_FLAGS_ASSIGNED |
+                                      SPAPR_LMB_FLAGS_HOTREMOVABLE);
         QSIMPLEQ_INSERT_TAIL(&drconf_queue, elem, entry);
         nr_entries++;
         cur_addr = addr + size;
include/hw/ppc/spapr.h +1 -0
index 42d64a0368..93e0d43051 100644
@@ -880,6 +880,7 @@ int spapr_rtc_import_offset(SpaprRtcState *rtc, int64_t legacy_offset);
 #define SPAPR_LMB_FLAGS_ASSIGNED 0x00000008
 #define SPAPR_LMB_FLAGS_DRC_INVALID 0x00000020
 #define SPAPR_LMB_FLAGS_RESERVED 0x00000080
+#define SPAPR_LMB_FLAGS_HOTREMOVABLE 0x00000100
 
 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg);
 
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
#2 lore raw

Hello David,

Quoted 3 lines · David Gibson

The change looks reasonable. Is there a PAPR RFC I can see describing the new bit, though?

The ACR is approved and I already added the change to LoPAPR/LOPAR, it's just a matter of time to get it released.
(I think it's accessible to members of OpenPower Foundation)

This is the snippet of the change:

At the bottom of "Table 3.11: Flag Word", add another line containing:
Hot-removable Memory | 0x00000100 | If b'1', this LMB can be hot-
removed.
| | If b'0', this LMB may not be hot-
removed

Best regards,
Leonardo Bras

#3 lore raw
Quoted 10 lines · Leonardo Bras

Hello David,

Quoted 3 lines · David Gibson

The change looks reasonable. Is there a PAPR RFC I can see describing the new bit, though?

The ACR is approved and I already added the change to LoPAPR/LOPAR, it's just a matter of time to get it released.
(I think it's accessible to members of OpenPower Foundation)

Hrm. The latest LoPAPR I can find is from 2016, so a "matter of time" isn't very encouraging.

Quoted 11 lines

This is the snippet of the change:

At the bottom of "Table 3.11: Flag Word", add another line containing:
Hot-removable Memory | 0x00000100 | If b'1', this LMB can be hot-
removed.
| | If b'0', this LMB may not be hot-
removed

Best regards,
Leonardo Bras

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
#4 lore raw
Quoted 7 lines · David Gibson
Quoted 6 lines · Leonardo Bras

Hello David,

Quoted 2 lines · David Gibson

The change looks reasonable. Is there a PAPR RFC I can see describing the new bit, though?

Quoted 6 lines
Quoted 3 lines

The ACR is approved and I already added the change to LoPAPR/LOPAR, it's just a matter of time to get it released.
(I think it's accessible to members of OpenPower Foundation)

Hrm. The latest LoPAPR I can find is from 2016, so a "matter of time" isn't very encouraging.

I understand the feeling.
There is a new initiative inside the OpenPower Foundation to keep these documents updated.

I think we will be able to have more frequent updates of the documentation soon.

Best Regards,

#5 lore raw
Quoted 15 lines · Leonardo Bras
Quoted 7 lines · David Gibson
Quoted 6 lines · Leonardo Bras

Hello David,

Quoted 2 lines · David Gibson

The change looks reasonable. Is there a PAPR RFC I can see describing the new bit, though?

Quoted 6 lines
Quoted 3 lines

The ACR is approved and I already added the change to LoPAPR/LOPAR, it's just a matter of time to get it released.
(I think it's accessible to members of OpenPower Foundation)

Hrm. The latest LoPAPR I can find is from 2016, so a "matter of time" isn't very encouraging.

Quoted 6 lines

I understand the feeling.
There is a new initiative inside the OpenPower Foundation to keep these documents updated.

I think we will be able to have more frequent updates of the documentation soon.

Urgh. Ok, I'm sorry Leonardo, but,

Nack. I will not merge a change where my only knowledge of the spec has to be based on hearsay.

By all means use this as ammunition to convince IBM and/or the openpower foundation to expedite getting a workable document release process up and running.

Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
#6 lore raw
Quoted 8 lines · David Gibson

Urgh. Ok, I'm sorry Leonardo, but,

Nack. I will not merge a change where my only knowledge of the spec has to be based on hearsay.

By all means use this as ammunition to convince IBM and/or the openpower foundation to expedite getting a workable document release process up and running.

No problem David, of course I understand your point.

I am working on this document release, and it will probably be available soon.

When it is, we can visit this patch again.

Best regards,
Leonardo Bras