ethdev: fix for compiler warning when vtune profiling is on
PATCH v4 1/1 ethdev: fix for compiler warning when vtune profiling is on
From: Eugeny Parshutin <[email protected]>
Add the previous prototype for the 'profile_hook_rx_burst_cb' function to fix the compiler warning when the DPDK is built with 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled:/home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning:
no previous prototype for profile_hook_rx_burst_cb [-Wmissing-prototypes]
---
v2: Fix the commit message
v3: Fix the check-git-log.sh warnings:
- make headline shorter
- add 'Fixes' tag
v4: Adapt 'Fixes' section to commit message guidelines
--- lib/librte_ethdev/ethdev_profile.h | 10 ++++++++++ 1 file changed, 10 insertions(+)
lib/librte_ethdev/ethdev_profile.h +10 -0
@@ -24,4 +24,14 @@int __rte_eth_dev_profile_init (uint16_t port_id,struct rte_eth_dev *dev); +#ifdef RTE_ETHDEV_PROFILE_WITH_VTUNE + +uint16_t +profile_hook_rx_burst_cb ( + __rte_unused uint16_t port_id, __rte_unused uint16_t queue_id, + __rte_unused struct rte_mbuf *pkts[], uint16_t nb_pkts, + __rte_unused uint16_t max_pkts, __rte_unused void *user_param); + +#endif /* RTE_ETHDEV_PROFILE_WITH_VTUNE */ +#endif
Signature · 1 line
2.17.1
Quoted 10 lines · On 4/2/2020 7:45 PM, [email protected] wrote:
From: Eugeny Parshutin <[email protected]>
Add the previous prototype for the '
profile_hook_rx_burst_cb' function to fix the compiler warning when the DPDK is built with 'RTE_ETHDEV_PROFILE_WITH_VTUNE' config option enabled:/home/dpdk/lib/librte_ethdev/ethdev_profile.c:17:1: warning:
no previous prototype forprofile_hook_rx_burst_cb[-Wmissing-prototypes]Fixes 2c1bbab7f09d ("ethdev: change vtune profiling approach")
Hi Eugeny,
Thanks for the fix.
Can you please add the "Cc: [email protected]" tag just below the Fixes line, this to request backporting the fix to stable trees, which is required for this case since this is a build fix.
Quoted 19 lines
Signed-off-by Eugeny Parshutin <[email protected]>---
v2: Fix the commit messagev3: Fix the
check-git-log.shwarnings:
- make headline shorter
- add 'Fixes' tagv4: Adapt 'Fixes' section to commit message guidelines
--- lib/librte_ethdev/ethdev_profile.h | 10 ++++++++++ 1 file changed, 10 insertions(+)lib/librte_ethdev/ethdev_profile.h +0
-0
lib/librte_ethdev/ethdev_profile.h line 30
Quoted 7 lines
lib/librte_ethdev/ethdev_profile.h +4
-0@@ -24,4 +24,14 @@int __rte_eth_dev_profile_init (uint16_t port_id,struct rte_eth_dev *dev); +#ifdef RTE_ETHDEV_PROFILE_WITH_VTUNE + +uint16_t +profile_hook_rx_burst_cb(
minor comment, but can you please don't end the line with open parenthesis, '(', but continue the param list in above line. (I am aware this is how done while calling the function, but better to fix here.)
lib/librte_ethdev/ethdev_profile.h line 31
Quoted 1 line
lib/librte_ethdev/ethdev_profile.h +1
-0+ __rte_unused uint16_t port_id, __rte_unused uint16_t queue_id,
'__rte_unused' tag is not required in the function deceleration, can you please remove them.
Quoted 7 lines
lib/librte_ethdev/ethdev_profile.h +5
-0+ __rte_unused struct rte_mbuf *pkts[], uint16_t nb_pkts, + __rte_unused uint16_t max_pkts, __rte_unused void *user_param); + +#endif /* RTE_ETHDEV_PROFILE_WITH_VTUNE */ +#endif