PM / devfreq: tegra30: Make CPUFreq notifier to take into account boosting
Subsystems (3)
Dmitry Osipenko
maintainerPATCH v2 1/1 PM / devfreq: tegra30: Make CPUFreq notifier to take into account boosting
We're taking into account both HW memory-accesses + CPU activity based on current CPU's frequency. For memory-accesses there is a kind of hysteresis in a form of "boosting" which is managed by the tegra30-devfreq driver. If current HW memory activity is higher than activity judged based of the CPU's frequency, then there is no need to schedule cpufreq_update_work because the result of the work will be a NO-OP. And thus, tegra_actmon_cpufreq_contribution() should return 0, meaning that at the moment CPU frequency doesn't contribute anything to the final decision about required memory clock rate.
---
Changelog:
v2: - Made commit's message more detailed, which was requested by Chanwoo Choi
in the review comment to v1.
- This patch is now made to be standalone because there are no dependencies in regards to this change.
drivers/devfreq/tegra30-devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/devfreq/tegra30-devfreq.c +1 -1
@@ -420,7 +420,7 @@ tegra_actmon_cpufreq_contribution(struct tegra_devfreq *tegra, static_cpu_emc_freq =actmon_cpu_to_emc_rate (tegra, cpu_freq); -if (dev_freq >= static_cpu_emc_freq) +if (dev_freq + actmon_dev->boost_freq >= static_cpu_emc_freq)return 0 ;return static_cpu_emc_freq;
Signature · 1 line
2.25.1
Quoted 30 lines · Dmitry Osipenko
We're taking into account both HW memory-accesses + CPU activity based on current CPU's frequency. For memory-accesses there is a kind of hysteresis in a form of "boosting" which is managed by the tegra30-devfreq driver. If current HW memory activity is higher than activity judged based of the CPU's frequency, then there is no need to schedule
cpufreq_update_workbecause the result of the work will be a NO-OP. And thus,tegra_actmon_cpufreq_contribution()should return 0, meaning that at the moment CPU frequency doesn't contribute anything to the final decision about required memory clock rate.Signed-off-by Dmitry Osipenko <[email protected]>---
Changelog:
v2: - Made commit's message more detailed, which was requested by Chanwoo Choi
in the review comment to v1.- This patch is now made to be standalone because there are no dependencies in regards to this change.
drivers/devfreq/tegra30-devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/devfreq/tegra30-devfreq.c +0
-0
drivers/devfreq/tegra30-devfreq.c tegra_actmon_cpufreq_contribution(struct tegra_devfreq *tegra, · line 426
Quoted 8 lines
drivers/devfreq/tegra30-devfreq.c +1
-1@@ -420,7 +420,7 @@ tegra_actmon_cpufreq_contribution(struct tegra_devfreq *tegra, static_cpu_emc_freq =actmon_cpu_to_emc_rate (tegra, cpu_freq); -if (dev_freq >= static_cpu_emc_freq) +if (dev_freq + actmon_dev->boost_freq >= static_cpu_emc_freq)return 0 ;return static_cpu_emc_freq;
Applied it. Thanks.
Signature · 3 lines
Best Regards, Chanwoo Choi Samsung Electronics