Skip to contentSkip to conversation

s390x: unittests: Use smp parameter

PATCH In review Andrew Jones 2 participants 4 messages Apr 3, 2020 KVM

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 s390x: unittests: Use smp parameter

---

v2: Really just a repost, but also picked up the tags.

 s390x/unittests.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/unittests.cfg +1 -1
index 07013b2b8748..aa6d5d96e292 100644
@@ -74,7 +74,7 @@ file = stsi.elf
 
 [smp]
 file = smp.elf
-extra_params =-smp 2
+smp = 2
 
 [sclp-1g]
 file = sclp.elf
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Andrew Jones

---

v2: Really just a repost, but also picked up the tags.

(sorry, missed to pick this one up)

Quoted 10 lines
 s390x/unittests.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/unittests.cfg +0 -0
index 07013b2b8748..aa6d5d96e292 100644

s390x/unittests.cfg file = stsi.elf · line 80

Quoted 8 lines
s390x/unittests.cfg +1 -1
@@ -74,7 +74,7 @@ file = stsi.elf
 
 [smp]
 file = smp.elf
-extra_params =-smp 2
+smp = 2
 
 [sclp-1g]
 file = sclp.elf

Thanks, queued to

https://github.com/davidhildenbrand/kvm-unit-tests.git s390x-next

On the branch, we also do have

[stsi]
file = stsi.elf
extra_params=-name kvm-unit-test --uuid 0fb84a86-727c-11ea-bc55-0242ac130003 -smp 1,maxcpus=8

Can that be expressed similarly?

Signature · 3 lines
Thanks,

David / dhildenb
#2 lore raw
Quoted 33 lines · David Hildenbrand
Quoted 6 lines · Andrew Jones

---

v2: Really just a repost, but also picked up the tags.

(sorry, missed to pick this one up)

Quoted 10 lines
 s390x/unittests.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/unittests.cfg +0 -0
index 07013b2b8748..aa6d5d96e292 100644

s390x/unittests.cfg file = stsi.elf · line 80

Quoted 8 lines
s390x/unittests.cfg +1 -1
@@ -74,7 +74,7 @@ file = stsi.elf
 
 [smp]
 file = smp.elf
-extra_params =-smp 2
+smp = 2
 
 [sclp-1g]
 file = sclp.elf

Thanks, queued to

https://github.com/davidhildenbrand/kvm-unit-tests.git s390x-next

Quoted 8 lines

On the branch, we also do have

[stsi]
file = stsi.elf
extra_params=-name kvm-unit-test --uuid 0fb84a86-727c-11ea-bc55-0242ac130003 -smp 1,maxcpus=8

Can that be expressed similarly?

It would still work with QEMU if you changed it to

extra_params=-name kvm-unit-test --uuid 0fb84a86-727c-11ea-bc55-0242ac130003 smp = 1,maxcpus=8

which is similar to what powerpc has with one of their tests

smp = 2,threads=2

About the only problem I see with that is that we've documented the 'smp' unittests parameter as taking a '<num>', and if we want to get other KVM userspaces working with kvm-unit-tests then we should try to keep our unittests.cfg files VMM agnostic, and stick to its documentation.

IOW, I'd probably leave 'stsi' as is.

Thanks,
drew

#3 lore raw
Quoted 52 lines · Andrew Jones
Quoted 33 lines · David Hildenbrand
Quoted 6 lines · Andrew Jones

---

v2: Really just a repost, but also picked up the tags.

(sorry, missed to pick this one up)

Quoted 10 lines
 s390x/unittests.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/unittests.cfg +0 -0
index 07013b2b8748..aa6d5d96e292 100644

s390x/unittests.cfg file = stsi.elf · line 80

Quoted 8 lines
s390x/unittests.cfg +1 -1
@@ -74,7 +74,7 @@ file = stsi.elf
 
 [smp]
 file = smp.elf
-extra_params =-smp 2
+smp = 2
 
 [sclp-1g]
 file = sclp.elf

Thanks, queued to

https://github.com/davidhildenbrand/kvm-unit-tests.git s390x-next

Quoted 8 lines

On the branch, we also do have

[stsi]
file = stsi.elf
extra_params=-name kvm-unit-test --uuid 0fb84a86-727c-11ea-bc55-0242ac130003 -smp 1,maxcpus=8

Can that be expressed similarly?

It would still work with QEMU if you changed it to

extra_params=-name kvm-unit-test --uuid 0fb84a86-727c-11ea-bc55-0242ac130003 smp = 1,maxcpus=8

which is similar to what powerpc has with one of their tests

smp = 2,threads=2

Quoted 8 lines

About the only problem I see with that is that we've documented the 'smp' unittests parameter as taking a '<num>', and if we want to get other KVM userspaces working with kvm-unit-tests then we should try to keep our unittests.cfg files VMM agnostic, and stick to its documentation.

IOW, I'd probably leave 'stsi' as is.

Makes sense, thanks!

Signature · 3 lines
Thanks,

David / dhildenb