Various build and doc fixes
PATCH v2 1/4 configure: Drop unneeded TARGET_CFLAGS expansion
In reply to Daniel Kiper--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
@@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file]) # Optimization flag. Allow user to override. if test "x$TARGET_CFLAGS" = x; then - TARGET_CFLAGS="$TARGET_CFLAGS -Os" + TARGET_CFLAGS=-Os fi # Default HOST_CPPFLAGS
Signature · 1 line
2.11.0
PATCH v2 3/4 INSTALL/configure: Update install doc and configure comment
In reply to Daniel Kiper..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
--- INSTALL | 51 +++++++++++++++++++++++++++------------------------ configure.ac | 10 ++++++---- 2 files changed, 33 insertions(+), 28 deletions(-)
INSTALL +27 -24
@@ -160,12 +160,12 @@ For this example the configure line might look like (more details below) (some options are optional and included here for completeness but some rarely used options are omitted): -./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu -CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-config ---target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc -TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" -TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" -TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflex +./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu \ + CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-config \ + --target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc \ + TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" \ + TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" \ + TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflex You need to use following options to specify tools and platforms. For minimum version look at prerequisites. All tools not mentioned in this section under
@@ -182,28 +182,31 @@ corresponding platform are not needed for the platform in question. - For host 1. --host= to autoconf name of host. - 2. CC= for gcc able to compile for host - 3. HOST_CFLAGS= for C options for host. - 4. HOST_CPPFLAGS= for C preprocessor options for host. - 5. HOST_LDFLAGS= for linker options for host. - 6. PKG_CONFIG= for pkg-config for host (optional). - 7. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). - 8. Libfuse if any must be in standard linker folders (-lfuse) (optional). - 9. Libzfs if any must be in standard linker folders (-lzfs) (optional). - 10. Liblzma if any must be in standard linker folders (-llzma) (optional). + 2. CC= for gcc able to compile for host and target. + 3. CFLAGS= for C options for host and target. + 4. HOST_CFLAGS= for C options for host. + 5. HOST_CPPFLAGS= for C preprocessor options for host. + 6. HOST_LDFLAGS= for linker options for host. + 7. PKG_CONFIG= for pkg-config for host (optional). + 8. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). + 9. Libfuse if any must be in standard linker folders (-lfuse) (optional). + 10. Libzfs if any must be in standard linker folders (-lzfs) (optional). + 11. Liblzma if any must be in standard linker folders (-llzma) (optional). - For target 1. --target= to autoconf cpu name of target. 2. --with-platform to choose firmware. - 3. TARGET_CC= for gcc able to compile for target - 4. TARGET_CFLAGS= for C options for target. - 5. TARGET_CPPFLAGS= for C preprocessor options for target. - 6. TARGET_CCASFLAGS= for assembler options for target. - 7. TARGET_LDFLAGS= for linker options for target. - 8. TARGET_OBJCOPY= for objcopy for target. - 9. TARGET_STRIP= for strip for target. - 10. TARGET_NM= for nm for target. - 11. TARGET_RANLIB= for ranlib for target. + 3. CC= for gcc able to compile for host and target. + 4. CFLAGS= for C options for host and target. + 5. TARGET_CC= for gcc able to compile for target. + 6. TARGET_CFLAGS= for C options for target. + 7. TARGET_CPPFLAGS= for C preprocessor options for target. + 8. TARGET_CCASFLAGS= for assembler options for target. + 9. TARGET_LDFLAGS= for linker options for target. + 10. TARGET_OBJCOPY= for objcopy for target. + 11. TARGET_STRIP= for strip for target. + 12. TARGET_NM= for nm for target. + 13. TARGET_RANLIB= for ranlib for target. - Additionally for emu, for host and target. 1. SDL is looked for in standard linker directories (-lSDL) (optional)
configure.ac +6 -4
@@ -26,10 +26,12 @@ dnl This is necessary because the target type in autoconf does not dnl describe such a system very well. dnl dnl The current strategy is to use variables with no prefix (such as -dnl CC, CFLAGS, etc.) for the host type, variables with prefix "BUILD_" -dnl (such as BUILD_CC, BUILD_CFLAGS, etc.) for the build type and variables -dnl with the prefix "TARGET_" (such as TARGET_CC, TARGET_CFLAGS, etc.) are -dnl used for the target type. See INSTALL for full list of variables. +dnl CC, CFLAGS, etc.) for the host and target type, variables with +dnl prefix "BUILD_" (such as BUILD_CC, BUILD_CFLAGS, etc.) for the +dnl build type, variables with prefix "HOST_" (such as HOST_CC, +dnl HOST_CFLAGS, etc.) for the host type and variables with the prefix +dnl "TARGET_" (such as TARGET_CC, TARGET_CFLAGS, etc.) are used for +dnl the target type. See INSTALL for full list of variables. AC_INIT([GRUB],[2.05],[[email protected]])
Signature · 1 line
2.11.0
PATCH v2 2/4 configure: Enforce gnu99 C language standard
In reply to Daniel KiperCommit d5a32255d (misc: Make grub_strtol() "end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the breakage during builds when c89 or gnu89 is in force. So, let's enforce gnu99 C language standard for all compilers. This way a bit random build issue will be fixed and the GRUB source will be build consistently regardless of type and version of the compiler.
It was decided to use gnu99 C language standard because it fixes the issue mentioned above and also provides some useful extensions which are used here and there in the GRUB source. Potentially we can use gnu11 too. However, this may reduce pool of older compilers which can be used to build the GRUB. So, let's live with gnu99 until we do not discover that we strongly require a feature from newer C standard.
---
v2 - suggestions/fixes:
- unconditionally enforce gnu99 C language standard (suggested by Leif Lindholm).
--- configure.ac | 4 ++++ 1 file changed, 4 insertions(+)
configure.ac +4 -0
@@ -80,6 +80,10 @@ if test "x$TARGET_CFLAGS" = x; then TARGET_CFLAGS=-Os fi +BUILD_CFLAGS="-std=gnu99 $BUILD_CFLAGS" +HOST_CFLAGS="-std=gnu99 $HOST_CFLAGS" +TARGET_CFLAGS="-std=gnu99 $TARGET_CFLAGS" + # Default HOST_CPPFLAGS HOST_CPPFLAGS="$HOST_CPPFLAGS -Wall -W" HOST_CPPFLAGS="$HOST_CPPFLAGS -DGRUB_UTIL=1"
Signature · 1 line
2.11.0
v2 cover Various build and doc fixes
Hey,
As in subject... Please review...
Daniel
INSTALL | 51 +++++++++++++++++++++++++++------------------------ autogen.sh | 2 +- configure.ac | 16 +++++++++++----- 3 files changed, 39 insertions(+), 30 deletions(-)
Daniel Kiper (4):
configure: Drop unneeded TARGET_CFLAGS expansion
configure: Enforce gnu99 C language standard INSTALL/configure: Update install doc and configure comment
autogen: Replace -iname with -ipath in find command
PATCH v2 4/4 autogen: Replace -iname with -ipath in find command
..because -iname cannot be used to match paths.
--- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
autogen.sh +1 -1
@@ -13,7 +13,7 @@ fi export LC_COLLATE=C unset LC_ALL -find . -iname '*.[ch]' ! -ipath './grub-core/lib/libgcrypt-grub/*' ! -ipath './build-aux/*' ! -ipath './grub-core/lib/libgcrypt/src/misc.c' ! -ipath './grub-core/lib/libgcrypt/src/global.c' ! -ipath './grub-core/lib/libgcrypt/src/secmem.c' ! -ipath './util/grub-gen-widthspec.c' ! -ipath './util/grub-gen-asciih.c' ! -ipath './gnulib/*' ! -iname './grub-core/lib/gnulib/*' |sort > po/POTFILES.in +find . -iname '*.[ch]' ! -ipath './grub-core/lib/libgcrypt-grub/*' ! -ipath './build-aux/*' ! -ipath './grub-core/lib/libgcrypt/src/misc.c' ! -ipath './grub-core/lib/libgcrypt/src/global.c' ! -ipath './grub-core/lib/libgcrypt/src/secmem.c' ! -ipath './util/grub-gen-widthspec.c' ! -ipath './util/grub-gen-asciih.c' ! -ipath './gnulib/*' ! -ipath './grub-core/lib/gnulib/*' |sort > po/POTFILES.in find util -iname '*.in' ! -name Makefile.in |sort > po/POTFILES-shell.in echo "Importing unicode..."
Signature · 1 line
2.11.0
Re: [PATCH v2 1/4] configure: Drop unneeded TARGET_CFLAGS expansion
In reply to Daniel Kiperconfigure.ac grub_TRANSFORM([grub-file]) · line 81
Quoted 11 lines · Daniel Kiper
configure.ac +1
-1@@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file]) # Optimization flag. Allow user to override. if test "x$TARGET_CFLAGS" = x; then - TARGET_CFLAGS="$TARGET_CFLAGS -Os" + TARGET_CFLAGS=-Os fi
Good catch. It took me a few seconds to realize that the conditional is only true and "-Os" added when TARGET_CFLAGS is not set by the user :).
Adrian
Signature · 4 lines
.''`. John Paul Adrian Glaubitz : :' : Debian Developer - [email protected] `. `' Freie Universitaet Berlin - [email protected] `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Re: [PATCH v2 1/4] configure: Drop unneeded TARGET_CFLAGS expansion
In reply to Daniel KiperQuoted 10 lines · Daniel Kiper
Signed-off-by Daniel Kiper <[email protected]>--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)configure.ac +0
-0
configure.ac grub_TRANSFORM([grub-file]) · line 82
Quoted 7 lines
configure.ac +1
-1@@ -77,7 +77,7 @@ grub_TRANSFORM([grub-file]) # Optimization flag. Allow user to override. if test "x$TARGET_CFLAGS" = x; then - TARGET_CFLAGS="$TARGET_CFLAGS -Os" + TARGET_CFLAGS=-Os fi
Best regards,
Signature · 3 lines
Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
Re: [PATCH v2 2/4] configure: Enforce gnu99 C language standard
In reply to Daniel KiperQuoted 30 lines · Daniel Kiper
Commit
d5a32255d(misc: Makegrub_strtol()"end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the breakage during builds when c89 or gnu89 is in force. So, let's enforce gnu99 C language standard for all compilers. This way a bit random build issue will be fixed and the GRUB source will be build consistently regardless of type and version of the compiler.It was decided to use gnu99 C language standard because it fixes the issue mentioned above and also provides some useful extensions which are used here and there in the GRUB source. Potentially we can use gnu11 too. However, this may reduce pool of older compilers which can be used to build the GRUB. So, let's live with gnu99 until we do not discover that we strongly require a feature from newer C standard.
Signed-off-by Daniel Kiper <[email protected]>---
v2 - suggestions/fixes:
- unconditionally enforce gnu99 C language standard (suggested by Leif Lindholm).--- configure.ac | 4 ++++ 1 file changed, 4 insertions(+)configure.ac +0
-0
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 82
Quoted 3 lines
configure.ac +0
-0@@ -80,6 +80,10 @@ if test "x$TARGET_CFLAGS" = x; then TARGET_CFLAGS=-Os fi
I would add a comment here explaining why gnu99 is enforced.
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 86
Quoted 4 lines
configure.ac +4
-0+BUILD_CFLAGS="-std=gnu99 $BUILD_CFLAGS" +HOST_CFLAGS="-std=gnu99 $HOST_CFLAGS" +TARGET_CFLAGS="-std=gnu99 $TARGET_CFLAGS" +
Do you want to allow distros to override the -std option or do you want to always force to use gnu99? If the latter then I think instead it should be:
BUILD_CFLAGS="$BUILD_CFLAGS -std=gnu99"
HOST_CFLAGS="$HOST_CFLAGS -std=gnu99"
TARGET_CFLAGS="$TARGET_CFLAGS -std=gnu99"
Best regards,
Signature · 3 lines
Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
Re: [PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment
In reply to Daniel KiperQuoted 10 lines · Daniel Kiper
..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
Signed-off-by Daniel Kiper <[email protected]>--- INSTALL | 51 +++++++++++++++++++++++++++------------------------ configure.ac | 10 ++++++---- 2 files changed, 33 insertions(+), 28 deletions(-)
Best regards,
Signature · 3 lines
Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
Re: [PATCH v2 4/4] autogen: Replace -iname with -ipath in find command
In reply to Daniel KiperQuoted 4 lines · Daniel Kiper
..because -iname cannot be used to match paths.
Signed-off-by Daniel Kiper <[email protected]>---
Best regards,
Signature · 3 lines
Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
Re: [PATCH v2 2/4] configure: Enforce gnu99 C language standard
In reply to Javier Martinez CanillasQuoted 26 lines · Javier Martinez Canillas
Quoted 25 lines · Daniel Kiper
Commit
d5a32255d(misc: Makegrub_strtol()"end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the breakage during builds when c89 or gnu89 is in force. So, let's enforce gnu99 C language standard for all compilers. This way a bit random build issue will be fixed and the GRUB source will be build consistently regardless of type and version of the compiler.It was decided to use gnu99 C language standard because it fixes the issue mentioned above and also provides some useful extensions which are used here and there in the GRUB source. Potentially we can use gnu11 too. However, this may reduce pool of older compilers which can be used to build the GRUB. So, let's live with gnu99 until we do not discover that we strongly require a feature from newer C standard.
Signed-off-by Daniel Kiper <[email protected]>---
v2 - suggestions/fixes:
- unconditionally enforce gnu99 C language standard (suggested by Leif Lindholm).--- configure.ac | 4 ++++ 1 file changed, 4 insertions(+)
Quoted 10 lines
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 82
Quoted 8 lines
configure.ac +0
-0@@ -80,6 +80,10 @@ if test "x$TARGET_CFLAGS" = x; then TARGET_CFLAGS=-Os fiI would add a comment here explaining why gnu99 is enforced.
I am not convinced that we should repeat here what is said in the commit message...
Quoted 11 lines
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 86
Quoted 4 lines
configure.ac +4
-0+BUILD_CFLAGS="-std=gnu99 $BUILD_CFLAGS" +HOST_CFLAGS="-std=gnu99 $HOST_CFLAGS" +TARGET_CFLAGS="-std=gnu99 $TARGET_CFLAGS" +Do you want to allow distros to override the -std option or do you want to always force to use gnu99? If the latter then I think instead it should be:
BUILD_CFLAGS="$BUILD_CFLAGS -std=gnu99"
HOST_CFLAGS="$HOST_CFLAGS -std=gnu99"
TARGET_CFLAGS="$TARGET_CFLAGS -std=gnu99"
I want to allow everybody to override the defaults. In general I think that we should not impose any artificial limits. If user wants to shoot in his/her foot he/she should be allowed to do that... In most cases...
Daniel
Re: [PATCH v2 2/4] configure: Enforce gnu99 C language standard
In reply to Daniel KiperQuoted 9 lines · Daniel Kiper
Commit
d5a32255d(misc: Makegrub_strtol()"end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the breakage during builds when c89 or gnu89 is in force. So, let's enforce gnu99 C language standard for all compilers. This way a bit random build issue will be fixed and the GRUB source will be build consistently regardless of type and version of the compiler.
Quoted 5 lines
It was decided to use gnu99 C language standard because it fixes the issue mentioned above and also provides some useful extensions which are used here and there in the GRUB source. Potentially we can use gnu11 too. However, this may reduce pool of older compilers which can be used to build the GRUB. So, let's live with gnu99 until we do not discover that
Drop "do not"?
Quoted 16 lines
we strongly require a feature from newer C standard.
Signed-off-by Daniel Kiper <[email protected]>---
v2 - suggestions/fixes:
- unconditionally enforce gnu99 C language standard (suggested by Leif Lindholm).--- configure.ac | 4 ++++ 1 file changed, 4 insertions(+)configure.ac +0
-0
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 85
Quoted 6 lines
configure.ac +3
-0@@ -80,6 +80,10 @@ if test "x$TARGET_CFLAGS" = x; then TARGET_CFLAGS=-Os fi +BUILD_CFLAGS="-std=gnu99 $BUILD_CFLAGS" +HOST_CFLAGS="-std=gnu99 $HOST_CFLAGS" +TARGET_CFLAGS="-std=gnu99 $TARGET_CFLAGS"
Agree with Javier that it would be helpful to explain reason for enforcing gnu99 in a comment.
"// Enable support for 'restrict' keyword"
Would be enough.
/
Leif
Quoted 7 lines
configure.ac +1
-0+ # Default HOST_CPPFLAGS HOST_CPPFLAGS="$HOST_CPPFLAGS -Wall -W" HOST_CPPFLAGS="$HOST_CPPFLAGS -DGRUB_UTIL=1"Signature · 1 line
2.11.0
Re: [PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment
In reply to Daniel KiperQuoted 20 lines · Daniel Kiper
..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
Signed-off-by Daniel Kiper <[email protected]>--- INSTALL | 51 +++++++++++++++++++++++++++------------------------ configure.ac | 10 ++++++---- 2 files changed, 33 insertions(+), 28 deletions(-)INSTALL +0
-2@@ -160,12 +160,12 @@ For this example the configure line might look like (more details below) (some options are optional and included here for completeness but some rarely used options are omitted): -./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu -CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-config
INSTALL For this example the configure line might look like (more details below) · line 168
Quoted 10 lines
INSTALL +6
-4---target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc -TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" -TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" -TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflex +./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu \ + CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-config \ + --target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc \ + TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" \ + TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" \ + TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflex
So ... probably should have looked more properly at this round 1.
If we are updating this guidance, should we bring it up to date as well?
Now we have uefi support in u-boot, the "uboot" platform is the exception rather than the norm. It'd be better to specify --with-platform=efi.
Secondly, these appear to be flags used when
building GRUB for Raspberry Pi 1; -march-armv6 is quite outdated and could be dropped. (Although I guess it becomes more relevant when seen in combination with TARGET_CCASFLAGS.)
Could we add a sentence here going (if switching to efi for the platform):
"Normally, for building a grub on amd64 with tools to run on amd64 to generate images to run on arm, using your Linux distribution's packaged cross compiler, the following would suffice:
./configure --target=arm-linux-gnueabihf --with-platform=efi"
Quoted 7 lines
INSTALL +0
-0You need to use following options to specify tools and platforms. For minimum version look at prerequisites. All tools not mentioned in this section under@@ -182,28 +182,31 @@ corresponding platform are not needed for the platform in question. - For host 1. --host= to autoconf name of host.
INSTALL corresponding platform are not needed for the platform in question. · line 185
Quoted 10 lines
INSTALL +1
-9- 2. CC= for gcc able to compile for host - 3. HOST_CFLAGS= for C options for host. - 4. HOST_CPPFLAGS= for C preprocessor options for host. - 5. HOST_LDFLAGS= for linker options for host. - 6. PKG_CONFIG= for pkg-config for host (optional). - 7. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). - 8. Libfuse if any must be in standard linker folders (-lfuse) (optional). - 9. Libzfs if any must be in standard linker folders (-lzfs) (optional). - 10. Liblzma if any must be in standard linker folders (-llzma) (optional). + 2. CC= for gcc able to compile for host and target.
But this is incorrect? Apart from where HOST == TARGET? And goes against the example updated above.
Am I missing something?
Quoted 13 lines
INSTALL +9
-0+ 3. CFLAGS= for C options for host and target. + 4. HOST_CFLAGS= for C options for host. + 5. HOST_CPPFLAGS= for C preprocessor options for host. + 6. HOST_LDFLAGS= for linker options for host. + 7. PKG_CONFIG= for pkg-config for host (optional). + 8. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). + 9. Libfuse if any must be in standard linker folders (-lfuse) (optional). + 10. Libzfs if any must be in standard linker folders (-lzfs) (optional). + 11. Liblzma if any must be in standard linker folders (-llzma) (optional). - For target 1. --target= to autoconf cpu name of target. 2. --with-platform to choose firmware.
INSTALL corresponding platform are not needed for the platform in question. · line 199
Quoted 10 lines
INSTALL +1
-9- 3. TARGET_CC= for gcc able to compile for target - 4. TARGET_CFLAGS= for C options for target. - 5. TARGET_CPPFLAGS= for C preprocessor options for target. - 6. TARGET_CCASFLAGS= for assembler options for target. - 7. TARGET_LDFLAGS= for linker options for target. - 8. TARGET_OBJCOPY= for objcopy for target. - 9. TARGET_STRIP= for strip for target. - 10. TARGET_NM= for nm for target. - 11. TARGET_RANLIB= for ranlib for target. + 3. CC= for gcc able to compile for host and target.
Same again.
Quoted 18 lines
INSTALL +10
-0+ 4. CFLAGS= for C options for host and target. + 5. TARGET_CC= for gcc able to compile for target. + 6. TARGET_CFLAGS= for C options for target. + 7. TARGET_CPPFLAGS= for C preprocessor options for target. + 8. TARGET_CCASFLAGS= for assembler options for target. + 9. TARGET_LDFLAGS= for linker options for target. + 10. TARGET_OBJCOPY= for objcopy for target. + 11. TARGET_STRIP= for strip for target. + 12. TARGET_NM= for nm for target. + 13. TARGET_RANLIB= for ranlib for target. - Additionally for emu, for host and target. 1. SDL is looked for in standard linker directories (-lSDL) (optional)configure.ac +0
-0
configure.ac dnl This is necessary because the target type in autoconf does not · line 29
Quoted 8 lines
configure.ac +1
-4@@ -26,10 +26,12 @@ dnl This is necessary because the target type in autoconf does not dnl describe such a system very well. dnl dnl The current strategy is to use variables with no prefix (such as -dnl CC, CFLAGS, etc.) for the host type, variables with prefix "BUILD_" -dnl (such as BUILD_CC, BUILD_CFLAGS, etc.) for the build type and variables -dnl with the prefix "TARGET_" (such as TARGET_CC, TARGET_CFLAGS, etc.) are -dnl used for the target type. See INSTALL for full list of variables. +dnl CC, CFLAGS, etc.) for the host and target type, variables with
Same again.
/
Leif
Quoted 11 lines
configure.ac +5
-0+dnl prefix "BUILD_" (such as BUILD_CC, BUILD_CFLAGS, etc.) for the +dnl build type, variables with prefix "HOST_" (such as HOST_CC, +dnl HOST_CFLAGS, etc.) for the host type and variables with the prefix +dnl "TARGET_" (such as TARGET_CC, TARGET_CFLAGS, etc.) are used for +dnl the target type. See INSTALL for full list of variables. AC_INIT([GRUB],[2.05],[[email protected]])Signature · 1 line
2.11.0
Re: [PATCH v2 2/4] configure: Enforce gnu99 C language standard
In reply to Daniel KiperQuoted 49 lines · Daniel Kiper
Quoted 26 lines · Javier Martinez Canillas
Quoted 25 lines · Daniel Kiper
Commit
d5a32255d(misc: Makegrub_strtol()"end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the breakage during builds when c89 or gnu89 is in force. So, let's enforce gnu99 C language standard for all compilers. This way a bit random build issue will be fixed and the GRUB source will be build consistently regardless of type and version of the compiler.It was decided to use gnu99 C language standard because it fixes the issue mentioned above and also provides some useful extensions which are used here and there in the GRUB source. Potentially we can use gnu11 too. However, this may reduce pool of older compilers which can be used to build the GRUB. So, let's live with gnu99 until we do not discover that we strongly require a feature from newer C standard.
Signed-off-by Daniel Kiper <[email protected]>---
v2 - suggestions/fixes:
- unconditionally enforce gnu99 C language standard (suggested by Leif Lindholm).--- configure.ac | 4 ++++ 1 file changed, 4 insertions(+)Quoted 10 lines
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 82
Quoted 8 lines
configure.ac +0
-0@@ -80,6 +80,10 @@ if test "x$TARGET_CFLAGS" = x; then TARGET_CFLAGS=-Os fiI would add a comment here explaining why gnu99 is enforced.
I am not convinced that we should repeat here what is said in the commit message...
Quoted 8 lines
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 86
Quoted 4 lines
configure.ac +4
-0+BUILD_CFLAGS="-std=gnu99 $BUILD_CFLAGS" +HOST_CFLAGS="-std=gnu99 $HOST_CFLAGS" +TARGET_CFLAGS="-std=gnu99 $TARGET_CFLAGS" +Do you want to allow distros to override the -std option or do you want to always force to use gnu99? If the latter then I think instead it should be:
Quoted 7 lines
Quoted 3 lines
BUILD_CFLAGS="$BUILD_CFLAGS -std=gnu99"
HOST_CFLAGS="$HOST_CFLAGS -std=gnu99"
TARGET_CFLAGS="$TARGET_CFLAGS -std=gnu99"I want to allow everybody to override the defaults. In general I think that we should not impose any artificial limits. If user wants to shoot in his/her foot he/she should be allowed to do that... In most cases...
If we were to prevent builders from overriding, we would also prevent them from overriding with a *higher* version. I think that would be undesirable.
Whereas setting it by default and letting it be overridden means if it breaks the build, it's because the builder has requested options no longer supported by the codebase.
/
Leif
Javier Martinez Canillas
Reviewed-byRe: [PATCH v2 2/4] configure: Enforce gnu99 C language standard
In reply to Daniel KiperQuoted 8 lines · Daniel Kiper
Quoted 7 lines · Javier Martinez Canillas
Quoted 6 lines · Daniel Kiper
Commit
d5a32255d(misc: Makegrub_strtol()"end" pointers have safer const qualifiers) introduced "restrict" keyword into some functions definitions. This keyword was introduced in C99 standard. However, some compilers by default may use C89 or something different. This behavior leads to the breakage during builds when c89 or gnu89 is in force. So, let's enforce gnu99 C language standard for all compilers. This way
I got confused by the intention of this patch since you said enforce here. Probably it should something like set gnu99 by default and allow users to override.
[snip]
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
I would add a comment here explaining why gnu99 is enforced.
I am not convinced that we should repeat here what is said in the commit message...
I disagree. If you are reading this file is much easier to read the comment than having to do a git blame and git show to figure out the rationale of it.
Quoted 8 lines
Quoted 8 lines
configure.ac if test "x$TARGET_CFLAGS" = x; then · line 86
Quoted 4 lines
configure.ac +4
-0+BUILD_CFLAGS="-std=gnu99 $BUILD_CFLAGS" +HOST_CFLAGS="-std=gnu99 $HOST_CFLAGS" +TARGET_CFLAGS="-std=gnu99 $TARGET_CFLAGS" +Do you want to allow distros to override the -std option or do you want to always force to use gnu99? If the latter then I think instead it should be:
Quoted 8 lines
Quoted 3 lines
BUILD_CFLAGS="$BUILD_CFLAGS -std=gnu99"
HOST_CFLAGS="$HOST_CFLAGS -std=gnu99"
TARGET_CFLAGS="$TARGET_CFLAGS -std=gnu99"I want to allow everybody to override the defaults. In general I think that we should not impose any artificial limits. If user wants to shoot in his/her foot he/she should be allowed to do that... In most cases...
Yes, that makes sense to me. Specially since as Leif said one could want to use a higher version. I just asked since it wasn't clear to me.
The change looks good, so if you re-post feel free to add
Best regards,
Signature · 3 lines
Javier Martinez Canillas Software Engineer - Desktop Hardware Enablement Red Hat
Re: [PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment
In reply to Leif LindholmQuoted 37 lines · Leif Lindholm
Quoted 20 lines · Daniel Kiper
..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
Signed-off-by Daniel Kiper <[email protected]>--- INSTALL | 51 +++++++++++++++++++++++++++------------------------ configure.ac | 10 ++++++---- 2 files changed, 33 insertions(+), 28 deletions(-)INSTALL +0
-2@@ -160,12 +160,12 @@ For this example the configure line might look like (more details below) (some options are optional and included here for completeness but some rarely used options are omitted): -./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu -CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-configINSTALL For this example the configure line might look like (more details below) · line 168
Quoted 10 lines
INSTALL +6
-4---target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc -TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" -TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" -TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflex +./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu \ + CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-config \ + --target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc \ + TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" \ + TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" \ + TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflexSo ... probably should have looked more properly at this round 1.
If we are updating this guidance, should we bring it up to date as well?
Quoted 8 lines
Now we have uefi support in u-boot, the "uboot" platform is the exception rather than the norm. It'd be better to specify --with-platform=efi.
Secondly, these appear to be flags used when
building GRUB for Raspberry Pi 1; -march-armv6 is quite outdated and could be dropped. (Although I guess it becomes more relevant when seen in combination withTARGET_CCASFLAGS.)
What do you think about this:
./configure --host=x86_64-linux-gnu --target=aarch64-linux-gnu \
--with-platform=efi BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config \
HOST_CC=x86_64-linux-gnu-gcc HOST_CFLAGS='-g -O2' \
PKG_CONFIG=x86_64-linux-gnu-pkg-config TARGET_CC=aarch64-linux-gnu-gcc \
TARGET_CFLAGS='-Os -march=armv8-a' TARGET_CCASFLAGS='-march=armv8-a' \
TARGET_OBJCOPY=aarch64-linux-gnu-objcopy \
TARGET_STRIP=aarch64-linux-gnu-strip TARGET_NM=aarch64-linux-gnu-nm \
TARGET_RANLIB=aarch64-linux-gnu-ranlib LEX=flex
Quoted 6 lines
Could we add a sentence here going (if switching to efi for the platform):
"Normally, for building a grub on amd64 with tools to run on amd64 to generate images to run on arm, using your Linux distribution's packaged cross compiler, the following would suffice:./configure --target=arm-linux-gnueabihf --with-platform=efi"
./configure --target=aarch64-linux-gnu --with-platform=efi
Quoted 4 lines
Quoted 4 lines
INSTALL +0
-0You need to use following options to specify tools and platforms. For minimum version look at prerequisites. All tools not mentioned in this section under@@ -182,28 +182,31 @@ corresponding platform are not needed for the platform in question.
Quoted 16 lines
INSTALL corresponding platform are not needed for the platform in question. · line 185
Quoted 12 lines
INSTALL +1
-9- For host 1. --host= to autoconf name of host. - 2. CC= for gcc able to compile for host - 3. HOST_CFLAGS= for C options for host. - 4. HOST_CPPFLAGS= for C preprocessor options for host. - 5. HOST_LDFLAGS= for linker options for host. - 6. PKG_CONFIG= for pkg-config for host (optional). - 7. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). - 8. Libfuse if any must be in standard linker folders (-lfuse) (optional). - 9. Libzfs if any must be in standard linker folders (-lzfs) (optional). - 10. Liblzma if any must be in standard linker folders (-llzma) (optional). + 2. CC= for gcc able to compile for host and target.But this is incorrect? Apart from where HOST == TARGET? And goes against the example updated above.
Am I missing something?
It is correct, CC applies for host and target...
Quoted 24 lines
Quoted 13 lines
INSTALL +9
-0+ 3. CFLAGS= for C options for host and target. + 4. HOST_CFLAGS= for C options for host. + 5. HOST_CPPFLAGS= for C preprocessor options for host. + 6. HOST_LDFLAGS= for linker options for host. + 7. PKG_CONFIG= for pkg-config for host (optional). + 8. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). + 9. Libfuse if any must be in standard linker folders (-lfuse) (optional). + 10. Libzfs if any must be in standard linker folders (-lzfs) (optional). + 11. Liblzma if any must be in standard linker folders (-llzma) (optional). - For target 1. --target= to autoconf cpu name of target. 2. --with-platform to choose firmware.INSTALL corresponding platform are not needed for the platform in question. · line 199
Quoted 10 lines
INSTALL +1
-9- 3. TARGET_CC= for gcc able to compile for target - 4. TARGET_CFLAGS= for C options for target. - 5. TARGET_CPPFLAGS= for C preprocessor options for target. - 6. TARGET_CCASFLAGS= for assembler options for target. - 7. TARGET_LDFLAGS= for linker options for target. - 8. TARGET_OBJCOPY= for objcopy for target. - 9. TARGET_STRIP= for strip for target. - 10. TARGET_NM= for nm for target. - 11. TARGET_RANLIB= for ranlib for target. + 3. CC= for gcc able to compile for host and target.
Quoted 1 line
Same again.
Ditto...
Quoted 20 lines
Quoted 20 lines
INSTALL +10
-0+ 4. CFLAGS= for C options for host and target. + 5. TARGET_CC= for gcc able to compile for target. + 6. TARGET_CFLAGS= for C options for target. + 7. TARGET_CPPFLAGS= for C preprocessor options for target. + 8. TARGET_CCASFLAGS= for assembler options for target. + 9. TARGET_LDFLAGS= for linker options for target. + 10. TARGET_OBJCOPY= for objcopy for target. + 11. TARGET_STRIP= for strip for target. + 12. TARGET_NM= for nm for target. + 13. TARGET_RANLIB= for ranlib for target. - Additionally for emu, for host and target. 1. SDL is looked for in standard linker directories (-lSDL) (optional)configure.ac +0
-0@@ -26,10 +26,12 @@ dnl This is necessary because the target type in autoconf does not dnl describe such a system very well. dnl
Quoted 8 lines
configure.ac dnl This is necessary because the target type in autoconf does not · line 29
Quoted 6 lines
configure.ac +1
-4dnl The current strategy is to use variables with no prefix (such as -dnl CC, CFLAGS, etc.) for the host type, variables with prefix "BUILD_" -dnl (such as BUILD_CC, BUILD_CFLAGS, etc.) for the build type and variables -dnl with the prefix "TARGET_" (such as TARGET_CC, TARGET_CFLAGS, etc.) are -dnl used for the target type. See INSTALL for full list of variables. +dnl CC, CFLAGS, etc.) for the host and target type, variables withSame again.
...and ditto...
Daniel
Re: [PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment
Quoted 49 lines · Daniel Kiper
Quoted 37 lines · Leif Lindholm
Quoted 20 lines · Daniel Kiper
..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
Signed-off-by Daniel Kiper <[email protected]>--- INSTALL | 51 +++++++++++++++++++++++++++------------------------ configure.ac | 10 ++++++---- 2 files changed, 33 insertions(+), 28 deletions(-)INSTALL +0
-2@@ -160,12 +160,12 @@ For this example the configure line might look like (more details below) (some options are optional and included here for completeness but some rarely used options are omitted): -./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu -CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-configINSTALL For this example the configure line might look like (more details below) · line 168
Quoted 10 lines
INSTALL +6
-4---target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc -TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" -TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" -TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflex +./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu \ + CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-config \ + --target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc \ + TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" \ + TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" \ + TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflexSo ... probably should have looked more properly at this round 1.
If we are updating this guidance, should we bring it up to date as well?
Quoted 8 lines
Now we have uefi support in u-boot, the "uboot" platform is the exception rather than the norm. It'd be better to specify --with-platform=efi.
Secondly, these appear to be flags used when
building GRUB for Raspberry Pi 1; -march-armv6 is quite outdated and could be dropped. (Although I guess it becomes more relevant when seen in combination withTARGET_CCASFLAGS.)What do you think about this:
Quoted 8 lines
./configure --host=x86_64-linux-gnu --target=aarch64-linux-gnu \
--with-platform=efi BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config \
HOST_CC=x86_64-linux-gnu-gcc HOST_CFLAGS='-g -O2' \
PKG_CONFIG=x86_64-linux-gnu-pkg-config TARGET_CC=aarch64-linux-gnu-gcc \
TARGET_CFLAGS='-Os -march=armv8-a' TARGET_CCASFLAGS='-march=armv8-a' \
TARGET_OBJCOPY=aarch64-linux-gnu-objcopy \
TARGET_STRIP=aarch64-linux-gnu-strip TARGET_NM=aarch64-linux-gnu-nm \
TARGET_RANLIB=aarch64-linux-gnu-ranlib LEX=flex
I mean, it's less dated, but it also makes less sense than the original - an aarch64-linux-gnu-gcc toolchain is very highly likely to default to -march=armv8-a. It would make more sense to specify something like -march=armv8.4a.
Quoted 8 lines
Quoted 6 lines
Could we add a sentence here going (if switching to efi for the platform):
"Normally, for building a grub on amd64 with tools to run on amd64 to generate images to run on arm, using your Linux distribution's packaged cross compiler, the following would suffice:./configure --target=arm-linux-gnueabihf --with-platform=efi"
./configure --target=aarch64-linux-gnu --with-platform=efi
Again, the original actually made more sense - arm64 only supports efi.
Quoted 21 lines
Quoted 4 lines
Quoted 4 lines
INSTALL +0
-0You need to use following options to specify tools and platforms. For minimum version look at prerequisites. All tools not mentioned in this section under@@ -182,28 +182,31 @@ corresponding platform are not needed for the platform in question.Quoted 16 lines
INSTALL corresponding platform are not needed for the platform in question. · line 185
Quoted 12 lines
INSTALL +1
-9- For host 1. --host= to autoconf name of host. - 2. CC= for gcc able to compile for host - 3. HOST_CFLAGS= for C options for host. - 4. HOST_CPPFLAGS= for C preprocessor options for host. - 5. HOST_LDFLAGS= for linker options for host. - 6. PKG_CONFIG= for pkg-config for host (optional). - 7. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). - 8. Libfuse if any must be in standard linker folders (-lfuse) (optional). - 9. Libzfs if any must be in standard linker folders (-lzfs) (optional). - 10. Liblzma if any must be in standard linker folders (-llzma) (optional). + 2. CC= for gcc able to compile for host and target.But this is incorrect? Apart from where HOST == TARGET? And goes against the example updated above.
Am I missing something?
Quoted 1 line
It is correct, CC applies for host and target...
So why do we have TARGET_CC and HOST_CC?
My understanding is:
- CC sets the default compilet binary, used for BUILD, HOST and TARGET unless overridden for each of these.
- The value of BUILD_CC is used as default for HOST_CC unless HOST_CC is explicitly specified.
- The value of HOST_CC is used as the default for TARGET_CC, where *it* is not explicitly specified.
Either my understanding here is incorrect, or these changes make the text more rather than less misleading.
/
Leif
Quoted 60 lines
Quoted 24 lines
Quoted 13 lines
INSTALL +9
-0+ 3. CFLAGS= for C options for host and target. + 4. HOST_CFLAGS= for C options for host. + 5. HOST_CPPFLAGS= for C preprocessor options for host. + 6. HOST_LDFLAGS= for linker options for host. + 7. PKG_CONFIG= for pkg-config for host (optional). + 8. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). + 9. Libfuse if any must be in standard linker folders (-lfuse) (optional). + 10. Libzfs if any must be in standard linker folders (-lzfs) (optional). + 11. Liblzma if any must be in standard linker folders (-llzma) (optional). - For target 1. --target= to autoconf cpu name of target. 2. --with-platform to choose firmware.INSTALL corresponding platform are not needed for the platform in question. · line 199
Quoted 10 lines
INSTALL +1
-9- 3. TARGET_CC= for gcc able to compile for target - 4. TARGET_CFLAGS= for C options for target. - 5. TARGET_CPPFLAGS= for C preprocessor options for target. - 6. TARGET_CCASFLAGS= for assembler options for target. - 7. TARGET_LDFLAGS= for linker options for target. - 8. TARGET_OBJCOPY= for objcopy for target. - 9. TARGET_STRIP= for strip for target. - 10. TARGET_NM= for nm for target. - 11. TARGET_RANLIB= for ranlib for target. + 3. CC= for gcc able to compile for host and target.Quoted 1 line
Same again.
Ditto...
Quoted 20 lines
Quoted 20 lines
INSTALL +10
-0+ 4. CFLAGS= for C options for host and target. + 5. TARGET_CC= for gcc able to compile for target. + 6. TARGET_CFLAGS= for C options for target. + 7. TARGET_CPPFLAGS= for C preprocessor options for target. + 8. TARGET_CCASFLAGS= for assembler options for target. + 9. TARGET_LDFLAGS= for linker options for target. + 10. TARGET_OBJCOPY= for objcopy for target. + 11. TARGET_STRIP= for strip for target. + 12. TARGET_NM= for nm for target. + 13. TARGET_RANLIB= for ranlib for target. - Additionally for emu, for host and target. 1. SDL is looked for in standard linker directories (-lSDL) (optional)configure.ac +0
-0@@ -26,10 +26,12 @@ dnl This is necessary because the target type in autoconf does not dnl describe such a system very well. dnlQuoted 8 lines
configure.ac dnl This is necessary because the target type in autoconf does not · line 29
Quoted 6 lines
configure.ac +1
-4dnl The current strategy is to use variables with no prefix (such as -dnl CC, CFLAGS, etc.) for the host type, variables with prefix "BUILD_" -dnl (such as BUILD_CC, BUILD_CFLAGS, etc.) for the build type and variables -dnl with the prefix "TARGET_" (such as TARGET_CC, TARGET_CFLAGS, etc.) are -dnl used for the target type. See INSTALL for full list of variables. +dnl CC, CFLAGS, etc.) for the host and target type, variables withSame again.
...and ditto...
Daniel
Re: [PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment
Quoted 59 lines · Leif Lindholm
Quoted 49 lines · Daniel Kiper
Quoted 37 lines · Leif Lindholm
Quoted 20 lines · Daniel Kiper
..to reflect the GRUB build reality in them.
Additionally, fix ./configure command example formatting in INSTALL file.
Signed-off-by Daniel Kiper <[email protected]>--- INSTALL | 51 +++++++++++++++++++++++++++------------------------ configure.ac | 10 ++++++---- 2 files changed, 33 insertions(+), 28 deletions(-)INSTALL +0
-2@@ -160,12 +160,12 @@ For this example the configure line might look like (more details below) (some options are optional and included here for completeness but some rarely used options are omitted): -./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu -CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-configINSTALL For this example the configure line might look like (more details below) · line 168
Quoted 10 lines
INSTALL +6
-4---target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc -TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" -TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" -TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflex +./configure BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config --host=amd64-linux-gnu \ + CC=amd64-linux-gnu-gcc CFLAGS="-g -O2" PKG_CONFIG=amd64-linux-gnu-pkg-config \ + --target=arm --with-platform=uboot TARGET_CC=arm-elf-gcc \ + TARGET_CFLAGS="-Os -march=armv6" TARGET_CCASFLAGS="-march=armv6" \ + TARGET_OBJCOPY="arm-elf-objcopy" TARGET_STRIP="arm-elf-strip" \ + TARGET_NM=arm-elf-nm TARGET_RANLIB=arm-elf-ranlib LEX=gflexSo ... probably should have looked more properly at this round 1.
If we are updating this guidance, should we bring it up to date as well?
Quoted 8 lines
Now we have uefi support in u-boot, the "uboot" platform is the exception rather than the norm. It'd be better to specify --with-platform=efi.
Secondly, these appear to be flags used when
building GRUB for Raspberry Pi 1; -march-armv6 is quite outdated and could be dropped. (Although I guess it becomes more relevant when seen in combination withTARGET_CCASFLAGS.)What do you think about this:
Quoted 8 lines
./configure --host=x86_64-linux-gnu --target=aarch64-linux-gnu \
--with-platform=efi BUILD_CC=gcc BUILD_PKG_CONFIG=pkg-config \
HOST_CC=x86_64-linux-gnu-gcc HOST_CFLAGS='-g -O2' \
PKG_CONFIG=x86_64-linux-gnu-pkg-config TARGET_CC=aarch64-linux-gnu-gcc \
TARGET_CFLAGS='-Os -march=armv8-a' TARGET_CCASFLAGS='-march=armv8-a' \
TARGET_OBJCOPY=aarch64-linux-gnu-objcopy \
TARGET_STRIP=aarch64-linux-gnu-strip TARGET_NM=aarch64-linux-gnu-nm \
TARGET_RANLIB=aarch64-linux-gnu-ranlib LEX=flex
Quoted 4 lines
I mean, it's less dated, but it also makes less sense than the original - an aarch64-linux-gnu-gcc toolchain is very highly likely to default to -march=armv8-a. It would make more sense to specify something like -march=armv8.4a.
OK, so, I will change -march to armv8.4a.
Quoted 10 lines
Quoted 8 lines
Quoted 6 lines
Could we add a sentence here going (if switching to efi for the platform):
"Normally, for building a grub on amd64 with tools to run on amd64 to generate images to run on arm, using your Linux distribution's packaged cross compiler, the following would suffice:./configure --target=arm-linux-gnueabihf --with-platform=efi"
./configure --target=aarch64-linux-gnu --with-platform=efi
Again, the original actually made more sense - arm64 only supports efi.
Yeah, so, let's stick with currently existing example.
Quoted 21 lines
Quoted 21 lines
Quoted 20 lines
Quoted 6 lines
INSTALL +0
-0You need to use following options to specify tools and platforms. For minimum version look at prerequisites. All tools not mentioned in this section under@@ -182,28 +182,31 @@ corresponding platform are not needed for the platform in question. - For host 1. --host= to autoconf name of host.INSTALL corresponding platform are not needed for the platform in question. · line 185
Quoted 10 lines
INSTALL +1
-9- 2. CC= for gcc able to compile for host - 3. HOST_CFLAGS= for C options for host. - 4. HOST_CPPFLAGS= for C preprocessor options for host. - 5. HOST_LDFLAGS= for linker options for host. - 6. PKG_CONFIG= for pkg-config for host (optional). - 7. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). - 8. Libfuse if any must be in standard linker folders (-lfuse) (optional). - 9. Libzfs if any must be in standard linker folders (-lzfs) (optional). - 10. Liblzma if any must be in standard linker folders (-llzma) (optional). + 2. CC= for gcc able to compile for host and target.But this is incorrect? Apart from where HOST == TARGET? And goes against the example updated above.
Am I missing something?
Quoted 7 lines
Quoted 1 line
It is correct, CC applies for host and target...
So why do we have
TARGET_CCandHOST_CC?My understanding is:
- CC sets the default compilet binary, used for BUILD, HOST and TARGET unless overridden for each of these.
Nope, just HOST_CC and TARGET_CC. You can override CC using TARGET_CC and HOST_CC respectively. Order in configure command line does not matter.
Quoted 2 lines
- The value of
BUILD_CCis used as default forHOST_CCunlessHOST_CCis explicitly specified.
Nope, it is not.
Quoted 2 lines
- The value of
HOST_CCis used as the default forTARGET_CC, where *it* is not explicitly specified.
Nope, it is not.
Quoted 2 lines
Either my understanding here is incorrect, or these changes make the text more rather than less misleading.
Sorry but I am not sure what is unclear after my changes.
Daniel
Re: [PATCH v2 3/4] INSTALL/configure: Update install doc and configure comment
Quoted 23 lines · Daniel Kiper
Quoted 23 lines
Quoted 22 lines
Quoted 4 lines
Quoted 4 lines
You need to use following options to specify tools and platforms. For minimum version look at prerequisites. All tools not mentioned in this section under
(quoted diff) +0
-0@@ -182,28 +182,31 @@ corresponding platform are not needed for the platform in question.Quoted 16 lines
INSTALL corresponding platform are not needed for the platform in question. · line 185
Quoted 12 lines
INSTALL +1
-9- For host 1. --host= to autoconf name of host. - 2. CC= for gcc able to compile for host - 3. HOST_CFLAGS= for C options for host. - 4. HOST_CPPFLAGS= for C preprocessor options for host. - 5. HOST_LDFLAGS= for linker options for host. - 6. PKG_CONFIG= for pkg-config for host (optional). - 7. Libdevmapper if any must be in standard linker folders (-ldevmapper) (optional). - 8. Libfuse if any must be in standard linker folders (-lfuse) (optional). - 9. Libzfs if any must be in standard linker folders (-lzfs) (optional). - 10. Liblzma if any must be in standard linker folders (-llzma) (optional). + 2. CC= for gcc able to compile for host and target.But this is incorrect? Apart from where HOST == TARGET? And goes against the example updated above.
Am I missing something?It is correct, CC applies for host and target...
Quoted 8 lines
Quoted 5 lines
So why do we have
TARGET_CCandHOST_CC?My understanding is:
- CC sets the default compilet binary, used for BUILD, HOST and TARGET unless overridden for each of these.Nope, just
HOST_CCandTARGET_CC. You can override CC usingTARGET_CCandHOST_CCrespectively. Order in configure command line does not matter.
I wasn't suggesting command line order mattered.
Quoted 8 lines
Quoted 2 lines
- The value of
BUILD_CCis used as default forHOST_CCunlessHOST_CCis explicitly specified.Nope, it is not.
Quoted 2 lines
- The value of
HOST_CCis used as the default forTARGET_CC, where *it* is not explicitly specified.
Quoted 6 lines
Nope, it is not.
Quoted 2 lines
Either my understanding here is incorrect, or these changes make the text more rather than less misleading.
Sorry but I am not sure what is unclear after my changes.
OK, I concede configure.ac completely ignores the value of CC for setting BUILD_CC. It tests for a hard-wired set of commands (which seems weird to me, but some googling suggests that is indeed default behaviour - I guess overriding the BUILD_ toolchain is the *least* common use case).
But let me rewind:
configure scripts support separate concepts of BUILD, HOST and TARGET to permit things like cross-compiling a tool on an AMD64 box (BUILD) to run on an armhf box (HOST) to generate images to run on SPARC (TARGET).
CC is traditionally used to override just using the first "gcc" command to find a (apparently HOST_) toolchain.
But if I set both HOST_ and TARGET_ options for my build, I expect the target to be built using the TARGET_ toolchain. If I specify CC and TARGET_CC, I expect the target to be built with TARGET_CC. Which is thankfully also what happens in reality.
However, the proposed change now says that HOST_CC sets the host and target compiler and that TARGET_CC sets the target compiler. This is not even self-consistent.
I get what the change is trying to say, but I feel it is only adding confusion. I think the same thing could be adequately conveyed by adding something along the lines of:
"If no target options are given, these will default to be the same as the host options."
immediately below the - "For target" line
I don't think adding description of CC/CFLAGS to target section improves clarity. If CFLAGS should be separately speficied, I think that makes more sense next to HOST_CFLAGS.
And I think if we're changing this, we should add an entry for HOST_CC
- or add that to the existing CC option.
Regards,
Leif