nvdimm-utils: clean up headers and add license comment
PATCH v2 1/1 nvdimm-utils: clean up headers and add license comment
Fixes 3f350f6bb36233be50fc2bc18dc78b6a948a5dbe
Reported-by Peter Maydell <[email protected]>
Signed-off-by Igor Mammedov <[email protected]>
---
v2:
- add license blob to header as well
- trim comment a litle bit to remove unrelated NFIT/PMEM sentences
--- include/qemu/nvdimm-utils.h | 23 +++++++++++++++++++++-- util/nvdimm-utils.c | 23 +++++++++++++++++++++++ 2 files changed, 44 insertions(+), 2 deletions(-)
include/qemu/nvdimm-utils.h +21 -2
@@ -1,7 +1,26 @@#ifndef NVDIMM_UTILS_H #define NVDIMM_UTILS_H - -#include "qemu/osdep.h" +/* +* NVDIMM utilities +* +* Copyright(C) 2015 Intel Corporation. +* +* Author: +* Xiao Guangrong <[email protected]> +* +* This library is free software; you can redistribute it and/or +* modify it under the terms of the GNU Lesser General Public +* License as published by the Free Software Foundation; either +* version 2 of the License, or (at your option) any later version. +* +* This library is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this library; if not, see <http://www.gnu.org/licenses/> +*/ GSList *nvdimm_get_device_list (void );#endif
util/nvdimm-utils.c +23 -0
@@ -1,3 +1,26 @@ +/* +* NVDIMM utilities +* +* Copyright(C) 2015 Intel Corporation. +* +* Author: +* Xiao Guangrong <[email protected]> +* +* This library is free software; you can redistribute it and/or +* modify it under the terms of the GNU Lesser General Public +* License as published by the Free Software Foundation; either +* version 2 of the License, or (at your option) any later version. +* +* This library is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this library; if not, see <http://www.gnu.org/licenses/> +*/ + +#include "qemu/osdep.h" #include "qemu/nvdimm-utils.h" #include "hw/mem/nvdimm.h"
Signature · 1 line
2.18.1
Hi Igor,
Quoted 17 lines · Igor Mammedov
Fixes 3f350f6bb36233be50fc2bc18dc78b6a948a5dbeReported-by Peter Maydell <[email protected]>Signed-off-by Igor Mammedov <[email protected]>---
v2:
- add license blob to header as well
- trim comment a litle bit to remove unrelated NFIT/PMEM sentences--- include/qemu/nvdimm-utils.h | 23 +++++++++++++++++++++-- util/nvdimm-utils.c | 23 +++++++++++++++++++++++ 2 files changed, 44 insertions(+), 2 deletions(-)include/qemu/nvdimm-utils.h +0
-0
include/qemu/nvdimm-utils.h line 2
Quoted 2 lines
include/qemu/nvdimm-utils.h +0
-0@@ -1,7 +1,26 @@#ifndef NVDIMM_UTILS_H #define NVDIMM_UTILS_H
I think most of the files in the tree use the pattern "license comment before the ifdef guard", but I won't write a script to prove me right/wrong :)
Quoted 13 lines
include/qemu/nvdimm-utils.h +11
-2- -#include "qemu/osdep.h" +/* +* NVDIMM utilities +* +* Copyright(C) 2015 Intel Corporation. +* +* Author: +* Xiao Guangrong <[email protected]> +* +* This library is free software; you can redistribute it and/or +* modify it under the terms of the GNU Lesser General Public +* License as published by the Free Software Foundation; either
include/qemu/nvdimm-utils.h line 23
Quoted 10 lines
include/qemu/nvdimm-utils.h +10
-0+* version 2 of the License, or (at your option) any later version. +* +* This library is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this library; if not, see <http://www.gnu.org/licenses/> +*/
So here goes the ifdef:
#ifndef NVDIMM_UTILS_H
#define NVDIMM_UTILS_HQuoted 35 lines
include/qemu/nvdimm-utils.h +0
-0GSList *nvdimm_get_device_list (void );#endif util/nvdimm-utils.c +23
-0@@ -1,3 +1,26 @@ +/* +* NVDIMM utilities +* +* Copyright(C) 2015 Intel Corporation. +* +* Author: +* Xiao Guangrong <[email protected]> +* +* This library is free software; you can redistribute it and/or +* modify it under the terms of the GNU Lesser General Public +* License as published by the Free Software Foundation; either +* version 2 of the License, or (at your option) any later version. +* +* This library is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +* Lesser General Public License for more details. +* +* You should have received a copy of the GNU Lesser General Public +* License along with this library; if not, see <http://www.gnu.org/licenses/> +*/ + +#include "qemu/osdep.h" #include "qemu/nvdimm-utils.h" #include "hw/mem/nvdimm.h"