drm/i915/display: Enable DP Display Audio WA
Subsystems (3)
PATCH 1/1 drm/i915/display: Enable DP Display Audio WA
Enable Display Audio WA #1406928334 for 4k+VDSC usecase on DP encoders.
--- drivers/gpu/drm/i915/display/intel_audio.c | 110 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 16 +++ 2 files changed, 126 insertions(+)
drivers/gpu/drm/i915/display/intel_audio.c +110 -0
@@ -512,6 +512,112 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,mutex_unlock (&dev_priv->av_mutex); } +static void enable_audio_dsc_wa (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state) +{ +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev); +struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe; +u64 link_clks_available, link_clks_required, link_clk; +u64 tu_data, tu_line, link_clks_active; +u64 hblank_rise, hblank_early_prog, samples_room; +u64 h_active, h_total, hblank_delta, pixel_clk, v_total, lanes; +u64 vdsc_bpp, fec_coeff, refresh_rate, cdclk; +u64 rounding_factor =100000 ; +u32 val; + + val =intel_de_read (dev_priv,AUD_CONFIG_BE ); + +if (INTEL_GEN (dev_priv) ==11 ) + val |=HBLANK_EARLY_ENABLE_ICL (pipe); +else if (INTEL_GEN (dev_priv) >=12 ) + val |=HBLANK_EARLY_ENABLE_TGL (pipe); + +if (crtc_state->dsc.compression_enable && + (crtc_state->hw.adjusted_mode.hdisplay >=3840 && + crtc_state->hw.adjusted_mode.vdisplay >=2160 )) { + h_active = crtc_state->hw.adjusted_mode.hdisplay; + h_total = crtc_state->hw.adjusted_mode.htotal; + v_total = crtc_state->hw.adjusted_mode.vtotal; + hblank_rise = crtc_state->hw.adjusted_mode.hsync_start; + pixel_clk = crtc_state->hw.adjusted_mode.clock; + link_clk = crtc_state->port_clock; + lanes = crtc_state->lane_count; + vdsc_bpp = crtc_state->pipe_bpp; + refresh_rate = crtc_state->hw.adjusted_mode.vrefresh; + cdclk = dev_priv->cdclk.hw.cdclk; +/* fec= 0.972261, using rounding multiplier of 1000000 */ + fec_coeff =972261 ; + +if (!(h_active && link_clk && lanes && vdsc_bpp && cdclk)) { +drm_err (&dev_priv->drm,"Null Parameters received\n" ); +return ; + } + +drm_dbg_kms (&dev_priv->drm,"h_active = %llu link_clk = %llu :" +"lanes = %llu vdsc_bpp = %llu cdclk = %llu\n" , + h_active, link_clk, lanes, vdsc_bpp, cdclk); + + link_clks_available = ((((h_total - h_active) * + ((link_clk * rounding_factor) / + pixel_clk)) / rounding_factor) -28 ); + + link_clks_required =DIV_ROUND_UP (192000 , (refresh_rate * + v_total)) * + ((48 / lanes) +2 ); + +if (link_clks_available > link_clks_required) + hblank_delta =32 ; +else + hblank_delta =DIV_ROUND_UP (((((5 * rounding_factor) / + link_clk) + ((5 * + rounding_factor) / cdclk)) * + pixel_clk), rounding_factor); + + tu_data = (pixel_clk * vdsc_bpp *8 ) / ((link_clk * + lanes * fec_coeff) / +1000000 ); + tu_line = (((h_active * link_clk * fec_coeff) /1000000 ) / + (64 * pixel_clk)); + link_clks_active = (tu_line -1 ) *64 + tu_data; + hblank_rise = ((link_clks_active +6 * +DIV_ROUND_UP (link_clks_active,250 ) +4 ) * + ((pixel_clk * rounding_factor) / + link_clk)) / rounding_factor; + + hblank_early_prog = h_active - hblank_rise + hblank_delta; + +if (hblank_early_prog <32 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=HBLANK_START_COUNT (HBLANK_START_COUNT_32 , pipe); + }else if (hblank_early_prog <64 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=HBLANK_START_COUNT (HBLANK_START_COUNT_64 , pipe); + }else if (hblank_early_prog <96 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=HBLANK_START_COUNT (HBLANK_START_COUNT_96 , pipe); + }else { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=HBLANK_START_COUNT (HBLANK_START_COUNT_128 , pipe); + } + + samples_room = ((((h_total - h_active) * + ((link_clk * rounding_factor) / + pixel_clk)) / rounding_factor) -12 ) / + ((48 / lanes) +2 ); + +if (samples_room <3 ) { + val &= ~NUMBER_SAMPLES_PER_LINE_MASK (pipe); + val |=NUMBER_SAMPLES_PER_LINE (samples_room, pipe); + }else { + val &= ~NUMBER_SAMPLES_PER_LINE_MASK (pipe); + val |=NUMBER_SAMPLES_PER_LINE (0x0 , pipe); + } + } + +intel_de_write (dev_priv,AUD_CONFIG_BE , val); +} +static void hsw_audio_codec_enable (struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state,const struct drm_connector_state *conn_state)
@@ -529,6 +635,10 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,mutex_lock (&dev_priv->av_mutex); +/* Enable Audio WA for 4k DSC usecases */ +if (encoder->type ==INTEL_OUTPUT_DP ) +enable_audio_dsc_wa (encoder, crtc_state); +/* Enable audio presence detect, invalidate ELD */ tmp =intel_de_read (dev_priv,HSW_AUD_PIN_ELD_CP_VLD ); tmp |=AUDIO_OUTPUT_ENABLE (cpu_transcoder);
drivers/gpu/drm/i915/i915_reg.h +16 -0
@@ -9395,6 +9395,22 @@ enum {#define AUD_PIN_BUF_CTL _MMIO(0x48414)#define AUD_PIN_BUF_ENABLE REG_BIT(31) +/* Display Audio Config Reg */ +#define AUD_CONFIG_BE _MMIO(0x65ef0) +#define HBLANK_EARLY_ENABLE_ICL (pipe) (0x1 << (20 - (pipe))) +#define HBLANK_EARLY_ENABLE_TGL (pipe) (0x1 << (24 + (pipe))) +#define HBLANK_START_COUNT_MASK (pipe) (0x7 << (3 + ((pipe) * 6))) +#define HBLANK_START_COUNT (val, pipe) (((val) & 0x7) << (3 + ((pipe)) * 6)) +#define NUMBER_SAMPLES_PER_LINE_MASK (pipe) (0x3 << ((pipe) * 6)) +#define NUMBER_SAMPLES_PER_LINE (val, pipe) (((val) & 0x3) << ((pipe) * 6)) + +#define HBLANK_START_COUNT_8 0x0 +#define HBLANK_START_COUNT_16 0x1 +#define HBLANK_START_COUNT_32 0x2 +#define HBLANK_START_COUNT_64 0x3 +#define HBLANK_START_COUNT_96 0x4 +#define HBLANK_START_COUNT_128 0x5 +/* * HSW - ICL power wells *
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Enable DP Display Audio WA
== Series Details ==
== Series Details ==
Series: drm/i915/display: Enable DP Display Audio WA
URL : https://patchwork.freedesktop.org/series/75582/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8264 -> Patchwork_17227
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/index.html
Known issues
------------
Here are the changes found in Patchwork_17227 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [FAIL][1] ([i915#1158]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-tgl-y/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/fi-tgl-y/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- fi-icl-y: [INCOMPLETE][3] ([i915#1580]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/fi-icl-y/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/fi-icl-y/igt@i915_selftest@[email protected]
[i915#1158]: https://gitlab.freedesktop.org/drm/intel/issues/1158
[i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580
Participating hosts (53 -> 47)
------------------------------
Additional (1): fi-kbl-7560u
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8264 -> Patchwork_17227
CI-20190529: 20190529
CI_DRM_8264: e0104585f880a64d4a9b40803cf4fb51ab499f7c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5573: 9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17227: 4b7c7a1dc51c77c7d32c5b48f44b5a9ab37a8565 @ git://anongit.freedesktop.org/gfx-ci/linux
== Kernel 32bit build ==
Warning: Kernel 32bit buildtest failed:
https://intel-gfx-ci.01.org/Patchwork_17227/build_32bit.log
CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
MODPOST 121 modules
ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/i915/i915.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1283: recipe for target 'modules' failed
make: *** [modules] Error 2
== Linux commits ==
4b7c7a1dc51c drm/i915/display: Enable DP Display Audio WA
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BUILD: warning for drm/i915/display: Enable DP Display Audio WA
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: drm/i915/display: Enable DP Display Audio WA
URL : https://patchwork.freedesktop.org/series/75582/
State : warning
== Summary ==
CALL scripts/checksyscalls.sh
CALL scripts/atomic/check-atomics.sh
CHK include/generated/compile.h
Kernel: arch/x86/boot/bzImage is ready (#1)
MODPOST 121 modules
ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!
ERROR: "__divdi3" [drivers/gpu/drm/i915/i915.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1
Makefile:1283: recipe for target 'modules' failed
make: *** [modules] Error 2
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/build_32bit.log
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 2 lines · Uma Shankar
Enable Display Audio WA #1406928334 for 4k+VDSC usecase on DP encoders.
I didn't actually read the wa, but please describe the main points here.
Quoted 12 lines
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_audio.c | 110 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 16 +++ 2 files changed, 126 insertions(+)drivers/gpu/drm/i915/display/intel_audio.c +0
-0
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 518
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_audio.c +4
-0@@ -512,6 +512,112 @@ static void hsw_audio_codec_disable(struct intel_encoder *encoder,mutex_unlock (&dev_priv->av_mutex); } +static void enable_audio_dsc_wa (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state) +{ +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);
Please name the variable i915 now that we can.
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 525
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_audio.c +7
-0+struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe; +u64 link_clks_available, link_clks_required, link_clk; +u64 tu_data, tu_line, link_clks_active; +u64 hblank_rise, hblank_early_prog, samples_room; +u64 h_active, h_total, hblank_delta, pixel_clk, v_total, lanes; +u64 vdsc_bpp, fec_coeff, refresh_rate, cdclk;
Most of these probably don't need to be u64.
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 526
Quoted 1 line
drivers/gpu/drm/i915/display/intel_audio.c +1
-0+u64 rounding_factor =100000 ;
Macro.
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 535
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_audio.c +9
-0+u32 val; + + val =intel_de_read (dev_priv,AUD_CONFIG_BE ); + +if (INTEL_GEN (dev_priv) ==11 ) + val |=HBLANK_EARLY_ENABLE_ICL (pipe); +else if (INTEL_GEN (dev_priv) >=12 ) + val |=HBLANK_EARLY_ENABLE_TGL (pipe); +
So if it's gen < 11 without dsc, you'll just read and write the register? Probably want to bail out early.
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_audio.c +8
-0+if (crtc_state->dsc.compression_enable && + (crtc_state->hw.adjusted_mode.hdisplay >=3840 && + crtc_state->hw.adjusted_mode.vdisplay >=2160 )) { + h_active = crtc_state->hw.adjusted_mode.hdisplay; + h_total = crtc_state->hw.adjusted_mode.htotal; + v_total = crtc_state->hw.adjusted_mode.vtotal; + hblank_rise = crtc_state->hw.adjusted_mode.hsync_start; + pixel_clk = crtc_state->hw.adjusted_mode.clock;
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 553
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_audio.c +10
-0+ link_clk = crtc_state->port_clock; + lanes = crtc_state->lane_count; + vdsc_bpp = crtc_state->pipe_bpp; + refresh_rate = crtc_state->hw.adjusted_mode.vrefresh; + cdclk = dev_priv->cdclk.hw.cdclk; +/* fec= 0.972261, using rounding multiplier of 1000000 */ + fec_coeff =972261 ; + +if (!(h_active && link_clk && lanes && vdsc_bpp && cdclk)) { +drm_err (&dev_priv->drm,"Null Parameters received\n" );
What's the user going to do with that information?
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 554
Quoted 1 line
drivers/gpu/drm/i915/display/intel_audio.c +1
-0+return ;
No need to write HBLANK_EARLY_ENABLE_* then?
Quoted 43 lines
drivers/gpu/drm/i915/display/intel_audio.c +43
-0+ } + +drm_dbg_kms (&dev_priv->drm,"h_active = %llu link_clk = %llu :" +"lanes = %llu vdsc_bpp = %llu cdclk = %llu\n" , + h_active, link_clk, lanes, vdsc_bpp, cdclk); + + link_clks_available = ((((h_total - h_active) * + ((link_clk * rounding_factor) / + pixel_clk)) / rounding_factor) -28 ); + + link_clks_required =DIV_ROUND_UP (192000 , (refresh_rate * + v_total)) * + ((48 / lanes) +2 ); + +if (link_clks_available > link_clks_required) + hblank_delta =32 ; +else + hblank_delta =DIV_ROUND_UP (((((5 * rounding_factor) / + link_clk) + ((5 * + rounding_factor) / cdclk)) * + pixel_clk), rounding_factor); + + tu_data = (pixel_clk * vdsc_bpp *8 ) / ((link_clk * + lanes * fec_coeff) / +1000000 ); + tu_line = (((h_active * link_clk * fec_coeff) /1000000 ) / + (64 * pixel_clk)); + link_clks_active = (tu_line -1 ) *64 + tu_data; + hblank_rise = ((link_clks_active +6 * +DIV_ROUND_UP (link_clks_active,250 ) +4 ) * + ((pixel_clk * rounding_factor) / + link_clk)) / rounding_factor; + + hblank_early_prog = h_active - hblank_rise + hblank_delta; + +if (hblank_early_prog <32 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=HBLANK_START_COUNT (HBLANK_START_COUNT_32 , pipe); + }else if (hblank_early_prog <64 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=HBLANK_START_COUNT (HBLANK_START_COUNT_64 , pipe); + }else if (hblank_early_prog <96 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe);
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 607
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_audio.c +10
-0+ val |=HBLANK_START_COUNT (HBLANK_START_COUNT_96 , pipe); + }else { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=HBLANK_START_COUNT (HBLANK_START_COUNT_128 , pipe); + } + + samples_room = ((((h_total - h_active) * + ((link_clk * rounding_factor) / + pixel_clk)) / rounding_factor) -12 ) / + ((48 / lanes) +2 );
Please abstract the calculation of hblank_early_prog and samples_room to separate helpers, and pass in crtc_state. You also don't have to make everything you need from crtc_state a local variable.
Quoted 32 lines
drivers/gpu/drm/i915/display/intel_audio.c +17
-0+ +if (samples_room <3 ) { + val &= ~NUMBER_SAMPLES_PER_LINE_MASK (pipe); + val |=NUMBER_SAMPLES_PER_LINE (samples_room, pipe); + }else { + val &= ~NUMBER_SAMPLES_PER_LINE_MASK (pipe); + val |=NUMBER_SAMPLES_PER_LINE (0x0 , pipe); + } + } + +intel_de_write (dev_priv,AUD_CONFIG_BE , val); +} +static void hsw_audio_codec_enable (struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state,const struct drm_connector_state *conn_state)@@ -529,6 +635,10 @@ static void hsw_audio_codec_enable(struct intel_encoder *encoder,mutex_lock (&dev_priv->av_mutex); +/* Enable Audio WA for 4k DSC usecases */ +if (encoder->type ==INTEL_OUTPUT_DP ) +enable_audio_dsc_wa (encoder, crtc_state); +/* Enable audio presence detect, invalidate ELD */ tmp =intel_de_read (dev_priv,HSW_AUD_PIN_ELD_CP_VLD ); tmp |=AUDIO_OUTPUT_ENABLE (cpu_transcoder);drivers/gpu/drm/i915/i915_reg.h +0
-0
drivers/gpu/drm/i915/i915_reg.h enum { · line 9403
Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -9395,6 +9395,22 @@ enum {#define AUD_PIN_BUF_CTL _MMIO(0x48414)#define AUD_PIN_BUF_ENABLE REG_BIT(31) +/* Display Audio Config Reg */ +#define AUD_CONFIG_BE _MMIO(0x65ef0) +#define HBLANK_EARLY_ENABLE_ICL (pipe) (0x1 << (20 - (pipe))) +#define HBLANK_EARLY_ENABLE_TGL (pipe) (0x1 << (24 + (pipe))) +#define HBLANK_START_COUNT_MASK (pipe) (0x7 << (3 + ((pipe) * 6))) +#define HBLANK_START_COUNT (val, pipe) (((val) & 0x7) << (3 + ((pipe)) * 6))
I'd swap pipe and val params around. Same below.
You might find REG_FIELD_PREP etc. useful.
drivers/gpu/drm/i915/i915_reg.h enum { · line 9412
Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h +9
-0+#define NUMBER_SAMPLES_PER_LINE_MASK (pipe) (0x3 << ((pipe) * 6)) +#define NUMBER_SAMPLES_PER_LINE (val, pipe) (((val) & 0x3) << ((pipe) * 6)) + +#define HBLANK_START_COUNT_8 0x0 +#define HBLANK_START_COUNT_16 0x1 +#define HBLANK_START_COUNT_32 0x2 +#define HBLANK_START_COUNT_64 0x3 +#define HBLANK_START_COUNT_96 0x4 +#define HBLANK_START_COUNT_128 0x5
They're just numbers, hex doesn't provide anything useful here.
Quoted 4 lines
drivers/gpu/drm/i915/i915_reg.h +1
-0+/* * HSW - ICL power wells *
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines
-----Original Message-----
From: Jani Nikula <[email protected]>
Sent: Tuesday, April 7, 2020 4:45 PM
To: Shankar, Uma <[email protected]>; [email protected]
Cc: Vehmanen, Kai <[email protected]>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Enable DP Display Audio WA
Quoted 5 lines
Quoted 2 lines · Uma Shankar
Enable Display Audio WA #1406928334 for 4k+VDSC usecase on DP encoders.
I didn't actually read the wa, but please describe the main points here.
Sure will add more details.
Quoted 14 lines
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct
Quoted 13 lines
Signed-off-by Uma Shankar <[email protected]>--- drivers/gpu/drm/i915/display/intel_audio.c | 110 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 16 +++ 2 files changed, 126 insertions(+)drivers/gpu/drm/i915/display/intel_audio.c +0
-0@@ -512,6 +512,112 @@ static void hsw_audio_codec_disable(struct
intel_encoder*encoder,
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 518
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_audio.c +3
-0mutex_unlock (&dev_priv->av_mutex); } +static void enable_audio_dsc_wa (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state) { +struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);Please name the variable i915 now that we can.
Ok.
Quoted 9 lines
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 525
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_audio.c +7
-0+struct intel_crtc *crtc =to_intel_crtc (crtc_state->uapi.crtc); +enum pipe pipe = crtc->pipe; +u64 link_clks_available, link_clks_required, link_clk; +u64 tu_data, tu_line, link_clks_active; +u64 hblank_rise, hblank_early_prog, samples_room; +u64 h_active, h_total, hblank_delta, pixel_clk, v_total, lanes; +u64 vdsc_bpp, fec_coeff, refresh_rate, cdclk;Most of these probably don't need to be u64.
Yeah will drop u64.
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 526
Quoted 1 line
drivers/gpu/drm/i915/display/intel_audio.c +1
-0+u64 rounding_factor =100000 ;Macro.
Sure, will update this.
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_audio.c +4
-0+u32 val; + + val =intel_de_read (dev_priv,AUD_CONFIG_BE ); +
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 535
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_audio.c +5
-0+if (INTEL_GEN (dev_priv) ==11 ) + val |=HBLANK_EARLY_ENABLE_ICL (pipe); +else if (INTEL_GEN (dev_priv) >=12 ) + val |=HBLANK_EARLY_ENABLE_TGL (pipe); +So if it's gen < 11 without dsc, you'll just read and write the register? Probably want to bail out early.
Right, will fix this.
Quoted 21 lines
Quoted 8 lines
drivers/gpu/drm/i915/display/intel_audio.c +8
-0+if (crtc_state->dsc.compression_enable && + (crtc_state->hw.adjusted_mode.hdisplay >=3840 && + crtc_state->hw.adjusted_mode.vdisplay >=2160 )) { + h_active = crtc_state->hw.adjusted_mode.hdisplay; + h_total = crtc_state->hw.adjusted_mode.htotal; + v_total = crtc_state->hw.adjusted_mode.vtotal; + hblank_rise = crtc_state->hw.adjusted_mode.hsync_start; + pixel_clk = crtc_state->hw.adjusted_mode.clock;drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 553
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_audio.c +10
-0+ link_clk = crtc_state->port_clock; + lanes = crtc_state->lane_count; + vdsc_bpp = crtc_state->pipe_bpp; + refresh_rate = crtc_state->hw.adjusted_mode.vrefresh; + cdclk = dev_priv->cdclk.hw.cdclk; +/* fec= 0.972261, using rounding multiplier of 1000000 */ + fec_coeff =972261 ; + +if (!(h_active && link_clk && lanes && vdsc_bpp && cdclk)) { +drm_err (&dev_priv->drm,"Null Parameters received\n" );What's the user going to do with that information?
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 554
Quoted 1 line
drivers/gpu/drm/i915/display/intel_audio.c +1
-0+return ;No need to write HBLANK_EARLY_ENABLE_* then?
Ideally we should not get Null params here, will add a WARN_ON instead.
Quoted 51 lines
Quoted 28 lines
drivers/gpu/drm/i915/display/intel_audio.c +28
-0+ } + +drm_dbg_kms (&dev_priv->drm,"h_active = %llu link_clk = %llu :" +"lanes = %llu vdsc_bpp = %llu cdclk = %llu\n" , + h_active, link_clk, lanes, vdsc_bpp, cdclk); + + link_clks_available = ((((h_total - h_active) * + ((link_clk * rounding_factor) / + pixel_clk)) / rounding_factor) -28 ); + + link_clks_required =DIV_ROUND_UP (192000 , (refresh_rate * + v_total)) * + ((48 / lanes) +2 ); + +if (link_clks_available > link_clks_required) + hblank_delta =32 ; +else + hblank_delta =DIV_ROUND_UP (((((5 * rounding_factor) / + link_clk) + ((5 * + rounding_factor) / cdclk)) * + pixel_clk), rounding_factor); + + tu_data = (pixel_clk * vdsc_bpp *8 ) / ((link_clk * + lanes * fec_coeff) / +1000000 ); + tu_line = (((h_active * link_clk * fec_coeff) /1000000 ) / + (64 * pixel_clk)); + link_clks_active = (tu_line -1 ) *64 + tu_data;drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder,
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_audio.c +10
-0+ hblank_rise = ((link_clks_active +6 * +DIV_ROUND_UP (link_clks_active,250 ) +4 ) * + ((pixel_clk * rounding_factor) / + link_clk)) / rounding_factor; + + hblank_early_prog = h_active - hblank_rise + hblank_delta; + +if (hblank_early_prog <32 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=
HBLANK_START_COUNT(HBLANK_START_COUNT_32, pipe);drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder,
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_audio.c +3
-0+ }else if (hblank_early_prog <64 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=
HBLANK_START_COUNT(HBLANK_START_COUNT_64, pipe);drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder,
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_audio.c +3
-0+ }else if (hblank_early_prog <96 ) { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=
HBLANK_START_COUNT(HBLANK_START_COUNT_96, pipe);drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder,
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_audio.c +3
-0+ }else { + val &= ~HBLANK_START_COUNT_MASK (pipe); + val |=
HBLANK_START_COUNT(HBLANK_START_COUNT_128, pipe);
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 607
Quoted 6 lines
drivers/gpu/drm/i915/display/intel_audio.c +6
-0+ } + + samples_room = ((((h_total - h_active) * + ((link_clk * rounding_factor) / + pixel_clk)) / rounding_factor) -12 ) / + ((48 / lanes) +2 );Please abstract the calculation of
hblank_early_progandsamples_roomto separate helpers, and pass incrtc_state. You also don't have to make everything you need fromcrtc_statea local variable.
Sure, will modify this.
Quoted 45 lines
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_audio.c +5
-0+ +if (samples_room <3 ) { + val &= ~NUMBER_SAMPLES_PER_LINE_MASK (pipe); + val |=NUMBER_SAMPLES_PER_LINE (samples_room, pipe); + }else {drivers/gpu/drm/i915/display/intel_audio.c static void hsw_audio_codec_disable(struct intel_encoder *encoder, · line 623
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_audio.c +7
-0+ val &= ~NUMBER_SAMPLES_PER_LINE_MASK (pipe); + val |=NUMBER_SAMPLES_PER_LINE (0x0 , pipe); + } + } + +intel_de_write (dev_priv,AUD_CONFIG_BE , val); } +static void hsw_audio_codec_enable (struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state,const struct drm_connector_state *conn_state)@@ -529,6
Quoted 18 lines
drivers/gpu/drm/i915/display/intel_audio.c +1
-0+635,10 @@ static void hsw_audio_codec_enable(struct intel_encoder*encoder,
drivers/gpu/drm/i915/display/intel_audio.c +4
-0mutex_lock (&dev_priv->av_mutex); +/* Enable Audio WA for 4k DSC usecases */ +if (encoder->type ==INTEL_OUTPUT_DP ) +enable_audio_dsc_wa (encoder, crtc_state); +/* Enable audio presence detect, invalidate ELD */ tmp =intel_de_read (dev_priv,HSW_AUD_PIN_ELD_CP_VLD ); tmp |=AUDIO_OUTPUT_ENABLE (cpu_transcoder);(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hindex8cebb7a86b8c..ff293e9d5a63100644drivers/gpu/drm/i915/i915_reg.h enum { · line 9403
Quoted 9 lines
drivers/gpu/drm/i915/i915_reg.h +6
-0@@ -9395,6 +9395,22 @@ enum {#define AUD_PIN_BUF_CTL _MMIO(0x48414)#define AUD_PIN_BUF_ENABLE REG_BIT(31) +/* Display Audio Config Reg */ +#define AUD_CONFIG_BE _MMIO(0x65ef0) +#define HBLANK_EARLY_ENABLE_ICL (pipe) (0x1 << (20 - (pipe))) +#define HBLANK_EARLY_ENABLE_TGL (pipe) (0x1 << (24 + (pipe))) +#define HBLANK_START_COUNT_MASK (pipe) (0x7 << (3 + ((pipe) * 6))) +#define HBLANK_START_COUNT (val, pipe) (((val) & 0x7) << (3 +((pipe)) * 6))
Quoted 3 lines
I'd swap pipe and val params around. Same below.
You might find
REG_FIELD_PREPetc. useful.
Ok Sure.
Quoted 12 lines
drivers/gpu/drm/i915/i915_reg.h enum { · line 9405
Quoted 2 lines
drivers/gpu/drm/i915/i915_reg.h +2
-0+#define NUMBER_SAMPLES_PER_LINE_MASK (pipe) (0x3 << ((pipe) * 6)) +#define NUMBER_SAMPLES_PER_LINE (val, pipe) (((val) & 0x3) << ((pipe) *6))
drivers/gpu/drm/i915/i915_reg.h enum { · line 9412
Quoted 7 lines
drivers/gpu/drm/i915/i915_reg.h +7
-0+ +#define HBLANK_START_COUNT_8 0x0 +#define HBLANK_START_COUNT_16 0x1 +#define HBLANK_START_COUNT_32 0x2 +#define HBLANK_START_COUNT_64 0x3 +#define HBLANK_START_COUNT_96 0x4 +#define HBLANK_START_COUNT_128 0x5They're just numbers, hex doesn't provide anything useful here.
Will update.
Thanks Jani for review and useful pointers. Will send out next version addressing all comments.
Regards,
Uma Shankar
Quoted 7 lines
drivers/gpu/drm/i915/i915_reg.h enum { · line 9416
Quoted 4 lines
drivers/gpu/drm/i915/i915_reg.h +1
-0+/* * HSW - ICL power wells * --
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Enable DP Display Audio WA
In reply to Uma Shankar== Series Details ==
== Series Details ==
Series: drm/i915/display: Enable DP Display Audio WA
URL : https://patchwork.freedesktop.org/series/75582/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8264_full -> Patchwork_17227_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17227_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@gem_wait@write-wait@rcs0}:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl1/igt@gem_wait@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl3/igt@gem_wait@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17227_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][3] -> [DMESG-WARN][4] ([i915#180]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-kbl4/igt@[email protected]
* igt@i915_selftest@live@active:
- shard-skl: [PASS][5] -> [DMESG-FAIL][6] ([i915#666])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl9/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl10/igt@i915_selftest@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#54] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-apl3/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- shard-snb: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-snb2/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-pwrite-xtiled:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#52] / [i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-glk8/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#79])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-glk1/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-apl1/igt@[email protected]
* igt@kms_flip@plain-flip-fb-recreate-interruptible:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#1487])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-glk6/igt@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible:
- shard-skl: [PASS][19] -> [FAIL][20] ([i915#34])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl6/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl8/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#1188])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145] / [i915#265])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl5/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl3/igt@[email protected]
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#43])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-glk3/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [PASS][27] -> [INCOMPLETE][28] ([i915#69])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl3/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl10/igt@[email protected]
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@rcs0}:
- shard-apl: [DMESG-WARN][29] ([i915#180]) -> [PASS][30] +4 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl6/igt@gem_ctx_isolation@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-apl8/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_balancer@hang:
- shard-tglb: [FAIL][31] ([i915#1277]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-tglb6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-tglb3/igt@[email protected]
* igt@i915_pm_rpm@basic-pci-d3-state:
- shard-skl: [FAIL][33] ([i915#138]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl5/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl3/igt@[email protected]
* igt@i915_selftest@live@blt:
- shard-snb: [DMESG-FAIL][35] ([i915#1409]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb4/igt@i915_selftest@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-snb6/igt@i915_selftest@[email protected]
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-skl: [INCOMPLETE][37] ([i915#69]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl9/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [DMESG-WARN][39] ([i915#180] / [i915#93] / [i915#95]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-kbl7/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check:
- shard-glk: [FAIL][41] ([i915#34]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-glk5/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-glk4/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-apl: [FAIL][43] ([i915#79]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-apl6/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-kbl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl3/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-kbl2/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][47] ([i915#1188]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl4/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl8/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-snb: [DMESG-WARN][49] ([i915#42]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-snb6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-snb1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][51] ([fdo#108145] / [i915#265]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-skl8/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-skl8/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-none:
- shard-kbl: [DMESG-WARN][53] ([i915#165] / [i915#78]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl2/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-kbl3/igt@[email protected]
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][55] ([i915#31]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-kbl4/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-kbl1/igt@[email protected]
* {igt@perf@blocking-parameterized}:
- shard-iclb: [FAIL][57] ([i915#1542]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-iclb8/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-apl: [FAIL][59] ([fdo#108145] / [i915#265]) -> [FAIL][60] ([fdo#108145] / [i915#265] / [i915#95])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8264/shard-apl3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/shard-apl1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1277]: https://gitlab.freedesktop.org/drm/intel/issues/1277
[i915#138]: https://gitlab.freedesktop.org/drm/intel/issues/138
[i915#1409]: https://gitlab.freedesktop.org/drm/intel/issues/1409
[i915#1487]: https://gitlab.freedesktop.org/drm/intel/issues/1487
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#666]: https://gitlab.freedesktop.org/drm/intel/issues/666
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8264 -> Patchwork_17227
CI-20190529: 20190529
CI_DRM_8264: e0104585f880a64d4a9b40803cf4fb51ab499f7c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5573: 9c582425d6b4fc1de9fc2ffc8015cc6f0a0d3e98 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17227: 4b7c7a1dc51c77c7d32c5b48f44b5a9ab37a8565 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17227/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx