platform/chrome: cros_ec_sensorhub: Off by one in cros_sensorhub_send_sample()
PATCH 1/1 platform/chrome: cros_ec_sensorhub: Off by one in cros_sensorhub_send_sample()
The sensorhub->push_data[] array has sensorhub->sensor_num elements.
It's allocated in cros_ec_sensorhub_ring_add(). So the > should be >to prevent a read one element beyond the end of the array.
Fixes 145d59baff59 ("platform/chrome: cros_ec_sensorhub: Add FIFO support")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/platform/chrome/cros_ec_sensorhub_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/chrome/cros_ec_sensorhub_ring.c +1 -1
@@ -40,7 +40,7 @@ cros_sensorhub_send_sample(struct cros_ec_sensorhub *sensorhub,int id = sample->sensor_id;struct iio_dev *indio_dev; -if (id > sensorhub->sensor_num) +if (id >= sensorhub->sensor_num)return -EINVAL ; cb = sensorhub->push_data[id].push_data_cb;
Signature · 1 line
2.25.1
Quoted 6 lines · Dan Carpenter
The sensorhub->push_data[] array has
sensorhub->sensor_numelements.
It's allocated incros_ec_sensorhub_ring_add(). So the > should be >> to prevent a read one element beyond the end of the array.Fixes 145d59baff59 ("platform/chrome: cros_ec_sensorhub: Add FIFO support")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
Quoted 20 lines
--- drivers/platform/chrome/cros_ec_sensorhub_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/chrome/cros_ec_sensorhub_ring.c +1
-2@@ -40,7 +40,7 @@ cros_sensorhub_send_sample(struct cros_ec_sensorhub *sensorhub,int id = sample->sensor_id;struct iio_dev *indio_dev; -if (id > sensorhub->sensor_num) +if (id >= sensorhub->sensor_num)return -EINVAL ; cb = sensorhub->push_data[id].push_data_cb; --2.25.1
Enric Balletbo i Serra
AppliedHi Dan,
Thank you for your patch.
Quoted 6 lines · Dan Carpenter
The sensorhub->push_data[] array has
sensorhub->sensor_numelements.
It's allocated incros_ec_sensorhub_ring_add(). So the > should be >> to prevent a read one element beyond the end of the array.Fixes 145d59baff59 ("platform/chrome: cros_ec_sensorhub: Add FIFO support")Signed-off-by Dan Carpenter <[email protected]>---
Applied as a fix for 5.7
Quoted 17 lines
drivers/platform/chrome/cros_ec_sensorhub_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/platform/chrome/cros_ec_sensorhub_ring.c +1
-1@@ -40,7 +40,7 @@ cros_sensorhub_send_sample(struct cros_ec_sensorhub *sensorhub,int id = sample->sensor_id;struct iio_dev *indio_dev; -if (id > sensorhub->sensor_num) +if (id >= sensorhub->sensor_num)return -EINVAL ; cb = sensorhub->push_data[id].push_data_cb;