media: vicodec: Fix error codes in probe function
Subsystems (2)
PATCH 1/1 media: vicodec: Fix error codes in probe function
If these functions fail then we return success, but we should instead preserve negative error code and return that.
Fixes fde649b418d1 ("media: vicodec: Register another node for stateless decoder")
Fixes c022a4a95722 ("media: vicodec: add struct for encoder/decoder instance")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/media/platform/vicodec/vicodec-core.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
drivers/media/platform/vicodec/vicodec-core.c +9 -6
@@ -2114,16 +2114,19 @@ static int vicodec_probe(struct platform_device *pdev)platform_set_drvdata (pdev, dev); -if (register_instance (dev, &dev->stateful_enc, -"stateful-encoder" , true)) + ret =register_instance (dev, &dev->stateful_enc,"stateful-encoder" , + true); +if (ret) goto unreg_dev; -if (register_instance (dev, &dev->stateful_dec, -"stateful-decoder" , false)) + ret =register_instance (dev, &dev->stateful_dec,"stateful-decoder" , + false); +if (ret) goto unreg_sf_enc; -if (register_instance (dev, &dev->stateless_dec, -"stateless-decoder" , false)) + ret =register_instance (dev, &dev->stateless_dec,"stateless-decoder" , + false); +if (ret) goto unreg_sf_dec;#ifdef CONFIG_MEDIA_CONTROLLER
Signature · 1 line
2.25.1