Skip to contentSkip to conversation

phy: tegra: fix USB dependencies

PATCH In review Arnd Bergmann 3 participants 4 messages Apr 8, 2020 – Apr 11, 2020

Subsystems (2)
Tegra architecture support Generic PHY framework
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 phy: tegra: fix USB dependencies

Without CONFIG_USB_SUPPORT, we can get a couple of warnings for missing dependencies:

WARNING: unmet direct dependencies detected for USB_PHY
Depends on [n]: USB_SUPPORT [=n]
Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

WARNING: unmet direct dependencies detected for USB_CONN_GPIO
Depends on [n]: USB_SUPPORT [=n] && GPIOLIB [=y] Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

Fixes 6835bdc99580 ("phy: tegra: Select USB_PHY")
Fixes f67213cee2b3 ("phy: tegra: xusb: Add usb-role-switch support")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/tegra/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/tegra/Kconfig +1 -1
index a208aca4ba7b..4f8c61863411 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config PHY_TEGRA_XUSB
 	tristate "NVIDIA Tegra XUSB pad controller driver"
-	depends on ARCH_TEGRA
+	depends on ARCH_TEGRA && USB_SUPPORT
 	select USB_CONN_GPIO
 	select USB_PHY
 	help
Signature · 1 line
2.26.0
#1 lore raw
Quoted 13 lines · Arnd Bergmann

Without CONFIG_USB_SUPPORT, we can get a couple of warnings for missing dependencies:

WARNING: unmet direct dependencies detected for USB_PHY
Depends on [n]: USB_SUPPORT [=n]
Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

WARNING: unmet direct dependencies detected for USB_CONN_GPIO
Depends on [n]: USB_SUPPORT [=n] && GPIOLIB [=y] Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

Quoted 6 lines
Fixes 6835bdc99580 ("phy: tegra: Select USB_PHY")
Fixes f67213cee2b3 ("phy: tegra: xusb: Add usb-role-switch support")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/tegra/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I sent a similar patch a couple of days ago:

	http://patchwork.ozlabs.org/patch/1263865/

This should be applied by Greg on top of the PR that I sent for USB. I did get the semi-automated "we're in the merge window" reply from Greg, but I was under the impression that he still applied fixes during the merge window. It seems like he didn't pick this up yet, though.

Greg, anything I should've done differently for you to notice this?

Thierry

Quoted 16 lines
drivers/phy/tegra/Kconfig +1 -1
index a208aca4ba7b..4f8c61863411 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config PHY_TEGRA_XUSB
 	tristate "NVIDIA Tegra XUSB pad controller driver"
-	depends on ARCH_TEGRA
+	depends on ARCH_TEGRA && USB_SUPPORT
 	select USB_CONN_GPIO
 	select USB_PHY
 	help
Signature · 1 line
2.26.0
#2 lore raw
Quoted 23 lines · Thierry Reding
Quoted 13 lines · Arnd Bergmann

Without CONFIG_USB_SUPPORT, we can get a couple of warnings for missing dependencies:

WARNING: unmet direct dependencies detected for USB_PHY
Depends on [n]: USB_SUPPORT [=n]
Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

WARNING: unmet direct dependencies detected for USB_CONN_GPIO
Depends on [n]: USB_SUPPORT [=n] && GPIOLIB [=y] Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

Quoted 6 lines
Fixes 6835bdc99580 ("phy: tegra: Select USB_PHY")
Fixes f67213cee2b3 ("phy: tegra: xusb: Add usb-role-switch support")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/tegra/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I sent a similar patch a couple of days ago:

Quoted 8 lines
	http://patchwork.ozlabs.org/patch/1263865/

This should be applied by Greg on top of the PR that I sent for USB. I did get the semi-automated "we're in the merge window" reply from Greg, but I was under the impression that he still applied fixes during the merge window. It seems like he didn't pick this up yet, though.

Greg, anything I should've done differently for you to notice this?

I try not to apply anything during the merge window...

author
#3 lore raw
In reply to Thierry Reding
Quoted 24 lines · Thierry Reding
Quoted 13 lines · Arnd Bergmann

Without CONFIG_USB_SUPPORT, we can get a couple of warnings for missing dependencies:

WARNING: unmet direct dependencies detected for USB_PHY
Depends on [n]: USB_SUPPORT [=n]
Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

WARNING: unmet direct dependencies detected for USB_CONN_GPIO
Depends on [n]: USB_SUPPORT [=n] && GPIOLIB [=y] Selected by [m]:
- PHY_TEGRA_XUSB [=m] && ARCH_TEGRA [=y]

Quoted 6 lines
Fixes 6835bdc99580 ("phy: tegra: Select USB_PHY")
Fixes f67213cee2b3 ("phy: tegra: xusb: Add usb-role-switch support")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/phy/tegra/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I sent a similar patch a couple of days ago:

Quoted 8 lines
        http://patchwork.ozlabs.org/patch/1263865/

This should be applied by Greg on top of the PR that I sent for USB. I did get the semi-automated "we're in the merge window" reply from Greg, but I was under the impression that he still applied fixes during the merge window. It seems like he didn't pick this up yet, though.

Greg, anything I should've done differently for you to notice this?

FWIW, your patch is correct, mine was wrong as I forgot the "select USB_COMMON".

Arnd