Skip to contentSkip to conversation

board: add InnoComm i.MX8MM WB15EVK

PATCH New Matt Porter 2 participants 3 messages Apr 9, 2020 – Apr 20, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: add InnoComm i.MX8MM WB15EVK

Add support for the InnoComm i.MX8MM WB15EVK board
(https://www.innocomm.com/product_inner.aspx?num=2233).

The following functionality is supported:
- eMMC
- MMC/SD
- GPIO
- I2C
- Ethernet

---
 arch/arm/dts/Makefile                         |    1 +
 arch/arm/dts/imx8mm-wb15evk-u-boot.dtsi       |  120 ++
 arch/arm/dts/imx8mm-wb15evk.dts               |  390 ++++
 arch/arm/mach-imx/imx8m/Kconfig               |    7 +
 board/innocomm/imx8mm_wb15evk/Kconfig         |   16 +
 board/innocomm/imx8mm_wb15evk/MAINTAINERS     |    6 +
 board/innocomm/imx8mm_wb15evk/Makefile        |   14 +
 board/innocomm/imx8mm_wb15evk/README.rst      |   46 +
 .../innocomm/imx8mm_wb15evk/imx8mm_wb15evk.c  |   35 +
 .../imx8mm_wb15evk/lpddr4_timing-2400mts.c    | 1849 +++++++++++++++++
 board/innocomm/imx8mm_wb15evk/lpddr4_timing.c | 1849 +++++++++++++++++
 board/innocomm/imx8mm_wb15evk/spl.c           |  173 ++
 configs/imx8mm_wb15evk_defconfig              |   83 +
 include/configs/imx8mm_wb15evk.h              |  156 ++
 14 files changed, 4745 insertions(+)
 create mode 100644 arch/arm/dts/imx8mm-wb15evk-u-boot.dtsi
 create mode 100644 arch/arm/dts/imx8mm-wb15evk.dts
 create mode 100644 board/innocomm/imx8mm_wb15evk/Kconfig
 create mode 100644 board/innocomm/imx8mm_wb15evk/MAINTAINERS
 create mode 100644 board/innocomm/imx8mm_wb15evk/Makefile
 create mode 100644 board/innocomm/imx8mm_wb15evk/README.rst
 create mode 100644 board/innocomm/imx8mm_wb15evk/imx8mm_wb15evk.c
 create mode 100644 board/innocomm/imx8mm_wb15evk/lpddr4_timing-2400mts.c
 create mode 100644 board/innocomm/imx8mm_wb15evk/lpddr4_timing.c
 create mode 100644 board/innocomm/imx8mm_wb15evk/spl.c
 create mode 100644 configs/imx8mm_wb15evk_defconfig
 create mode 100644 include/configs/imx8mm_wb15evk.h
arch/arm/dts/Makefile +1 -0
index 820ee9733a..128c118ac3 100644
@@ -721,6 +721,7 @@ dtb-$(CONFIG_ARCH_IMX8) += \
 dtb-$(CONFIG_ARCH_IMX8M) += \
 	imx8mm-evk.dtb \
 	imx8mm-verdin.dtb \
+	imx8mm-wb15evk.dtb \
 	imx8mn-ddr4-evk.dtb \
 	imx8mq-evk.dtb \
 	imx8mp-evk.dtb
arch/arm/dts/imx8mm-wb15evk-u-boot.dtsi new file +120 -0

120 lines not on this page · raw message

arch/arm/dts/imx8mm-wb15evk.dts new file +390 -0

390 lines not on this page · raw message

arch/arm/mach-imx/imx8m/Kconfig +7 -0
index 58f1758ab6..461429e871 100644
@@ -56,12 +56,19 @@ config TARGET_VERDIN_IMX8MM
        select SUPPORT_SPL
        select IMX8M_LPDDR4
 
+config TARGET_IMX8MM_WB15EVK
+	bool "Support InnoComm i.MX8MM WB15EVK"
+	select IMX8MM
+	select SUPPORT_SPL
+	select IMX8M_LPDDR4
+
 endchoice
 
 source "board/freescale/imx8mq_evk/Kconfig"
 source "board/freescale/imx8mm_evk/Kconfig"
 source "board/freescale/imx8mn_evk/Kconfig"
 source "board/freescale/imx8mp_evk/Kconfig"
+source "board/innocomm/imx8mm_wb15evk/Kconfig"
 source "board/toradex/verdin-imx8mm/Kconfig"
 
 endif
board/innocomm/imx8mm_wb15evk/Kconfig new file +16 -0
new file mode 100644
index 0000000000..d840066322
@@ -0,0 +1,16 @@
+if TARGET_IMX8MM_WB15EVK
+
+config SYS_BOARD
+	default "imx8mm_wb15evk"
+
+config SYS_VENDOR
+	default "innocomm"
+
+config SYS_CONFIG_NAME
+	default "imx8mm_wb15evk"
+
+config IMX8M_LPDDR4_2400MTS
+	default n
+	bool "DRAM PLL OUT is 600MHz"
+
+endif
board/innocomm/imx8mm_wb15evk/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..d74c7cb275
@@ -0,0 +1,6 @@
+i.MX8MM WB15EVK BOARD
+M:	Matt Porter <[email protected]>
+S:	Maintained
+F:	board/innocomm/imx8mm_wb15evk/
+F:	include/configs/imx8mm_wb15evk.h
+F:	configs/imx8mm_wb15evk_defconfig
board/innocomm/imx8mm_wb15evk/Makefile new file +14 -0
new file mode 100644
index 0000000000..a4b89a98ec
@@ -0,0 +1,14 @@
+# SPDX-License-Identifier:      GPL-2.0+
+#
+# Copyright 2018 InnoComm Mobile Technology Corp.
+
+obj-y += imx8mm_wb15evk.o
+
+ifdef CONFIG_SPL_BUILD
+obj-y += spl.o
+ifdef CONFIG_IMX8M_LPDDR4_2400MTS
+obj-$(CONFIG_IMX8M_LPDDR4) += lpddr4_timing-2400mts.o
+else
+obj-$(CONFIG_IMX8M_LPDDR4) += lpddr4_timing.o
+endif
+endif
board/innocomm/imx8mm_wb15evk/README.rst new file +46 -0

46 lines not on this page · raw message

board/innocomm/imx8mm_wb15evk/imx8mm_wb15evk.c new file +35 -0
new file mode 100644
index 0000000000..27c42d054c
@@ -0,0 +1,35 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2018 NXP
+ * Copyright 2020 Konsulko Group
+ */
+
+#include <common.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+int dram_init(void)
+{
+	gd->ram_size = PHYS_SDRAM_SIZE;
+
+	return 0;
+}
+
+int board_init(void)
+{
+	return 0;
+}
+
+int board_mmc_get_env_dev(int devno)
+{
+	return devno;
+}
+
+int board_late_init(void)
+{
+#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+	env_set("board_name", "WB15EVK");
+	env_set("board_rev", "iMX8MM");
+#endif
+	return 0;
+}
board/innocomm/imx8mm_wb15evk/lpddr4_timing-2400mts.c new file +1849 -0

1,849 lines not on this page · raw message

board/innocomm/imx8mm_wb15evk/lpddr4_timing.c new file +1849 -0

498 lines not on this page · raw message

board/innocomm/imx8mm_wb15evk/spl.c new file +173 -0

173 lines not on this page · raw message

configs/imx8mm_wb15evk_defconfig new file +83 -0

83 lines not on this page · raw message

include/configs/imx8mm_wb15evk.h new file +156 -0

156 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.20.1

Part of the diff is not shown here. View the raw message.

reviewer
#1 lore raw

PATCH 1/1 board: add InnoComm i.MX8MM WB15EVK

Hi Matt,

On Thu, Apr 9, 2020 at 6:51 PM Matt Porter <[email protected]> wrote:

Hopefully this dts will be sent upstream.

arch/arm/dts/imx8mm-wb15evk.dts line 13

Quoted 3 lines
arch/arm/dts/imx8mm-wb15evk.dts new file +3 -0
+/ {
+       model = "InnoComm i.MX8MM WB15EVK";
+       compatible = "fsl,imx8mm-wb15evk", "fsl,imx8mm";

Should be "innocomm,imx8mm-wb15evk", "fsl,imx8mm" instead, since the board manufacturer is InnoComm.

arch/arm/dts/imx8mm-wb15evk.dts line 62

Quoted 8 lines

+&gpio1 {

arch/arm/dts/imx8mm-wb15evk.dts new file +7 -0
+       phy_en {
+               gpio-hog;
+               gpios = <10 GPIO_ACTIVE_HIGH>;
+               output-high;
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_phy_en>;
+       };

Shouldn't this be modelled as a phy-supply GPIO controlled regulator instead?

configs/imx8mm_wb15evk_defconfig line 3

Quoted 2 lines
configs/imx8mm_wb15evk_defconfig new file +2 -0
+CONFIG_SPL_SYS_ICACHE_OFF=y
+CONFIG_SPL_SYS_DCACHE_OFF=y

Can't we work with caches enabled by now?

include/configs/imx8mm_wb15evk.h line 140

Quoted 2 lines
include/configs/imx8mm_wb15evk.h new file +2 -0
+/* USDHC */
+#define CONFIG_FSL_USDHC

Better put it in the defconfig instead.

include/configs/imx8mm_wb15evk.h line 152

Quoted 2 lines
include/configs/imx8mm_wb15evk.h new file +2 -0
+#define CONFIG_FEC_XCV_TYPE             RGMII
+#define FEC_QUIRK_ENET_MAC

Shouldn't this be moved to a SoC header instead of each board file?

include/configs/imx8mm_wb15evk.h line 154

Quoted 2 lines
include/configs/imx8mm_wb15evk.h new file +2 -0
+
+#define IMX_FEC_BASE                    0x30BE0000

Not needed as you are using FEC DM.

#2 lore raw

PATCH 1/1 board: add InnoComm i.MX8MM WB15EVK

Quoted 1 line · Fabio Estevam

Hi Matt,

Hi Fabio, thanks for the review!

Quoted 3 lines · Matt Porter

Hopefully this dts will be sent upstream.

Yes, this just made it out first. Updating both accordingly below.

Quoted 7 lines

arch/arm/dts/imx8mm-wb15evk.dts line 13

Quoted 4 lines
arch/arm/dts/imx8mm-wb15evk.dts new file +3 -0
+/ {
+       model = "InnoComm i.MX8MM WB15EVK";
+       compatible = "fsl,imx8mm-wb15evk", "fsl,imx8mm";

Should be "innocomm,imx8mm-wb15evk", "fsl,imx8mm" instead, since the board manufacturer is InnoComm.

Oops, yeah, will fix that.

Quoted 11 lines

arch/arm/dts/imx8mm-wb15evk.dts line 62

Quoted 9 lines

+&gpio1 {

arch/arm/dts/imx8mm-wb15evk.dts new file +7 -0
+       phy_en {
+               gpio-hog;
+               gpios = <10 GPIO_ACTIVE_HIGH>;
+               output-high;
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_phy_en>;
+       };

Shouldn't this be modelled as a phy-supply GPIO controlled regulator instead?

Yes, converting it to a regulator will be better.

Quoted 4 lines

configs/imx8mm_wb15evk_defconfig line 3

Quoted 2 lines
configs/imx8mm_wb15evk_defconfig new file +2 -0
+CONFIG_SPL_SYS_ICACHE_OFF=y
+CONFIG_SPL_SYS_DCACHE_OFF=y

Can't we work with caches enabled by now?

Yes, I verified we're fine with cache on so I'll fix that.

Quoted 4 lines

include/configs/imx8mm_wb15evk.h line 140

Quoted 2 lines
include/configs/imx8mm_wb15evk.h new file +2 -0
+/* USDHC */
+#define CONFIG_FSL_USDHC

Better put it in the defconfig instead.

Ok.

Quoted 5 lines

include/configs/imx8mm_wb15evk.h line 152

Quoted 3 lines
include/configs/imx8mm_wb15evk.h new file +2 -0
+#define CONFIG_FEC_XCV_TYPE             RGMII
+#define FEC_QUIRK_ENET_MAC

Shouldn't this be moved to a SoC header instead of each board file?

It does look like it should be moved to imx-regs.h like imx6/7 do.

Quoted 4 lines

include/configs/imx8mm_wb15evk.h line 154

Quoted 2 lines
include/configs/imx8mm_wb15evk.h new file +2 -0
+
+#define IMX_FEC_BASE                    0x30BE0000

Not needed as you are using FEC DM.

Ok.

-Matt