Skip to contentSkip to conversation

pNFS: Fix RCU lock leakage

PATCH New [email protected] 1 participant 1 message Apr 11, 2020

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH 1/1 pNFS: Fix RCU lock leakage

From: Trond Myklebust <[email protected]>

Another brown paper bag moment. pnfs_alloc_ds_commits_list() is leaking the RCU lock.

Fixes a9901899b649 ("pNFS: Add infrastructure for cleaning up per-layout commit structures")
---
 fs/nfs/pnfs_nfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/nfs/pnfs_nfs.c +1 -0
index 25f135572fc8..e7ddbce48321 100644
@@ -501,6 +501,7 @@ pnfs_alloc_ds_commits_list(struct list_head *list,
 		rcu_read_lock();
 		pnfs_put_commit_array(array, cinfo->inode);
 	}
+	rcu_read_unlock();
 	return ret;
 }
 
Signature · 1 line
2.25.2