Skip to contentSkip to conversation

optee-os: Mark recipes dormant by default

PATCH In review Khem Raj 4 participants 8 messages Apr 12, 2020 – Apr 20, 2020 1 message not in the archive

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 optee-os: Mark recipes dormant by default

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it remains 'null'

---
 meta-arm/recipes-security/optee/optee-client_git.bb   | 2 ++
 meta-arm/recipes-security/optee/optee-examples_git.bb | 2 ++
 meta-arm/recipes-security/optee/optee-os_git.bb       | 1 +
 meta-arm/recipes-security/optee/optee-test_git.bb     | 1 +
 meta-arm/recipes-security/optee/optee.inc             | 2 ++
 5 files changed, 8 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee.inc
meta-arm/recipes-security/optee/optee-client_git.bb +2 -0
index a25d343..bae7b20 100644
@@ -7,6 +7,8 @@ LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=69663ab153298557a59c67a60a743e5b"
 
 PV = "3.8.0+git${SRCPV}"
 
+require optee.inc
+
 inherit python3native systemd
 
 SRCREV = "be4fa2e36f717f03ca46e574aa66f697a897d090"
meta-arm/recipes-security/optee/optee-examples_git.bb +2 -0
index 768a55b..996e2cd 100644
@@ -11,6 +11,8 @@ DEPENDS = "optee-client optee-os python3-pycryptodomex-native"
 
 inherit python3native
 
+require optee.inc
+
 SRC_URI = "git://github.com/linaro-swg/optee_examples.git"
 SRCREV = "559b2141c16bf0f57ccd72f60e4deb84fc2a05b0"
 
meta-arm/recipes-security/optee/optee-os_git.bb +1 -0
index 47ced12..5c420b7 100644
@@ -8,6 +8,7 @@ LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=c1f21c4f72f372ef38a5a4aee55ec173"
 PV = "3.8.0+git${SRCPV}"
 
 inherit deploy python3native
+require optee.inc
 
 DEPENDS = "python3-pycrypto-native python3-pyelftools-native python3-pycryptodomex-native"
 
meta-arm/recipes-security/optee/optee-test_git.bb +1 -0
index 752d75d..ee73a2c 100644
@@ -6,6 +6,7 @@ LICENSE = "BSD & GPLv2"
 LIC_FILES_CHKSUM = "file://${S}/LICENSE.md;md5=daa2bcccc666345ab8940aab1315a4fa"
 
 inherit python3native
+require optee.inc
 
 DEPENDS = "optee-client optee-os python3-pycryptodomex-native"
 
meta-arm/recipes-security/optee/optee.inc new file +2 -0
new file mode 100644
index 0000000..a12521d
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below
Signature · 1 line
2.26.0
#1 lore raw
Quoted 4 lines · Khem Raj

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it remains 'null'

Pulled into the master branch.

Thanks,
Jon

Quoted 74 lines
---
 meta-arm/recipes-security/optee/optee-client_git.bb   | 2 ++
 meta-arm/recipes-security/optee/optee-examples_git.bb | 2 ++
 meta-arm/recipes-security/optee/optee-os_git.bb       | 1 +
 meta-arm/recipes-security/optee/optee-test_git.bb     | 1 +
 meta-arm/recipes-security/optee/optee.inc             | 2 ++
 5 files changed, 8 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee.inc
meta-arm/recipes-security/optee/optee-client_git.bb +2 -0
index a25d343..bae7b20 100644
@@ -7,6 +7,8 @@ LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=69663ab153298557a59c67a60a743e5b"
 
 PV = "3.8.0+git${SRCPV}"
 
+require optee.inc
+
 inherit python3native systemd
 
 SRCREV = "be4fa2e36f717f03ca46e574aa66f697a897d090"
meta-arm/recipes-security/optee/optee-examples_git.bb +2 -0
index 768a55b..996e2cd 100644
@@ -11,6 +11,8 @@ DEPENDS = "optee-client optee-os python3-pycryptodomex-native"
 
 inherit python3native
 
+require optee.inc
+
 SRC_URI = "git://github.com/linaro-swg/optee_examples.git"
 SRCREV = "559b2141c16bf0f57ccd72f60e4deb84fc2a05b0"
 
meta-arm/recipes-security/optee/optee-os_git.bb +1 -0
index 47ced12..5c420b7 100644
@@ -8,6 +8,7 @@ LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=c1f21c4f72f372ef38a5a4aee55ec173"
 PV = "3.8.0+git${SRCPV}"
 
 inherit deploy python3native
+require optee.inc
 
 DEPENDS = "python3-pycrypto-native python3-pyelftools-native python3-pycryptodomex-native"
 
meta-arm/recipes-security/optee/optee-test_git.bb +1 -0
index 752d75d..ee73a2c 100644
@@ -6,6 +6,7 @@ LICENSE = "BSD & GPLv2"
 LIC_FILES_CHKSUM = "file://${S}/LICENSE.md;md5=daa2bcccc666345ab8940aab1315a4fa"
 
 inherit python3native
+require optee.inc
 
 DEPENDS = "optee-client optee-os python3-pycryptodomex-native"
 
meta-arm/recipes-security/optee/optee.inc new file +2 -0
new file mode 100644
index 0000000..a12521d
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below
Signature · 1 line
2.26.0
#2 lore raw
Quoted 7 lines · Jon Mason
Quoted 4 lines · Khem Raj

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it remains 'null'

Pulled into the master branch.

I think this was due to the parsing issues, resolved by another patch. What's the point of masking this recipes now?

Quoted 80 lines

Thanks,
Jon

Quoted 74 lines
---
 meta-arm/recipes-security/optee/optee-client_git.bb   | 2 ++
 meta-arm/recipes-security/optee/optee-examples_git.bb | 2 ++
 meta-arm/recipes-security/optee/optee-os_git.bb       | 1 +
 meta-arm/recipes-security/optee/optee-test_git.bb     | 1 +
 meta-arm/recipes-security/optee/optee.inc             | 2 ++
 5 files changed, 8 insertions(+)
 create mode 100644 meta-arm/recipes-security/optee/optee.inc
meta-arm/recipes-security/optee/optee-client_git.bb +2 -0
index a25d343..bae7b20 100644
@@ -7,6 +7,8 @@ LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=69663ab153298557a59c67a60a743e5b"
 
 PV = "3.8.0+git${SRCPV}"
 
+require optee.inc
+
 inherit python3native systemd
 
 SRCREV = "be4fa2e36f717f03ca46e574aa66f697a897d090"
meta-arm/recipes-security/optee/optee-examples_git.bb +2 -0
index 768a55b..996e2cd 100644
@@ -11,6 +11,8 @@ DEPENDS = "optee-client optee-os python3-pycryptodomex-native"
 
 inherit python3native
 
+require optee.inc
+
 SRC_URI = "git://github.com/linaro-swg/optee_examples.git"
 SRCREV = "559b2141c16bf0f57ccd72f60e4deb84fc2a05b0"
 
meta-arm/recipes-security/optee/optee-os_git.bb +1 -0
index 47ced12..5c420b7 100644
@@ -8,6 +8,7 @@ LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=c1f21c4f72f372ef38a5a4aee55ec173"
 PV = "3.8.0+git${SRCPV}"
 
 inherit deploy python3native
+require optee.inc
 
 DEPENDS = "python3-pycrypto-native python3-pyelftools-native python3-pycryptodomex-native"
 
meta-arm/recipes-security/optee/optee-test_git.bb +1 -0
index 752d75d..ee73a2c 100644
@@ -6,6 +6,7 @@ LICENSE = "BSD & GPLv2"
 LIC_FILES_CHKSUM = "file://${S}/LICENSE.md;md5=daa2bcccc666345ab8940aab1315a4fa"
 
 inherit python3native
+require optee.inc
 
 DEPENDS = "optee-client optee-os python3-pycryptodomex-native"
 
meta-arm/recipes-security/optee/optee.inc new file +2 -0
new file mode 100644
index 0000000..a12521d
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below
Signature · 1 line
2.26.0

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 16 lines · Denys Dmytriyenko
Quoted 7 lines · Jon Mason
Quoted 4 lines · Khem Raj

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it remains 'null'

Pulled into the master branch.

I think this was due to the parsing issues, resolved by another patch. What's the point of masking this recipes now?

Quoted 3 lines
Quoted 3 lines

---

Quoted 8 lines
Quoted 8 lines

meta-arm/recipes-security/optee/optee.inc line 2

Quoted 8 lines
meta-arm/recipes-security/optee/optee.inc new file +2 -0
new file mode 100644
index 0000000..a12521d
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below

Can we instead of neutering all OPTEE recipes and requiring BSPs to provide bbappends with COMPATIBLE_MACHINE for opt-in, add EXCLUDE_FROM_WORLD = "1"?

Signature · 1 line
Denys
author
#5 lore raw
Quoted 18 lines · Denys Dmytriyenko
Quoted 16 lines · Denys Dmytriyenko
Quoted 7 lines · Jon Mason
Quoted 4 lines · Khem Raj

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it remains 'null'

Pulled into the master branch.

I think this was due to the parsing issues, resolved by another patch. What's the point of masking this recipes now?

Quoted 3 lines
Quoted 3 lines

---

Quoted 11 lines
Quoted 8 lines
Quoted 8 lines

meta-arm/recipes-security/optee/optee.inc line 2

Quoted 8 lines
meta-arm/recipes-security/optee/optee.inc new file +2 -0
new file mode 100644
index 0000000..a12521d
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below

Can we instead of neutering all OPTEE recipes and requiring BSPs to provide bbappends with COMPATIBLE_MACHINE for opt-in, add EXCLUDE_FROM_WORLD = "1"?

its fine to provide it via bbappends, as long as it is per machine, which really supports Optee
it is also educational to understand the recipes thats way, excluding from world is then not required.

Quoted 3 lines

--
Denys

#6 lore raw
Quoted 31 lines · Khem Raj
Quoted 18 lines · Denys Dmytriyenko
Quoted 16 lines · Denys Dmytriyenko
Quoted 7 lines · Jon Mason
Quoted 4 lines · Khem Raj

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it remains 'null'

Pulled into the master branch.

I think this was due to the parsing issues, resolved by another patch. What's the point of masking this recipes now?

Quoted 3 lines
Quoted 3 lines

---

Quoted 11 lines
Quoted 8 lines
Quoted 8 lines

meta-arm/recipes-security/optee/optee.inc line 2

Quoted 8 lines
meta-arm/recipes-security/optee/optee.inc new file +2 -0
new file mode 100644
index 0000000..a12521d
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below

Can we instead of neutering all OPTEE recipes and requiring BSPs to provide bbappends with COMPATIBLE_MACHINE for opt-in, add EXCLUDE_FROM_WORLD = "1"?

Quoted 4 lines

its fine to provide it via bbappends, as long as it is per machine, which really supports Optee
it is also educational to understand the recipes thats way, excluding from world is then not required.

This is rather backwards. OPTEE is widely used these days.

What's the harm for the recipe to be fully open and compatible, if it's not being built by default?

Otherwise, we should similarly neuter ATF, U-boot and even kernel - not all platforms are supported by those and require per-machine support and configarion added. Why not require those to be opt-in via bbappends?

Signature · 1 line
Denys
#7 lore raw
Quoted 48 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
Sent: 14 April 2020 01:49
To: Khem Raj <[email protected]>
Cc: [email protected]
Subject: Re: [meta-arm][PATCH] optee-os: Mark recipes dormant by default

Quoted 1 line · Khem Raj

On Mon, Apr 13, 2020 at 3:40 PM Denys Dmytriyenko <[email protected]>

Quoted 8 lines · wrote:
Quoted 8 lines · Denys Dmytriyenko
Quoted 6 lines · Jon Mason
Quoted 5 lines · Khem Raj
Quoted 4 lines

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it

remains 'null'

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines

Pulled into the master branch.

I think this was due to the parsing issues, resolved by another patch. What's the point of masking this recipes now?

Quoted 3 lines
Quoted 3 lines

---

Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta-arm/recipes-security/optee/optee.inc new file +0 -0
new file mode 100644
index 0000000..a12521d
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

meta-arm/recipes-security/optee/optee.inc line 2

Quoted 5 lines
meta-arm/recipes-security/optee/optee.inc new file +2 -0
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below

Can we instead of neutering all OPTEE recipes and requiring BSPs to provide bbappends with COMPATIBLE_MACHINE for opt-in, add

EXCLUDE_FROM_WORLD = "1"?

Quoted 4 lines

its fine to provide it via bbappends, as long as it is per machine, which really supports Optee it is also educational to understand the recipes thats way, excluding from world is then not required.

Quoted 8 lines

This is rather backwards. OPTEE is widely used these days.

What's the harm for the recipe to be fully open and compatible, if it's not being built by default?

Otherwise, we should similarly neuter ATF, U-boot and even kernel - not all platforms are supported by those and require per-machine support and configarion added. Why not require those to be opt-in via bbappends?

For trusted-firmware-a recipe we use COMPATIBLE_MACHINE ?= "invalid" and I think we should we use the same strategy for optee (use the invalid term instead of null) to maintain consistency.

--
*dS

Quoted 3 lines

--
Denys

author
#8 lore raw
Quoted 54 lines · Diego Sueiro
Quoted 54 lines

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
Sent: 14 April 2020 01:49
To: Khem Raj <[email protected]>
Cc: [email protected]
Subject: Re: [meta-arm][PATCH] optee-os: Mark recipes dormant by default

Quoted 1 line · Khem Raj

On Mon, Apr 13, 2020 at 3:40 PM Denys Dmytriyenko <[email protected]>

Quoted 8 lines · wrote:
Quoted 8 lines · Denys Dmytriyenko
Quoted 6 lines · Jon Mason
Quoted 5 lines · Khem Raj
Quoted 4 lines

all arm SOCs may not support optee and there are non-arm machines too this makes this recipe fit into mutli-BSP environments, platforms which support optee should be specifically called out via COMPATIBLE_MACHINE, for general case it

remains 'null'

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 2 lines

Pulled into the master branch.

I think this was due to the parsing issues, resolved by another patch. What's the point of masking this recipes now?

Quoted 3 lines
Quoted 3 lines

---

Quoted 12 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
meta-arm/recipes-security/optee/optee.inc new file +0 -0
new file mode 100644
index 0000000..a12521d
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines

meta-arm/recipes-security/optee/optee.inc line 2

Quoted 5 lines
meta-arm/recipes-security/optee/optee.inc new file +2 -0
@@ -0,0 +1,2 @@
+COMPATIBLE_MACHINE = "null"
+# Please add supported machines below

Can we instead of neutering all OPTEE recipes and requiring BSPs to provide bbappends with COMPATIBLE_MACHINE for opt-in, add

EXCLUDE_FROM_WORLD = "1"?

Quoted 4 lines

its fine to provide it via bbappends, as long as it is per machine, which really supports Optee it is also educational to understand the recipes thats way, excluding from world is then not required.

This is rather backwards. OPTEE is widely used these days.

What's the harm for the recipe to be fully open and compatible, if it's not being built by default?

Quoted 8 lines
Quoted 3 lines

Otherwise, we should similarly neuter ATF, U-boot and even kernel - not all platforms are supported by those and require per-machine support and configarion added. Why not require those to be opt-in via bbappends?

For trusted-firmware-a recipe we use COMPATIBLE_MACHINE ?= "invalid" and I think we should we use the same strategy for optee (use the invalid term instead of null) to maintain consistency.

sure send a patch, I think that's fine.

Quoted 6 lines

--
*dS

Quoted 3 lines

--
Denys