Skip to contentSkip to conversation

mm-memcg-do-not-high-throttle-allocators-based-on-wraparound.patch removed from -mm tree

merged [email protected] 1 participant 1 message Apr 12, 2020 Stable branch

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: mm, memcg: do not high throttle allocators based on wraparound
has been removed from the -mm tree. Its filename was
mm-memcg-do-not-high-throttle-allocators-based-on-wraparound.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Jakub Kicinski <[email protected]>
Subject: mm, memcg: do not high throttle allocators based on wraparound

If a cgroup violates its memory.high constraints, we may end up unduly penalising it. For example, for the following hierarchy:

A:   max high, 20 usage
A/B: 9 high, 10 usage
A/C: max high, 10 usage

We would end up doing the following calculation below when calculating high delay for A/B:

A/B: 10 - 9 = 1...
A:   20 - PAGE_COUNTER_MAX = 21, so set max_overage to 21.

This gets worse with higher disparities in usage in the parent.

I have no idea how this disappeared from the final version of the patch, but it is certainly Not Good(tm). This wasn't obvious in testing because, for a simple cgroup hierarchy with only one child, the result is usually roughly the same. It's only in more complex hierarchies that things go really awry (although still, the effects are limited to a maximum of 2 seconds in schedule_timeout_killable at a maximum).

[[email protected]: changelog]
Fixes e26733e0d0ec ("mm, memcg: throttle allocators based on ancestral memory.high")
Cc Johannes Weiner <[email protected]>
Cc <[email protected]> [5.4.x]

---

 mm/memcontrol.c |    3 +++
 1 file changed, 3 insertions(+)
mm/memcontrol.c renamed from mm/memcontrol.c~mm-memcg-do-not-high-throttle-allocators-based-on-wraparound +3 -0
@@ -2336,6 +2336,9 @@ static unsigned long calculate_high_dela
 		usage = page_counter_read(&memcg->memory);
 		high = READ_ONCE(memcg->high);
 
+		if (usage <= high)
+			continue;
+
 		/*
 		 * Prevent division by 0 in overage calculation by acting as if
 		 * it was a threshold of 1 page

_

Patches currently in -mm which might be from [email protected] are