Skip to contentSkip to conversation

MAINTAINERS: rectify EDAC-SIFIVE entry

PATCH RESEND In review Lukas Bulwahn 2 participants 3 messages Apr 13, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 MAINTAINERS: rectify EDAC-SIFIVE entry

Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: drivers/soc/sifive_l2_cache.c

Rectify the EDAC-SIFIVE entry in MAINTAINERS now.

---
Paul, please pick this patch.

v1: https://lore.kernel.org/lkml/[email protected]/
- was not picked up.

v1-resend: applies on v5.7-rc1

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index e64e5db31497..e28676766b26 100644
@@ -6172,7 +6172,7 @@ M:	Yash Shah <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	drivers/edac/sifive_edac.c
-F:	drivers/soc/sifive_l2_cache.c
+F:	drivers/soc/sifive/sifive_l2_cache.c
 
 EDAC-SKYLAKE
 M:	Tony Luck <[email protected]>
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 29 lines · Lukas Bulwahn

Commit 9209fb51896f ("riscv: move sifive_l2_cache.c to drivers/soc") moved arch/riscv/mm/sifive_l2_cache.c to drivers/soc/sifive/sifive_l2_cache.c and adjusted the MAINTAINERS EDAC-SIFIVE entry but slipped in a mistake.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: drivers/soc/sifive_l2_cache.c

Rectify the EDAC-SIFIVE entry in MAINTAINERS now.

---
Paul, please pick this patch.

v1: https://lore.kernel.org/lkml/[email protected]/
- was not picked up.

v1-resend: applies on v5.7-rc1

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index e64e5db31497..e28676766b26 100644

MAINTAINERS M: Yash Shah <[email protected]> · line 6175

Quoted 5 lines
MAINTAINERS +1 -1
@@ -6172,7 +6172,7 @@ M:	Yash Shah <[email protected]>
 L:	[email protected]
 S:	Supported
 F:	drivers/edac/sifive_edac.c
-F:	drivers/soc/sifive_l2_cache.c
+F:	drivers/soc/sifive/sifive_l2_cache.c

Looking at that a bit - I think the right thing to do is to remove that sifive_l2_cache.c file from the EDAC-SIFIVE file pattern because the edac driver is simply using the L2 thing to register on its notifier chain, i.e., using an external facility, like all the drivers do. And the l2_cache thing is not part of the edac driver.

Thx.

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
#2 lore raw
Quoted 7 lines · Borislav Petkov

Looking at that a bit - I think the right thing to do is to remove that sifive_l2_cache.c file from the EDAC-SIFIVE file pattern because the edac driver is simply using the L2 thing to register on its notifier chain, i.e., using an external facility, like all the drivers do. And the l2_cache thing is not part of the edac driver.

Thanks for the pointer.

I adjusted the patch, first accidently sent a broken PATCH v2 (which shall be ignored), but this PATCH v3 shall be picked:

https://lore.kernel.org/lkml/[email protected]/

Lukas