Skip to contentSkip to conversation

drm/i915/icl: Update forcewake firmware ranges

PATCH Superseded Radhakrishna Sripada 3 participants 8 messages Apr 13, 2020 – Apr 15, 2020

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/icl: Update forcewake firmware ranges

Some workarounds are not sticking across suspend resume cycles. The forcewake ranges table has been updated and would reflect the hardware appropriately.

---
 drivers/gpu/drm/i915/intel_uncore.c | 55 +++++++++++++++++++++--------
 1 file changed, 41 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/intel_uncore.c +41 -14
index fa86b7ab2d99..c0e21697a44c 100644
@@ -1098,32 +1098,59 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {
 	GEN_FW_RANGE(0x2700, 0x2fff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x3000, 0x3fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x4000, 0x51ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x5200, 0x7fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5200, 0x53ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5400, 0x54ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x5500, 0x7fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8000, 0x813f, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8140, 0x815f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8160, 0x82ff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8300, 0x84ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8500, 0x8bff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8500, 0x87ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8800, 0x883f, 0),
+	GEN_FW_RANGE(0x8840, 0x8bff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8c00, 0x8cff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8d00, 0x93ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x9400, 0x97ff, FORCEWAKE_ALL),
-	GEN_FW_RANGE(0x9800, 0xafff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8d00, 0x94cf, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x94d0, 0x955f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x9560, 0x95ff, 0),
+	GEN_FW_RANGE(0x9600, 0xafff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xb000, 0xb47f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xb480, 0xdeff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xdf00, 0xe8ff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xe900, 0x16dff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x16e00, 0x19fff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x1a000, 0x243ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x24400, 0x247ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x24800, 0x3ffff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1a000, 0x23fff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24000, 0x2407f, 0),
+	GEN_FW_RANGE(0x24080, 0x2417f, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24180, 0x242ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24300, 0x243ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24400, 0x245ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24600, 0x2467f, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24680, 0x247ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24800, 0x249ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24a00, 0x24a7f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24a80, 0x24dff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24e00, 0x24fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x25000, 0x3ffff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x40000, 0x1bffff, 0),
-	GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
-	GEN_FW_RANGE(0x1c4000, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),
-	GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1c0000, 0x1c2bff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c2c00, 0x1c3eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1c3f00, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c4000, 0x1c6bff, FORCEWAKE_MEDIA_VDBOX1),
+	GEN_FW_RANGE(0x1c6c00, 0x1c7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1c7f00, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),
+	GEN_FW_RANGE(0x1c8000, 0x1ca0ff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1ca100, 0x1cbeff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1cbf00, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
 	GEN_FW_RANGE(0x1cc000, 0x1cffff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x1d0000, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
-	GEN_FW_RANGE(0x1d4000, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
-	GEN_FW_RANGE(0x1d8000, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)
+	GEN_FW_RANGE(0x1d0000, 0x1d2bff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d2c00, 0x1d3eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1d3f00, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d4000, 0x1d6bff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d6c00, 0x1d7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1d7f00, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d8000, 0x1da0ff, FORCEWAKE_MEDIA_VEBOX1),
+	GEN_FW_RANGE(0x1da100, 0x1dbeff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1dbf00, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)
 };
 
 /* *Must* be sorted by offset ranges! See intel_fw_table_check(). */
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/icl: Update forcewake firmware ranges

== Series Details ==

== Series Details ==

Series: drm/i915/icl: Update forcewake firmware ranges
URL : https://patchwork.freedesktop.org/series/75864/
State : warning

== Summary ==

$ make htmldocs 2>&1 > /dev/null | grep i915
/home/cidrm/kernel/Documentation/gpu/i915.rst:610: WARNING: duplicate label gpu/i915:layout, other instance in /home/cidrm/kernel/Documentation/gpu/i915.rst

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Update forcewake firmware ranges

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: drm/i915/icl: Update forcewake firmware ranges
URL : https://patchwork.freedesktop.org/series/75864/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8295 -> Patchwork_17286
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/index.html

Known issues
------------

Here are the changes found in Patchwork_17286 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-skl-6600u: [INCOMPLETE][1] ([i915#69]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/fi-skl-6600u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/fi-skl-6600u/igt@[email protected]

[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69

Participating hosts (49 -> 44)
------------------------------

Missing (5): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_8295 -> Patchwork_17286

CI-20190529: 20190529
CI_DRM_8295: 4cb6dbe0a641129fd07ad1fbfcd6e7b4f03ec5c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5589: 31962324ac86f029e2841e56e97c42cf9d572956 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17286: 74cf7649142c5062a5d48b302e4c210b154d2f94 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

74cf7649142c drm/i915/icl: Update forcewake firmware ranges

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to Radhakrishna Sripada
Quoted 5 lines · Radhakrishna Sripada

Some workarounds are not sticking across suspend resume cycles. The forcewake ranges table has been updated and would reflect the hardware appropriately.

It's unfortunate that they still haven't updated the bspec for this yet. A few comments below based on my understanding of the document we received from the hardware team.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = {

Quoted 12 lines
---
 drivers/gpu/drm/i915/intel_uncore.c | 55 +++++++++++++++++++++--------
 1 file changed, 41 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/intel_uncore.c +0 -0
index fa86b7ab2d99..c0e21697a44c 100644
@@ -1098,32 +1098,59 @@ static const struct intel_forcewake_range __gen11_fw_ranges[] = {

Looks like the first range in this table (0x0 - 0xaff) needs to be changed to '0' (or rather combined with the following entry for a combined 0x0 - 0x1fff range set to '0')

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1102

Quoted 6 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -1
 	GEN_FW_RANGE(0x2700, 0x2fff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x3000, 0x3fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x4000, 0x51ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x5200, 0x7fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5200, 0x53ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5400, 0x54ff, FORCEWAKE_BLITTER),

In the version of the document I'm looking at, the wake target for this entry is blank, which usually means no wake target is required. AFAICS, no registers actually fall in this range on gen11, so I'd either set this to '0' to explicitly match the document, or just leave it combined with the two surrounding render ranges for simplicity (and smaller table size).

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1110

Quoted 9 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -1
+	GEN_FW_RANGE(0x5500, 0x7fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8000, 0x813f, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8140, 0x815f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8160, 0x82ff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8300, 0x84ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8500, 0x8bff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8500, 0x87ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8800, 0x883f, 0),
+	GEN_FW_RANGE(0x8840, 0x8bff, FORCEWAKE_BLITTER),

I see 0x8840 - 0x8bff as a reserved range with no forcewake target so we should be able to combine it with the range before it.

Quoted 13 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
 	GEN_FW_RANGE(0x8c00, 0x8cff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8d00, 0x93ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x9400, 0x97ff, FORCEWAKE_ALL),
-	GEN_FW_RANGE(0x9800, 0xafff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8d00, 0x94cf, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x94d0, 0x955f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x9560, 0x95ff, 0),
+	GEN_FW_RANGE(0x9600, 0xafff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xb000, 0xb47f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xb480, 0xdeff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xdf00, 0xe8ff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xe900, 0x16dff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x16e00, 0x19fff, FORCEWAKE_RENDER),

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1127

Quoted 10 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -3
-	GEN_FW_RANGE(0x1a000, 0x243ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x24400, 0x247ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x24800, 0x3ffff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1a000, 0x23fff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24000, 0x2407f, 0),
+	GEN_FW_RANGE(0x24080, 0x2417f, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24180, 0x242ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24300, 0x243ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24400, 0x245ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24600, 0x2467f, FORCEWAKE_BLITTER),

This one is a reserved range with no registers, so we can just squash it into the two render ranges on either side of it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1129

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24680, 0x247ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24800, 0x249ff, FORCEWAKE_BLITTER),

Also reserved with no registers.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1131

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24a00, 0x24a7f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24a80, 0x24dff, FORCEWAKE_BLITTER),

Also reserved with no registers.

So I think we should be able to have just use one render range that runs from 0x24400 - 0x24fff.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1136

Quoted 8 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
+	GEN_FW_RANGE(0x24e00, 0x24fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x25000, 0x3ffff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x40000, 0x1bffff, 0),
-	GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
-	GEN_FW_RANGE(0x1c4000, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),
-	GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1c0000, 0x1c2bff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c2c00, 0x1c3eff, FORCEWAKE_BLITTER),

This is another reserved range that can be combined into the ranges around it (0x1c0000 - 0x1c3fff).

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1140

Quoted 4 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -0
+	GEN_FW_RANGE(0x1c3f00, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c4000, 0x1c6bff, FORCEWAKE_MEDIA_VDBOX1),
+	GEN_FW_RANGE(0x1c6c00, 0x1c7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1c7f00, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),

0x1c4000 - 0x1c7fff are reserved for vdbox1, but that doesn't exist on this platform (we only have vdbox0 and vdbox2 on ICL and only vdbox0 on EHL/JSL). So the three entries above should be combined into a single range with target '0' here.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1142

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x1c8000, 0x1ca0ff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1ca100, 0x1cbeff, FORCEWAKE_BLITTER),

Another reserved range; can squash with the two surrounding ranges.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1144

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +1 -0
+	GEN_FW_RANGE(0x1cbf00, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
 	GEN_FW_RANGE(0x1cc000, 0x1cffff, FORCEWAKE_BLITTER),

Another reserved range. Either set to 0 or combine with one of the ranges before/after it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1146

Quoted 5 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -3
-	GEN_FW_RANGE(0x1d0000, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
-	GEN_FW_RANGE(0x1d4000, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
-	GEN_FW_RANGE(0x1d8000, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)
+	GEN_FW_RANGE(0x1d0000, 0x1d2bff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d2c00, 0x1d3eff, FORCEWAKE_BLITTER),

Reserved range; can squash with ranges around it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1153

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -0
+	GEN_FW_RANGE(0x1d3f00, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d4000, 0x1d6bff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d6c00, 0x1d7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1d7f00, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d8000, 0x1da0ff, FORCEWAKE_MEDIA_VEBOX1),
+	GEN_FW_RANGE(0x1da100, 0x1dbeff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1dbf00, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)

As noted above, gen11 doesn't have vdbox1 or vdbox3, so these entries should just be set to '0' (including the reserved ranges that you have listed as blitter right now).

Quoted 6 lines
drivers/gpu/drm/i915/intel_uncore.c +0 -0
 };
 
 /* *Must* be sorted by offset ranges! See intel_fw_table_check(). */
Signature · 1 line
2.20.1
Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw

Hi Matt,

Quoted 26 lines

-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: Tuesday, April 14, 2020 11:40 AM
To: Sripada, Radhakrishna <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] drm/i915/icl: Update forcewake firmware ranges

Quoted 5 lines · Radhakrishna Sripada

Some workarounds are not sticking across suspend resume cycles. The forcewake ranges table has been updated and would reflect the hardware appropriately.

It's unfortunate that they still haven't updated the bspec for this yet. A few comments below based on my understanding of the document we received from the hardware team.

Quoted 8 lines
---
 drivers/gpu/drm/i915/intel_uncore.c | 55
+++++++++++++++++++++--------
 1 file changed, 41 insertions(+), 14 deletions(-)
Quoted 11 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range · line 1098

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +0 -0
index fa86b7ab2d99..c0e21697a44c 100644
@@ -1098,32 +1098,59 @@ static const struct intel_forcewake_range
 __gen11_fw_ranges[] = {

Looks like the first range in this table (0x0 - 0xaff) needs to be changed to '0' (or rather combined with the following entry for a combined 0x0 - 0x1fff range set to '0')

Comparing with previous gens, my understanding is the '0' is indicative of uncore range Of registers. The reserved ranges are marked with "Blitter" force wake range. Am I in the right Path making that assumption? Hence made all the subsequent changes according to the assumption.

Thanks,
Radhakrishna(RK) Sripada

Quoted 128 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1102

Quoted 8 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -1
 	GEN_FW_RANGE(0x2700, 0x2fff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x3000, 0x3fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x4000, 0x51ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x5200, 0x7fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5200, 0x53ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5400, 0x54ff, FORCEWAKE_BLITTER),

In the version of the document I'm looking at, the wake target for this entry is blank, which usually means no wake target is required. AFAICS, no registers actually fall in this range on gen11, so I'd either set this to '0' to explicitly match the document, or just leave it combined with the two surrounding render ranges for simplicity (and smaller table size).

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1110

Quoted 9 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -1
+	GEN_FW_RANGE(0x5500, 0x7fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8000, 0x813f, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8140, 0x815f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8160, 0x82ff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8300, 0x84ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8500, 0x8bff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8500, 0x87ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8800, 0x883f, 0),
+	GEN_FW_RANGE(0x8840, 0x8bff, FORCEWAKE_BLITTER),

I see 0x8840 - 0x8bff as a reserved range with no forcewake target so we should be able to combine it with the range before it.

Quoted 13 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
 	GEN_FW_RANGE(0x8c00, 0x8cff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8d00, 0x93ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x9400, 0x97ff, FORCEWAKE_ALL),
-	GEN_FW_RANGE(0x9800, 0xafff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8d00, 0x94cf, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x94d0, 0x955f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x9560, 0x95ff, 0),
+	GEN_FW_RANGE(0x9600, 0xafff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xb000, 0xb47f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xb480, 0xdeff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xdf00, 0xe8ff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xe900, 0x16dff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x16e00, 0x19fff, FORCEWAKE_RENDER),

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1127

Quoted 10 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -3
-	GEN_FW_RANGE(0x1a000, 0x243ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x24400, 0x247ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x24800, 0x3ffff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1a000, 0x23fff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24000, 0x2407f, 0),
+	GEN_FW_RANGE(0x24080, 0x2417f, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24180, 0x242ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24300, 0x243ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24400, 0x245ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24600, 0x2467f, FORCEWAKE_BLITTER),

This one is a reserved range with no registers, so we can just squash it into the two render ranges on either side of it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1129

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24680, 0x247ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24800, 0x249ff, FORCEWAKE_BLITTER),

Also reserved with no registers.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1131

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24a00, 0x24a7f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24a80, 0x24dff, FORCEWAKE_BLITTER),

Also reserved with no registers.

So I think we should be able to have just use one render range that runs from 0x24400 - 0x24fff.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1136

Quoted 8 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
+	GEN_FW_RANGE(0x24e00, 0x24fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x25000, 0x3ffff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x40000, 0x1bffff, 0),
-	GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
-	GEN_FW_RANGE(0x1c4000, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),
-	GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1c0000, 0x1c2bff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c2c00, 0x1c3eff, FORCEWAKE_BLITTER),

This is another reserved range that can be combined into the ranges around it (0x1c0000 - 0x1c3fff).

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1140

Quoted 4 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -0
+	GEN_FW_RANGE(0x1c3f00, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c4000, 0x1c6bff, FORCEWAKE_MEDIA_VDBOX1),
+	GEN_FW_RANGE(0x1c6c00, 0x1c7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1c7f00, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),

0x1c4000 - 0x1c7fff are reserved for vdbox1, but that doesn't exist on this platform (we only have vdbox0 and vdbox2 on ICL and only vdbox0 on EHL/JSL). So the three entries above should be combined into a single range with target '0' here.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1142

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x1c8000, 0x1ca0ff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1ca100, 0x1cbeff, FORCEWAKE_BLITTER),

Another reserved range; can squash with the two surrounding ranges.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1144

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +1 -0
+	GEN_FW_RANGE(0x1cbf00, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
 	GEN_FW_RANGE(0x1cc000, 0x1cffff, FORCEWAKE_BLITTER),

Another reserved range. Either set to 0 or combine with one of the ranges before/after it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1146

Quoted 5 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -3
-	GEN_FW_RANGE(0x1d0000, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
-	GEN_FW_RANGE(0x1d4000, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
-	GEN_FW_RANGE(0x1d8000, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)
+	GEN_FW_RANGE(0x1d0000, 0x1d2bff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d2c00, 0x1d3eff, FORCEWAKE_BLITTER),

Reserved range; can squash with ranges around it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1153

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -0
+	GEN_FW_RANGE(0x1d3f00, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d4000, 0x1d6bff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d6c00, 0x1d7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1d7f00, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d8000, 0x1da0ff, FORCEWAKE_MEDIA_VEBOX1),
+	GEN_FW_RANGE(0x1da100, 0x1dbeff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1dbf00, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)

As noted above, gen11 doesn't have vdbox1 or vdbox3, so these entries should just be set to '0' (including the reserved ranges that you have listed as blitter right now).

Quoted 6 lines
drivers/gpu/drm/i915/intel_uncore.c +0 -0
 };
 

/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */
--
2.20.1

Quoted 6 lines

--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 40 lines · Radhakrishna

Hi Matt,

Quoted 26 lines

-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: Tuesday, April 14, 2020 11:40 AM
To: Sripada, Radhakrishna <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] drm/i915/icl: Update forcewake firmware ranges

Quoted 5 lines · Radhakrishna Sripada

Some workarounds are not sticking across suspend resume cycles. The forcewake ranges table has been updated and would reflect the hardware appropriately.

It's unfortunate that they still haven't updated the bspec for this yet. A few comments below based on my understanding of the document we received from the hardware team.

Quoted 8 lines
---
 drivers/gpu/drm/i915/intel_uncore.c | 55
+++++++++++++++++++++--------
 1 file changed, 41 insertions(+), 14 deletions(-)
Quoted 11 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range · line 1098

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +0 -0
index fa86b7ab2d99..c0e21697a44c 100644
@@ -1098,32 +1098,59 @@ static const struct intel_forcewake_range
 __gen11_fw_ranges[] = {

Looks like the first range in this table (0x0 - 0xaff) needs to be changed to '0' (or rather combined with the following entry for a combined 0x0 - 0x1fff range set to '0')

Quoted 3 lines

Comparing with previous gens, my understanding is the '0' is indicative of uncore range Of registers. The reserved ranges are marked with "Blitter" force wake range. Am I in the right Path making that assumption? Hence made all the subsequent changes according to the assumption.

The final parameter of GEN_FW_RANGE() is a bitmask of domains that we need to make sure are powered up when we're going to access a register in that range. So a 0 means no domains need to be powered up for registers in that range. That might be because it's a range that contains no registers at all (reserved range), or it may be that the registers in that range simply aren't part of the blitter, render, media, etc. power wells and we don't have to worry about powering anything up.

In cases where there are no actual registers (i.e., reserved ranges), it doesn't really matter what you put since there shouldn't be any register reads/writes in that range. So for those we'll often combine them with one of the surrounding ranges just to keep the overall forcewake table smaller and make lookups faster.

Matt

Quoted 137 lines

Thanks,
Radhakrishna(RK) Sripada

Quoted 134 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1102

Quoted 8 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -1
 	GEN_FW_RANGE(0x2700, 0x2fff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x3000, 0x3fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x4000, 0x51ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x5200, 0x7fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5200, 0x53ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5400, 0x54ff, FORCEWAKE_BLITTER),

In the version of the document I'm looking at, the wake target for this entry is blank, which usually means no wake target is required. AFAICS, no registers actually fall in this range on gen11, so I'd either set this to '0' to explicitly match the document, or just leave it combined with the two surrounding render ranges for simplicity (and smaller table size).

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1110

Quoted 9 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -1
+	GEN_FW_RANGE(0x5500, 0x7fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8000, 0x813f, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8140, 0x815f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8160, 0x82ff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8300, 0x84ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8500, 0x8bff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8500, 0x87ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8800, 0x883f, 0),
+	GEN_FW_RANGE(0x8840, 0x8bff, FORCEWAKE_BLITTER),

I see 0x8840 - 0x8bff as a reserved range with no forcewake target so we should be able to combine it with the range before it.

Quoted 13 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
 	GEN_FW_RANGE(0x8c00, 0x8cff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8d00, 0x93ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x9400, 0x97ff, FORCEWAKE_ALL),
-	GEN_FW_RANGE(0x9800, 0xafff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8d00, 0x94cf, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x94d0, 0x955f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x9560, 0x95ff, 0),
+	GEN_FW_RANGE(0x9600, 0xafff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xb000, 0xb47f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xb480, 0xdeff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xdf00, 0xe8ff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xe900, 0x16dff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x16e00, 0x19fff, FORCEWAKE_RENDER),

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1127

Quoted 10 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -3
-	GEN_FW_RANGE(0x1a000, 0x243ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x24400, 0x247ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x24800, 0x3ffff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1a000, 0x23fff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24000, 0x2407f, 0),
+	GEN_FW_RANGE(0x24080, 0x2417f, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24180, 0x242ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24300, 0x243ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24400, 0x245ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24600, 0x2467f, FORCEWAKE_BLITTER),

This one is a reserved range with no registers, so we can just squash it into the two render ranges on either side of it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1129

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24680, 0x247ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24800, 0x249ff, FORCEWAKE_BLITTER),

Also reserved with no registers.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1131

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24a00, 0x24a7f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24a80, 0x24dff, FORCEWAKE_BLITTER),

Also reserved with no registers.

So I think we should be able to have just use one render range that runs from 0x24400 - 0x24fff.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1136

Quoted 8 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
+	GEN_FW_RANGE(0x24e00, 0x24fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x25000, 0x3ffff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x40000, 0x1bffff, 0),
-	GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
-	GEN_FW_RANGE(0x1c4000, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),
-	GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1c0000, 0x1c2bff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c2c00, 0x1c3eff, FORCEWAKE_BLITTER),

This is another reserved range that can be combined into the ranges around it (0x1c0000 - 0x1c3fff).

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1140

Quoted 4 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -0
+	GEN_FW_RANGE(0x1c3f00, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c4000, 0x1c6bff, FORCEWAKE_MEDIA_VDBOX1),
+	GEN_FW_RANGE(0x1c6c00, 0x1c7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1c7f00, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),

0x1c4000 - 0x1c7fff are reserved for vdbox1, but that doesn't exist on this platform (we only have vdbox0 and vdbox2 on ICL and only vdbox0 on EHL/JSL). So the three entries above should be combined into a single range with target '0' here.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1142

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x1c8000, 0x1ca0ff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1ca100, 0x1cbeff, FORCEWAKE_BLITTER),

Another reserved range; can squash with the two surrounding ranges.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1144

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +1 -0
+	GEN_FW_RANGE(0x1cbf00, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
 	GEN_FW_RANGE(0x1cc000, 0x1cffff, FORCEWAKE_BLITTER),

Another reserved range. Either set to 0 or combine with one of the ranges before/after it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1146

Quoted 5 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -3
-	GEN_FW_RANGE(0x1d0000, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
-	GEN_FW_RANGE(0x1d4000, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
-	GEN_FW_RANGE(0x1d8000, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)
+	GEN_FW_RANGE(0x1d0000, 0x1d2bff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d2c00, 0x1d3eff, FORCEWAKE_BLITTER),

Reserved range; can squash with ranges around it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1153

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -0
+	GEN_FW_RANGE(0x1d3f00, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d4000, 0x1d6bff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d6c00, 0x1d7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1d7f00, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d8000, 0x1da0ff, FORCEWAKE_MEDIA_VEBOX1),
+	GEN_FW_RANGE(0x1da100, 0x1dbeff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1dbf00, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)

As noted above, gen11 doesn't have vdbox1 or vdbox3, so these entries should just be set to '0' (including the reserved ranges that you have listed as blitter right now).

Quoted 6 lines
drivers/gpu/drm/i915/intel_uncore.c +0 -0
 };
 

/* *Must* be sorted by offset ranges! See intel_fw_table_check(). */
--
2.20.1

--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795

Signature · 9 lines
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#6 lore raw
Quoted 65 lines

-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: Wednesday, April 15, 2020 7:52 AM
To: Sripada, Radhakrishna <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] drm/i915/icl: Update forcewake firmware ranges

Quoted 41 lines · Radhakrishna

Hi Matt,

Quoted 27 lines

-----Original Message-----
From: Roper, Matthew D <[email protected]>
Sent: Tuesday, April 14, 2020 11:40 AM
To: Sripada, Radhakrishna <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] drm/i915/icl: Update forcewake firmware ranges

Quoted 5 lines · Radhakrishna Sripada

Some workarounds are not sticking across suspend resume cycles. The forcewake ranges table has been updated and would reflect the hardware appropriately.

It's unfortunate that they still haven't updated the bspec for this yet. A few comments below based on my understanding of the document we received from the hardware team.

Quoted 9 lines

Cc: Matt Roper <[email protected]>
Signed-off-by: Radhakrishna Sripada
<[email protected]>

---
 drivers/gpu/drm/i915/intel_uncore.c | 55
+++++++++++++++++++++--------
 1 file changed, 41 insertions(+), 14 deletions(-)
Quoted 11 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range · line 1098

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +0 -0
index fa86b7ab2d99..c0e21697a44c 100644
@@ -1098,32 +1098,59 @@ static const struct intel_forcewake_range
 __gen11_fw_ranges[] = {

Looks like the first range in this table (0x0 - 0xaff) needs to be changed to '0' (or rather combined with the following entry for a combined 0x0 - 0x1fff range set to '0')

Quoted 3 lines

Comparing with previous gens, my understanding is the '0' is indicative of uncore range Of registers. The reserved ranges are marked with "Blitter" force wake range. Am I in the right Path making that

assumption? Hence made all the subsequent changes according to the assumption.

The final parameter of GEN_FW_RANGE() is a bitmask of domains that we need to make sure are powered up when we're going to access a register in that range. So a 0 means no domains need to be powered up for registers in that range. That might be because it's a range that contains no registers at all (reserved range), or it may be that the registers in that range simply aren't part of the blitter, render, media, etc. power wells and we don't have to worry about powering anything up.

Quoted 5 lines

In cases where there are no actual registers (i.e., reserved ranges), it doesn't really matter what you put since there shouldn't be any register reads/writes in that range. So for those we'll often combine them with one of the surrounding ranges just to keep the overall forcewake table smaller and make lookups faster.

Thank you for the explanation Matt. I will update the patch and send the next version.

- RK

Quoted 147 lines

Matt

Quoted 17 lines

Thanks,
Radhakrishna(RK) Sripada

Quoted 14 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1102

Quoted 8 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -1
 	GEN_FW_RANGE(0x2700, 0x2fff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x3000, 0x3fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x4000, 0x51ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x5200, 0x7fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5200, 0x53ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x5400, 0x54ff, FORCEWAKE_BLITTER),

In the version of the document I'm looking at, the wake target for this entry is blank, which usually means no wake target is required. AFAICS, no registers actually fall in this range on gen11, so I'd either set this to '0' to explicitly match the document, or just leave it combined with the two surrounding render ranges for simplicity (and

smaller table size).

Quoted 68 lines
Quoted 68 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1110

Quoted 10 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -1
+	GEN_FW_RANGE(0x5500, 0x7fff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8000, 0x813f, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8140, 0x815f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0x8160, 0x82ff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x8300, 0x84ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8500, 0x8bff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8500, 0x87ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8800, 0x883f, 0),
+	GEN_FW_RANGE(0x8840, 0x8bff, FORCEWAKE_BLITTER),

I see 0x8840 - 0x8bff as a reserved range with no forcewake target so we should be able to combine it with the range before it.

Quoted 13 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
 	GEN_FW_RANGE(0x8c00, 0x8cff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x8d00, 0x93ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x9400, 0x97ff, FORCEWAKE_ALL),
-	GEN_FW_RANGE(0x9800, 0xafff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x8d00, 0x94cf, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x94d0, 0x955f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x9560, 0x95ff, 0),
+	GEN_FW_RANGE(0x9600, 0xafff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xb000, 0xb47f, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xb480, 0xdeff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0xdf00, 0xe8ff, FORCEWAKE_RENDER),
 	GEN_FW_RANGE(0xe900, 0x16dff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x16e00, 0x19fff, FORCEWAKE_RENDER),

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1127

Quoted 10 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -3
-	GEN_FW_RANGE(0x1a000, 0x243ff, FORCEWAKE_BLITTER),
-	GEN_FW_RANGE(0x24400, 0x247ff, FORCEWAKE_RENDER),
-	GEN_FW_RANGE(0x24800, 0x3ffff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1a000, 0x23fff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24000, 0x2407f, 0),
+	GEN_FW_RANGE(0x24080, 0x2417f, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24180, 0x242ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24300, 0x243ff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x24400, 0x245ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24600, 0x2467f, FORCEWAKE_BLITTER),

This one is a reserved range with no registers, so we can just squash it into the two render ranges on either side of it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1129

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24680, 0x247ff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24800, 0x249ff, FORCEWAKE_BLITTER),

Also reserved with no registers.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1131

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x24a00, 0x24a7f, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x24a80, 0x24dff, FORCEWAKE_BLITTER),

Also reserved with no registers.

So I think we should be able to have just use one render range that runs from
0x24400 - 0x24fff.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1136

Quoted 8 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -3
+	GEN_FW_RANGE(0x24e00, 0x24fff, FORCEWAKE_RENDER),
+	GEN_FW_RANGE(0x25000, 0x3ffff, FORCEWAKE_BLITTER),
 	GEN_FW_RANGE(0x40000, 0x1bffff, 0),
-	GEN_FW_RANGE(0x1c0000, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
-	GEN_FW_RANGE(0x1c4000, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),
-	GEN_FW_RANGE(0x1c8000, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1c0000, 0x1c2bff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c2c00, 0x1c3eff, FORCEWAKE_BLITTER),

This is another reserved range that can be combined into the ranges around it
(0x1c0000 - 0x1c3fff).

Quoted 7 lines
Quoted 7 lines

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1140

Quoted 4 lines
drivers/gpu/drm/i915/intel_uncore.c +4 -0
+	GEN_FW_RANGE(0x1c3f00, 0x1c3fff, FORCEWAKE_MEDIA_VDBOX0),
+	GEN_FW_RANGE(0x1c4000, 0x1c6bff, FORCEWAKE_MEDIA_VDBOX1),
+	GEN_FW_RANGE(0x1c6c00, 0x1c7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1c7f00, 0x1c7fff, FORCEWAKE_MEDIA_VDBOX1),

0x1c4000 - 0x1c7fff are reserved for vdbox1, but that doesn't exist on this platform (we only have vdbox0 and vdbox2 on ICL and only vdbox0

on EHL/JSL).

Quoted 1 line
Quoted 1 line

So the three entries above should be combined into a single range with

target '0'

Quoted 41 lines
Quoted 41 lines

here.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1142

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -0
+	GEN_FW_RANGE(0x1c8000, 0x1ca0ff, FORCEWAKE_MEDIA_VEBOX0),
+	GEN_FW_RANGE(0x1ca100, 0x1cbeff, FORCEWAKE_BLITTER),

Another reserved range; can squash with the two surrounding ranges.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1144

Quoted 2 lines
drivers/gpu/drm/i915/intel_uncore.c +1 -0
+	GEN_FW_RANGE(0x1cbf00, 0x1cbfff, FORCEWAKE_MEDIA_VEBOX0),
 	GEN_FW_RANGE(0x1cc000, 0x1cffff, FORCEWAKE_BLITTER),

Another reserved range. Either set to 0 or combine with one of the ranges before/after it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1146

Quoted 5 lines
drivers/gpu/drm/i915/intel_uncore.c +2 -3
-	GEN_FW_RANGE(0x1d0000, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
-	GEN_FW_RANGE(0x1d4000, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
-	GEN_FW_RANGE(0x1d8000, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)
+	GEN_FW_RANGE(0x1d0000, 0x1d2bff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d2c00, 0x1d3eff, FORCEWAKE_BLITTER),

Reserved range; can squash with ranges around it.

drivers/gpu/drm/i915/intel_uncore.c static const struct intel_forcewake_range __gen11_fw_ranges[] = { · line 1153

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +7 -0
+	GEN_FW_RANGE(0x1d3f00, 0x1d3fff, FORCEWAKE_MEDIA_VDBOX2),
+	GEN_FW_RANGE(0x1d4000, 0x1d6bff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d6c00, 0x1d7eff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1d7f00, 0x1d7fff, FORCEWAKE_MEDIA_VDBOX3),
+	GEN_FW_RANGE(0x1d8000, 0x1da0ff, FORCEWAKE_MEDIA_VEBOX1),
+	GEN_FW_RANGE(0x1da100, 0x1dbeff, FORCEWAKE_BLITTER),
+	GEN_FW_RANGE(0x1dbf00, 0x1dbfff, FORCEWAKE_MEDIA_VEBOX1)

As noted above, gen11 doesn't have vdbox1 or vdbox3, so these entries should just be set to '0' (including the reserved ranges that you have listed as blitter right now).

Quoted 7 lines
drivers/gpu/drm/i915/intel_uncore.c +0 -0
 };
 

/* *Must* be sorted by offset ranges! See intel_fw_table_check().
*/
--
2.20.1

Quoted 6 lines
Quoted 6 lines

--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795

Quoted 6 lines

--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Update forcewake firmware ranges

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: drm/i915/icl: Update forcewake firmware ranges
URL : https://patchwork.freedesktop.org/series/75864/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8295_full -> Patchwork_17286_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_17286_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-iclb7/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-snb: [PASS][3] -> [FAIL][4] ([i915#1066])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-snb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-snb1/igt@[email protected]

* igt@i915_selftest@live@requests:
- shard-tglb: [PASS][5] -> [INCOMPLETE][6] ([i915#1531] / [i915#1658])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-tglb8/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-tglb8/igt@i915_selftest@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-kbl7/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-kbl1/igt@[email protected]

* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#109349])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-iclb2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-iclb1/igt@[email protected]

* igt@kms_flip@wf_vblank-ts-check-interruptible:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#34]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-skl6/igt@kms_flip@wf_vblank-ts-check-interruptible.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-skl7/igt@kms_flip@wf_vblank-ts-check-interruptible.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-move:
- shard-tglb: [PASS][13] -> [SKIP][14] ([i915#668]) +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-tglb6/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-tglb6/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-apl6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-apl1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [PASS][17] -> [DMESG-WARN][18] ([i915#180] / [i915#93] / [i915#95])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-kbl1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][19] -> [FAIL][20] ([fdo#108145] / [i915#265]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-skl10/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-skl4/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][21] -> [SKIP][22] ([fdo#109642] / [fdo#111068])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-iclb2/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-iclb1/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html

* igt@kms_setmode@basic:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#31])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-glk8/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-glk2/igt@[email protected]

#### Possible fixes ####

* igt@gem_softpin@noreloc-s3:
- shard-apl: [DMESG-WARN][27] ([i915#180]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-apl4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-apl1/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-skl: [DMESG-WARN][29] ([i915#716]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-skl4/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-skl8/igt@[email protected]
- shard-apl: [DMESG-WARN][31] ([i915#716]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-apl6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-apl3/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][33] ([i915#454]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-iclb6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-iclb5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-skl: [INCOMPLETE][35] ([i915#221]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-skl1/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-skl9/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][37] ([i915#180]) -> [PASS][38] +4 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-kbl7/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-kbl3/igt@[email protected]

* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][39] ([fdo#109441]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-iclb7/igt@kms_psr@psr2_suspend.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-iclb2/igt@kms_psr@psr2_suspend.html

#### Warnings ####

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [FAIL][41] ([i915#93] / [i915#95]) -> [DMESG-FAIL][42] ([i915#180] / [i915#95])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-kbl4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-kbl2/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-apl: [FAIL][43] ([fdo#108145] / [i915#265] / [i915#95]) -> [FAIL][44] ([fdo#108145] / [i915#265]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-apl2/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: [FAIL][45] ([fdo#108145] / [i915#265]) -> [FAIL][46] ([fdo#108145] / [i915#265] / [i915#95])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-apl2/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-apl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: [FAIL][47] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [FAIL][48] ([fdo#108145] / [i915#265])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-kbl3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-kbl4/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][49], [FAIL][50]) ([i915#1423] / [i915#716]) -> [FAIL][51] ([i915#1423])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-apl6/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8295/shard-apl6/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/shard-apl1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1066]: https://gitlab.freedesktop.org/drm/intel/issues/1066
[i915#1423]: https://gitlab.freedesktop.org/drm/intel/issues/1423
[i915#1531]: https://gitlab.freedesktop.org/drm/intel/issues/1531
[i915#1658]: https://gitlab.freedesktop.org/drm/intel/issues/1658
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95

Participating hosts (10 -> 10)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_8295 -> Patchwork_17286

CI-20190529: 20190529
CI_DRM_8295: 4cb6dbe0a641129fd07ad1fbfcd6e7b4f03ec5c1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5589: 31962324ac86f029e2841e56e97c42cf9d572956 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17286: 74cf7649142c5062a5d48b302e4c210b154d2f94 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17286/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx