Skip to contentSkip to conversation

pinctrl: qcom: fix wrong write in update_dual_edge

PATCH In review Ansuel Smith 3 participants 3 messages Apr 14, 2020 – Apr 16, 2020

Subsystems (5)
Arm Qualcomm mailing list GPIO Pin control Pin controller - Qualcomm +1 more subsystems
lore
Share & tools
lore

Ansuel Smith

author
#0 lore raw

PATCH 1/1 pinctrl: qcom: fix wrong write in update_dual_edge

Fix a typo in the readl/writel accessor conversion where val is used instead of pol changing the behavior of the original code.

Fixes 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
Signed-off-by Ansuel Smith <[email protected]>
---
 drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/pinctrl-msm.c +1 -1
index 1a948c3f54b7..9f1c9951949e 100644
@@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl,
 
 		pol = msm_readl_intr_cfg(pctrl, g);
 		pol ^= BIT(g->intr_polarity_bit);
-		msm_writel_intr_cfg(val, pctrl, g);
+		msm_writel_intr_cfg(pol, pctrl, g);
 
 		val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit);
 		intstat = msm_readl_intr_status(pctrl, g);
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Ansuel Smith

Fix a typo in the readl/writel accessor conversion where val is used instead of pol changing the behavior of the original code.

Fixes 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
Signed-off-by Ansuel Smith <[email protected]>

Thank you Ansuel

Reviewed-by Bjorn Andersson <[email protected]>

Linus, when you apply this please add
Cc: [email protected]

Thanks,
Bjorn

Quoted 20 lines
---
 drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/qcom/pinctrl-msm.c +1 -1
index 1a948c3f54b7..9f1c9951949e 100644
@@ -692,7 +692,7 @@ static void msm_gpio_update_dual_edge_pos(struct msm_pinctrl *pctrl,
 
 		pol = msm_readl_intr_cfg(pctrl, g);
 		pol ^= BIT(g->intr_polarity_bit);
-		msm_writel_intr_cfg(val, pctrl, g);
+		msm_writel_intr_cfg(pol, pctrl, g);
 
 		val2 = msm_readl_io(pctrl, g) & BIT(g->in_bit);
 		intstat = msm_readl_intr_status(pctrl, g);
Signature · 1 line
2.25.1
#2 lore raw
In reply to Ansuel Smith
Quoted 6 lines · Ansuel Smith

Fix a typo in the readl/writel accessor conversion where val is used instead of pol changing the behavior of the original code.

Fixes 6c73698904aa pinctrl: qcom: Introduce readl/writel accessors
Signed-off-by Ansuel Smith <[email protected]>

Patch applied for fixes and tagged for stable with Bjorn's ACK.

Yours,
Linus Walleij