Skip to contentSkip to conversation

kvm: nVMX: match comment with return type for nested_vmx_exit_reflected

PATCH Applied Oliver Upton 2 participants 2 messages Apr 14, 2020 – Apr 15, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: nVMX: match comment with return type for nested_vmx_exit_reflected

nested_vmx_exit_reflected() returns a bool, not int. As such, refer to the return values as true/false in the comment instead of 1/0.

---
 arch/x86/kvm/vmx/nested.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/vmx/nested.c +1 -1
index cbc9ea2de28f9..2ca53dc362731 100644
@@ -5534,7 +5534,7 @@ static bool nested_vmx_exit_handled_vmcs_access(struct kvm_vcpu *vcpu,
 }
 
 /*
- * Return 1 if we should exit from L2 to L1 to handle an exit, or 0 if we
+ * Return true if we should exit from L2 to L1 to handle an exit, or false if we
  * should handle it ourselves in L0 (and then continue L2). Only call this
  * when in is_guest_mode (L2).
  */
Signature · 1 line
2.26.0.110.g2183baf09c-goog
maintainer Applied
#1 lore raw
Quoted 14 lines · Oliver Upton

nested_vmx_exit_reflected() returns a bool, not int. As such, refer to the return values as true/false in the comment instead of 1/0.

---
 arch/x86/kvm/vmx/nested.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/vmx/nested.c +0 -0
index cbc9ea2de28f9..2ca53dc362731 100644

arch/x86/kvm/vmx/nested.c static bool nested_vmx_exit_handled_vmcs_access(struct kvm_vcpu *vcpu, · line 5540

Quoted 8 lines
arch/x86/kvm/vmx/nested.c +1 -1
@@ -5534,7 +5534,7 @@ static bool nested_vmx_exit_handled_vmcs_access(struct kvm_vcpu *vcpu,
 }
 
 /*
- * Return 1 if we should exit from L2 to L1 to handle an exit, or 0 if we
+ * Return true if we should exit from L2 to L1 to handle an exit, or false if we
  * should handle it ourselves in L0 (and then continue L2). Only call this
  * when in is_guest_mode (L2).
  */

Queued, thanks.

Paolo