tools/registers/tgl: Fix tigerlake_delta file decode

PATCH In review José Roberto de Souza 3 participants 5 messages Apr 15, 2020 – Apr 16, 2020

lore

Share & tools

lore

José Roberto de Souza

author

2020-04-15 21:22 UTC #0 lore raw

PATCH 1/1 tools/registers/tgl: Fix tigerlake_delta file decode

It was missing a ")" to be properly parsed.

Signed-off-by José Roberto de Souza <[email protected]>

---
 tools/registers/tigerlake_delta.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/registers/tigerlake_delta.txt +1 -1

index e82049b99..c7fc2dc24 100644
@@ -110,7 +110,7 @@
 ('PLANE_COLOR_CTL_5_D', '0x735cc', '')
 ('PLANE_COLOR_CTL_6_D', '0x736cc', '')
 ('PLANE_COLOR_CTL_7_D', '0x737cc', '')
-('PLANE_OFFSET_1_D', '0x731a4', ''
+('PLANE_OFFSET_1_D', '0x731a4', '')
 ('PLANE_OFFSET_2_D', '0x732a4', '')
 ('PLANE_OFFSET_3_D', '0x733a4', '')
 ('PLANE_OFFSET_4_D', '0x734a4', '')

Signature · 6 lines

2.26.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-04-15 21:52 UTC #1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tools/registers/tgl: Fix tigerlake_delta file decode

== Series Details ==

Series: tools/registers/tgl: Fix tigerlake_delta file decode
URL : https://patchwork.freedesktop.org/series/75989/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8303 -> IGTPW_4470
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4470:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@gem_wait@busy@all}:
- fi-hsw-peppy: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/fi-hsw-peppy/igt@gem_wait@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/fi-hsw-peppy/igt@gem_wait@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4470 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-skl-6770hq: [SKIP][3] ([fdo#109271]) -> [PASS][4] +20 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/fi-skl-6770hq/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/fi-skl-6770hq/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271

Participating hosts (52 -> 46)
------------------------------

Missing (6): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5591 -> IGTPW_4470

CI-20190529: 20190529
CI_DRM_8303: b4a7df71d1c1750120242e457c68b4de425977fd @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4470: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/index.html
IGT_5591: f57b7fdbe8d04ce3edf0433a03c7d9d5c3d96680 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Petri Latvala

Reviewed-by on v1 1/1

2020-04-16 07:10 UTC #2 lore raw

In reply to José Roberto de Souza

Quoted 3 lines · José Roberto de Souza

It was missing a ")" to be properly parsed.
Signed-off-by José Roberto de Souza <[email protected]>

Reviewed-by Petri Latvala <[email protected]>

Quoted 24 lines

---
 tools/registers/tigerlake_delta.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/registers/tigerlake_delta.txt +1 -1

index e82049b99..c7fc2dc24 100644
@@ -110,7 +110,7 @@
 ('PLANE_COLOR_CTL_5_D', '0x735cc', '')
 ('PLANE_COLOR_CTL_6_D', '0x736cc', '')
 ('PLANE_COLOR_CTL_7_D', '0x737cc', '')
-('PLANE_OFFSET_1_D', '0x731a4', ''
+('PLANE_OFFSET_1_D', '0x731a4', '')
 ('PLANE_OFFSET_2_D', '0x732a4', '')
 ('PLANE_OFFSET_3_D', '0x733a4', '')
 ('PLANE_OFFSET_4_D', '0x734a4', '')

Signature · 6 lines

2.26.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Souza, Jose

author

2020-04-16 19:13 UTC #3 lore raw

Quoted 7 lines · Petri Latvala

Quoted 3 lines · José Roberto de Souza
It was missing a ")" to be properly parsed.
Signed-off-by José Roberto de Souza <[email protected]>
Reviewed-by Petri Latvala <[email protected]>

Thanks, pushed.

Quoted 23 lines


---
 tools/registers/tigerlake_delta.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/registers/tigerlake_delta.txt +1 -1

index e82049b99..c7fc2dc24 100644
@@ -110,7 +110,7 @@
 ('PLANE_COLOR_CTL_5_D', '0x735cc', '')
 ('PLANE_COLOR_CTL_6_D', '0x736cc', '')
 ('PLANE_COLOR_CTL_7_D', '0x737cc', '')
-('PLANE_OFFSET_1_D', '0x731a4', ''
+('PLANE_OFFSET_1_D', '0x731a4', '')
 ('PLANE_OFFSET_2_D', '0x732a4', '')
 ('PLANE_OFFSET_3_D', '0x733a4', '')
 ('PLANE_OFFSET_4_D', '0x734a4', '')

Signature · 1 line

2.26.1

Quoted 4 lines

Quoted 4 lines
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-04-16 17:55 UTC #4 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tools/registers/tgl: Fix tigerlake_delta file decode

In reply to José Roberto de Souza

== Series Details ==

Series: tools/registers/tgl: Fix tigerlake_delta file decode
URL : https://patchwork.freedesktop.org/series/75989/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8303_full -> IGTPW_4470_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/index.html

New tests
---------

New tests have been introduced between CI_DRM_8303_full and IGTPW_4470_full:

### New IGT tests (2) ###

* igt@kms_flip@dpms-off-confusion-interruptible@d-edp1:
- Statuses : 1 pass(s)
- Exec time: [8.70] s

* igt@kms_flip@dpms-vs-vblank-race-interruptible@d-edp1:
- Statuses : 1 pass(s)
- Exec time: [3.65] s

Known issues
------------

Here are the changes found in IGTPW_4470_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@engines-mixed-process@vcs1:
- shard-kbl: [PASS][1] -> [FAIL][2] ([i915#1528])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl1/igt@gem_ctx_persistence@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl7/igt@gem_ctx_persistence@[email protected]

* igt@gem_shrink@reclaim:
- shard-hsw: [PASS][3] -> [INCOMPLETE][4] ([i915#61])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-hsw7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-hsw2/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([i915#180])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-apl8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-apl6/igt@[email protected]

* igt@gem_workarounds@suspend-resume-context:
- shard-tglb: [PASS][7] -> [INCOMPLETE][8] ([i915#456] / [i915#460])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-tglb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-tglb2/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [PASS][9] -> [FAIL][10] ([i915#1066])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-hsw1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-hsw6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x256-random:
- shard-kbl: [PASS][11] -> [FAIL][12] ([i915#54] / [i915#93] / [i915#95]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-dpms:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#54])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-apl3/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-apl3/igt@[email protected]
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#54])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl7/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl7/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-blt-ytiled:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#52] / [i915#54]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-glk2/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-glk1/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#177] / [i915#52] / [i915#54] / [i915#93] / [i915#95])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl2/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl6/igt@[email protected]
- shard-apl: [PASS][21] -> [FAIL][22] ([i915#52] / [i915#54] / [i915#95])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-apl8/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-apl3/igt@[email protected]

* igt@kms_mmap_write_crc@main:
- shard-kbl: [PASS][23] -> [FAIL][24] ([i915#93] / [i915#95])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl1/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#180]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl4/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-iclb2/igt@kms_psr@psr2_basic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-iclb4/igt@kms_psr@psr2_basic.html

#### Possible fixes ####

* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [SKIP][29] ([fdo#109276]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-iclb8/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-iclb1/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][31] ([i915#454]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-iclb6/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-iclb1/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-apl: [FAIL][33] ([i915#1119] / [i915#95]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-apl4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-apl8/igt@[email protected]
- shard-kbl: [FAIL][35] ([i915#1119] / [i915#93] / [i915#95]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x21-onscreen:
- shard-kbl: [FAIL][37] ([i915#54] / [i915#93] / [i915#95]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl2/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl4/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl1/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-glk: [FAIL][41] ([i915#52] / [i915#54]) -> [PASS][42] +4 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-glk9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-glk2/igt@[email protected]

* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-untiled:
- shard-apl: [FAIL][43] ([i915#52] / [i915#54] / [i915#95]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-apl7/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-apl4/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-tglb: [INCOMPLETE][45] ([i915#456] / [i915#460]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-tglb7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-tglb5/igt@[email protected]

* {igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a2}:
- shard-glk: [FAIL][47] -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-glk7/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-glk7/igt@kms_flip@[email protected]

* {igt@kms_flip@flip-vs-suspend-interruptible@b-dp1}:
- shard-apl: [DMESG-WARN][49] ([i915#180]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-apl8/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-apl2/igt@kms_flip@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-kbl: [FAIL][51] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl2/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl7/igt@[email protected]
- shard-apl: [FAIL][53] ([fdo#108145] / [i915#265] / [i915#95]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-apl1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-apl8/igt@[email protected]

* igt@kms_psr@psr2_dpms:
- shard-iclb: [SKIP][55] ([fdo#109441]) -> [PASS][56] +2 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-iclb7/igt@kms_psr@psr2_dpms.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-iclb2/igt@kms_psr@psr2_dpms.html

* {igt@perf@polling-parameterized}:
- shard-hsw: [FAIL][57] ([i915#1542]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-hsw1/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-hsw7/igt@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc6-psr:
- shard-snb: [INCOMPLETE][59] ([i915#82]) -> [SKIP][60] ([fdo#109271])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-snb6/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-snb6/igt@[email protected]

* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-snb: [SKIP][61] ([fdo#109271]) -> [INCOMPLETE][62] ([i915#82])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-snb1/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-snb6/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: [SKIP][63] ([fdo#109293] / [fdo#109506]) -> [SKIP][64] ([i915#1316] / [i915#579])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-iclb4/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-iclb1/igt@[email protected]
- shard-tglb: [SKIP][65] ([fdo#109506]) -> [SKIP][66] ([i915#1316] / [i915#579])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-tglb1/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-tglb6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-kbl: [FAIL][67] ([fdo#108145] / [i915#265]) -> [FAIL][68] ([fdo#108145] / [i915#265] / [i915#93] / [i915#95])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8303/shard-kbl2/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4470/shard-kbl6/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (10 -> 8)
------------------------------

Missing (2): pig-skl-6260u pig-glk-j5005

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5591 -> IGTPW_4470
* Piglit: piglit_4509 -> None

== Logs ==