travis: Correct error checking when building boards
PATCH 1/1 travis: Correct error checking when building boards
At present if buildman reports an error, the travis build still succeeds.
This is because the travis script does not stop when it sees errors; nor does it automatically return the exit code. Also the current error checking never triggers since 'ret' is not set.
Fix this by setting 'ret' correctly.
---
.travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
.travis.yml +1 -1
@@ -208,7 +208,7 @@ script: # # Build a selection of boards if TEST_PY_BD is empty - if [[ "${BUILDMAN}" != "" ]]; then - tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE}; + tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?; if [[ $ret -ne 0 ]]; then tools/buildman/buildman -seP ${BUILDMAN}; exit $ret;
Signature · 1 line
2.26.0.110.g2183baf09c-goog
PATCH 1/1 travis: Correct error checking when building boards
Quoted 20 lines · Simon Glass
At present if buildman reports an error, the travis build still succeeds.
This is because the travis script does not stop when it sees errors; nor does it automatically return the exit code. Also the current error checking never triggers since 'ret' is not set.
Fix this by setting 'ret' correctly.
Signed-off-by Simon Glass <[email protected]>---
.travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-).travis.yml +0
-0
.travis.yml script: · line 214
Quoted 8 lines
.travis.yml +1
-1@@ -208,7 +208,7 @@ script: # # Build a selection of boards if TEST_PY_BD is empty - if [[ "${BUILDMAN}" != "" ]]; then - tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE}; + tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?; if [[ $ret -ne 0 ]]; then tools/buildman/buildman -seP ${BUILDMAN}; exit $ret;
I am also missing ret=0; assignment which is also needed.
Please also add
to v2.
Thanks,
Michal
PATCH 1/1 travis: Correct error checking when building boards
Hi Michal,
Quoted 16 lines · Michal Simek
Quoted 14 lines · Simon Glass
At present if buildman reports an error, the travis build still succeeds.
This is because the travis script does not stop when it sees errors; nor does it automatically return the exit code. Also the current error checking never triggers since 'ret' is not set.
Fix this by setting 'ret' correctly.
Signed-off-by Simon Glass <[email protected]>---
.travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 6 lines
.travis.yml +0
-0.travis.yml script: · line 214
Quoted 8 lines
.travis.yml +1
-1@@ -208,7 +208,7 @@ script: # # Build a selection of boards if TEST_PY_BD is empty - if [[ "${BUILDMAN}" != "" ]]; then - tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE}; + tools/buildman/buildman -P -E -W ${BUILDMAN} ${OVERRIDE} || ret=$?; if [[ $ret -ne 0 ]]; then tools/buildman/buildman -seP ${BUILDMAN}; exit $ret;I am also missing ret=0; assignment which is also needed.
Are you sure this is needed? It seems to work without it. By default variables are empty in bash.
But I will change it, since it is confusing otherwise.
Quoted 4 lines
Please also add
Reported-by Michal Simek <[email protected]>to v2.
OK will do.
- Simon