Skip to contentSkip to conversation

thunderbolt: Check return value of tb_sw_read() in usb4_switch_op()

PATCH In review Mika Westerberg 2 participants 3 messages Apr 16, 2020 – Apr 20, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thunderbolt: Check return value of tb_sw_read() in usb4_switch_op()

The function misses checking return value of tb_sw_read() before it accesses the value that was read. Fix this by checking the return value first.

Fixes b04079837b20 ("thunderbolt: Add initial support for USB4")
---
 drivers/thunderbolt/usb4.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/thunderbolt/usb4.c +3 -0
index 3d084cec136f..50c7534ba31e 100644
@@ -182,6 +182,9 @@ static int usb4_switch_op(struct tb_switch *sw, u16 opcode, u8 *status)
 		return ret;
 
 	ret = tb_sw_read(sw, &val, TB_CFG_SWITCH, ROUTER_CS_26, 1);
+	if (ret)
+		return ret;
+
 	if (val & ROUTER_CS_26_ONS)
 		return -EOPNOTSUPP;
 
Signature · 1 line
2.25.1