Skip to contentSkip to conversation

kbuild: check libyaml installation for 'make dt_binding_check'

PATCH Applied Masahiro Yamada 2 participants 2 messages Apr 17, 2020 Device tree

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kbuild: check libyaml installation for 'make dt_binding_check'

If you run 'make dtbs_check' without installing the libyaml package, the error message "dtc needs libyaml ..." is shown.

This should be checked also for 'make dt_binding_check' because dtc needs to validate *.example.dts extracted from *.yaml files.

It is missing since commit 4f0e3a57d6eb ("kbuild: Add support for DT binding schema checks"), but this fix-up is applicable only after commit e10c4321dc1e ("kbuild: allow to run dt_binding_check and dtbs_check in a single command").

I gave the Fixes tag to the latter in case somebody is interested in back-porting this.

Fixes e10c4321dc1e ("kbuild: allow to run dt_binding_check and dtbs_check in a single command")

---

 scripts/dtc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/dtc/Makefile +1 -1
index 2f3c3a7e1620..ef85f8b7d4a7 100644
@@ -13,7 +13,7 @@ dtc-objs	+= dtc-lexer.lex.o dtc-parser.tab.o
 HOST_EXTRACFLAGS := -I $(srctree)/$(src)/libfdt
 
 ifeq ($(shell pkg-config --exists yaml-0.1 2>/dev/null && echo yes),)
-ifneq ($(CHECK_DTBS),)
+ifneq ($(CHECK_DT_BINDING)$(CHECK_DTBS),)
 $(error dtc needs libyaml for DT schema validation support. \
 	Install the necessary libyaml development package.)
 endif
Signature · 1 line
2.25.1
maintainer Applied
#1 lore raw
Quoted 14 lines · Masahiro Yamada

If you run 'make dtbs_check' without installing the libyaml package, the error message "dtc needs libyaml ..." is shown.

This should be checked also for 'make dt_binding_check' because dtc needs to validate *.example.dts extracted from *.yaml files.

It is missing since commit 4f0e3a57d6eb ("kbuild: Add support for DT binding schema checks"), but this fix-up is applicable only after commit e10c4321dc1e ("kbuild: allow to run dt_binding_check and dtbs_check in a single command").

I gave the Fixes tag to the latter in case somebody is interested in back-porting this.

Quoted 6 lines
Fixes e10c4321dc1e ("kbuild: allow to run dt_binding_check and dtbs_check in a single command")

---

 scripts/dtc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Rob