Skip to contentSkip to conversation

board: atmel: Fix compiler warning 'board_usb_hw_init()' not used

PATCH New Josef Lusticky 2 participants 2 messages Apr 17, 2020 – May 6, 2020 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board: atmel: Fix compiler warning 'board_usb_hw_init()' not used

Wrap definition of board_usb_hw_init() around with #ifdef CONFIG_CMD_USB to avoid warning: 'board_usb_hw_init' defined but not used [-Wunused-function] when compiling without CONFIG_CMD_USB.

This patch makes sama5d27_som1_ek, sama5d2_ptc_ek and sama5d2_xplained consistent with other boards that use the same #ifdef to avoid the warning.

Cc Eugen Hristev <[email protected]>
Cc Ludovic Desroches <[email protected]>
---
 board/atmel/sama5d27_som1_ek/sama5d27_som1_ek.c | 2 ++
 board/atmel/sama5d2_ptc_ek/sama5d2_ptc_ek.c     | 2 ++
 board/atmel/sama5d2_xplained/sama5d2_xplained.c | 2 ++
 3 files changed, 6 insertions(+)
board/atmel/sama5d27_som1_ek/sama5d27_som1_ek.c +2 -0
index f3816c8334..376562cd0e 100644
@@ -20,10 +20,12 @@ extern void at91_pda_detect(void);
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifdef CONFIG_CMD_USB
 static void board_usb_hw_init(void)
 {
 	atmel_pio4_set_pio_output(AT91_PIO_PORTA, 27, 1);
 }
+#endif
 
 #ifdef CONFIG_BOARD_LATE_INIT
 int board_late_init(void)
board/atmel/sama5d2_ptc_ek/sama5d2_ptc_ek.c +2 -0
index 4b3a703f26..b0a23b02db 100644
@@ -76,10 +76,12 @@ int board_late_init(void)
 }
 #endif
 
+#ifdef CONFIG_CMD_USB
 static void board_usb_hw_init(void)
 {
 	atmel_pio4_set_pio_output(AT91_PIO_PORTB, 12, ATMEL_PIO_PUEN_MASK);
 }
+#endif
 
 #ifdef CONFIG_DEBUG_UART_BOARD_INIT
 static void board_uart0_hw_init(void)
board/atmel/sama5d2_xplained/sama5d2_xplained.c +2 -0
index 2116b78837..01636fb73d 100644
@@ -20,10 +20,12 @@ extern void at91_pda_detect(void);
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#ifdef CONFIG_CMD_USB
 static void board_usb_hw_init(void)
 {
 	atmel_pio4_set_pio_output(AT91_PIO_PORTB, 10, 1);
 }
+#endif
 
 #ifdef CONFIG_BOARD_LATE_INIT
 int board_late_init(void)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 board: atmel: Fix compiler warning 'board_usb_hw_init()' not used

Quoted 11 lines · Josef Lusticky

Wrap definition of board_usb_hw_init() around with #ifdef CONFIG_CMD_USB to avoid warning: 'board_usb_hw_init' defined but not used [-Wunused-function] when compiling without CONFIG_CMD_USB.

This patch makes sama5d27_som1_ek, sama5d2_ptc_ek and sama5d2_xplained consistent with other boards that use the same #ifdef to avoid the warning.

Cc Eugen Hristev <[email protected]>
Cc Ludovic Desroches <[email protected]>

---

Applied to u-boot-atmel/master

Thanks !