soc/tegra: fuse: Update the SoC revision attribute to display a name
Jon Hunter
maintainerPATCH 1/1 soc/tegra: fuse: Update the SoC revision attribute to display a name
Currently the SoC revision attribute for Tegra devices displays the value of the enum associated with a particular revision. This is not very useful because to obtain the actual revision you need to use the tegra_revision enumeration to translate the value.
It is more meaningful to display a name for the revision, such as 'A01', than the enumarated value and therefore, update the revision attribute to display a name. This change does alter the ABI, which is unfortunate, but this is more meaningful and maintable.
--- drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/soc/tegra/fuse/fuse-tegra.c +2 -1
@@ -363,7 +363,8 @@ struct device * __init tegra_soc_device_register(void)return NULL ; attr->family =kasprintf (GFP_KERNEL ,"Tegra" ); - attr->revision =kasprintf (GFP_KERNEL ,"%d" , tegra_sku_info.revision); + attr->revision =kasprintf (GFP_KERNEL ,"%s" , + tegra_revision_name[tegra_sku_info.revision]); attr->soc_id =kasprintf (GFP_KERNEL ,"%u" ,tegra_get_chip_id ()); attr->custom_attr_group = fuse->soc->soc_attr_group;
Signature · 1 line
2.17.1
Thierry Reding
AppliedQuoted 10 lines · Jon Hunter
Currently the SoC revision attribute for Tegra devices displays the value of the enum associated with a particular revision. This is not very useful because to obtain the actual revision you need to use the
tegra_revisionenumeration to translate the value.It is more meaningful to display a name for the revision, such as 'A01', than the enumarated value and therefore, update the revision attribute to display a name. This change does alter the ABI, which is unfortunate, but this is more meaningful and maintable.
Quoted 4 lines
Signed-off-by Jon Hunter <[email protected]>--- drivers/soc/tegra/fuse/fuse-tegra.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Applied, thanks.
Thierry