Drivers: hv: Move AEOI determination to architecture dependent code
Subsystems (3)
PATCH 1/1 Drivers: hv: Move AEOI determination to architecture dependent code
Hyper-V on ARM64 doesn't provide a flag for the AEOI recommendation in ms_hyperv.hints, so having the test in architecture independent code doesn't work. Resolve this by moving the check of the flag to an architecture dependent helper function. No functionality is changed.
Signed-off-by Michael Kelley <[email protected]>
--- arch/x86/include/asm/mshyperv.h | 2 ++ drivers/hv/hv.c | 6 +----- 2 files changed, 3 insertions(+), 5 deletions(-)
arch/x86/include/asm/mshyperv.h +2 -0
@@ -35,6 +35,8 @@ typedef int (*hyperv_fill_flush_list_func)( rdmsrl(HV_X64_MSR_SINT0 + int_num, val)#define hv_set_synint_state (int_num, val) \ wrmsrl(HV_X64_MSR_SINT0 + int_num, val) +#define hv_recommend_using_aeoi () \ + (!(ms_hyperv.hints & HV_DEPRECATING_AEOI_RECOMMENDED))#define hv_get_crash_ctl (val) \ rdmsrl(HV_X64_MSR_CRASH_CTL, val)
drivers/hv/hv.c +1 -5
@@ -184,11 +184,7 @@ void hv_synic_enable_regs(unsigned int cpu) shared_sint.vector =HYPERVISOR_CALLBACK_VECTOR ; shared_sint.masked = false; -if (ms_hyperv.hints &HV_DEPRECATING_AEOI_RECOMMENDED ) - shared_sint.auto_eoi = false; -else - shared_sint.auto_eoi = true; - + shared_sint.auto_eoi =hv_recommend_using_aeoi ();hv_set_synint_state (VMBUS_MESSAGE_SINT , shared_sint.as_uint64);/* Enable the global synic bit */
Signature · 1 line
2.18.2
Quoted 7 lines · Michael Kelley
Hyper-V on ARM64 doesn't provide a flag for the AEOI recommendation in ms_hyperv.hints, so having the test in architecture independent code doesn't work. Resolve this by moving the check of the flag to an architecture dependent helper function. No functionality is changed.
Signed-off-by Michael Kelley <[email protected]>
Applied to hyperv-fixes. Thanks.
Quoted 38 lines
--- arch/x86/include/asm/mshyperv.h | 2 ++ drivers/hv/hv.c | 6 +----- 2 files changed, 3 insertions(+), 5 deletions(-)arch/x86/include/asm/mshyperv.h +2
-0@@ -35,6 +35,8 @@ typedef int (*hyperv_fill_flush_list_func)( rdmsrl(HV_X64_MSR_SINT0 + int_num, val)#define hv_set_synint_state (int_num, val) \ wrmsrl(HV_X64_MSR_SINT0 + int_num, val) +#define hv_recommend_using_aeoi () \ + (!(ms_hyperv.hints & HV_DEPRECATING_AEOI_RECOMMENDED))#define hv_get_crash_ctl (val) \ rdmsrl(HV_X64_MSR_CRASH_CTL, val)drivers/hv/hv.c +1
-5@@ -184,11 +184,7 @@ void hv_synic_enable_regs(unsigned int cpu) shared_sint.vector =HYPERVISOR_CALLBACK_VECTOR ; shared_sint.masked = false; -if (ms_hyperv.hints &HV_DEPRECATING_AEOI_RECOMMENDED ) - shared_sint.auto_eoi = false; -else - shared_sint.auto_eoi = true; - + shared_sint.auto_eoi =hv_recommend_using_aeoi ();hv_set_synint_state (VMBUS_MESSAGE_SINT , shared_sint.as_uint64);/* Enable the global synic bit */ Signature · 1 line
2.18.2