Skip to contentSkip to conversation

drivers: video: rockchip: fix building eDP and LVDS drivers

PATCH New Peter Robinson 3 participants 4 messages Apr 20, 2020 – Apr 26, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers

The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in hardware.h so include it so the drivers build. Adjust rk_lvds.c so includes are in alphabetical order while updating.

---
 drivers/video/rockchip/rk_edp.c  | 1 +
 drivers/video/rockchip/rk_lvds.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/video/rockchip/rk_edp.c +1 -0
index 8703df0ec0..cf84b886e7 100644
@@ -18,6 +18,7 @@
 #include <asm/arch-rockchip/clock.h>
 #include <asm/arch-rockchip/edp_rk3288.h>
 #include <asm/arch-rockchip/grf_rk3288.h>
+#include <asm/arch-rockchip/hardware.h>
 #include <dt-bindings/clock/rk3288-cru.h>
 
 #define MAX_CR_LOOP 5
drivers/video/rockchip/rk_lvds.c +2 -1
index cf5c0439b1..79e24baf53 100644
@@ -13,8 +13,9 @@
 #include <asm/gpio.h>
 #include <asm/io.h>
 #include <asm/arch-rockchip/clock.h>
-#include <asm/arch-rockchip/lvds_rk3288.h>
 #include <asm/arch-rockchip/grf_rk3288.h>
+#include <asm/arch-rockchip/hardware.h>
+#include <asm/arch-rockchip/lvds_rk3288.h>
 #include <dt-bindings/clock/rk3288-cru.h>
 #include <dt-bindings/video/rk3288.h>
 
Signature · 1 line
2.26.1
#1 lore raw

PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers

Quoted 5 lines · On Mon, 20 Apr 2020 19:18:25 +0100 Peter Robinson pbrobinson at gmail.com wrote:

The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in hardware.h so include it so the drivers build. Adjust rk_lvds.c so includes are in alphabetical order while updating.

--
Anatolij

#2 lore raw

PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers

In reply to Peter Robinson
Quoted 6 lines · Peter Robinson

The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in hardware.h so include it so the drivers build. Adjust rk_lvds.c so includes are in alphabetical order while updating.

This fixed the build I was having with the pinebook pro patches when applied to v2020.04, built on both Debian and GNU Guix.

Thanks!

Quoted 22 lines
---
 drivers/video/rockchip/rk_edp.c  | 1 +
 drivers/video/rockchip/rk_lvds.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/video/rockchip/rk_edp.c +1 -0
index 8703df0ec0..cf84b886e7 100644
@@ -18,6 +18,7 @@
 #include <asm/arch-rockchip/clock.h>
 #include <asm/arch-rockchip/edp_rk3288.h>
 #include <asm/arch-rockchip/grf_rk3288.h>
+#include <asm/arch-rockchip/hardware.h>
 #include <dt-bindings/clock/rk3288-cru.h>
 
 #define MAX_CR_LOOP 5
drivers/video/rockchip/rk_lvds.c +0 -0
index cf5c0439b1..79e24baf53 100644

drivers/video/rockchip/rk_lvds.c line 21

Quoted 10 lines
drivers/video/rockchip/rk_lvds.c +2 -1
@@ -13,8 +13,9 @@
 #include <asm/gpio.h>
 #include <asm/io.h>
 #include <asm/arch-rockchip/clock.h>
-#include <asm/arch-rockchip/lvds_rk3288.h>
 #include <asm/arch-rockchip/grf_rk3288.h>
+#include <asm/arch-rockchip/hardware.h>
+#include <asm/arch-rockchip/lvds_rk3288.h>
 #include <dt-bindings/clock/rk3288-cru.h>
 #include <dt-bindings/video/rk3288.h>
 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200420/cb9c018b/attachment-0001.sig>

#3 lore raw

PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers

In reply to Peter Robinson
Quoted 9 lines · On Mon, 20 Apr 2020 19:18:25 +0100 Peter Robinson pbrobinson at gmail.com wrote:

The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in hardware.h so include it so the drivers build. Adjust rk_lvds.c so includes are in alphabetical order while updating.

---
 drivers/video/rockchip/rk_edp.c  | 1 +
 drivers/video/rockchip/rk_lvds.c | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

Applied to u-boot-video/master, thanks!

--
Anatolij