drivers: video: rockchip: fix building eDP and LVDS drivers
Subsystems (2)
PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers
The rk_edp.c and rk_lvds.c files reference rk_setreg which is declared in hardware.h so include it so the drivers build. Adjust rk_lvds.c so includes are in alphabetical order while updating.
--- drivers/video/rockchip/rk_edp.c | 1 + drivers/video/rockchip/rk_lvds.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/video/rockchip/rk_edp.c +1 -0
@@ -18,6 +18,7 @@#include <asm/arch-rockchip/clock.h> #include <asm/arch-rockchip/edp_rk3288.h> #include <asm/arch-rockchip/grf_rk3288.h> +#include <asm/arch-rockchip/hardware.h> #include <dt-bindings/clock/rk3288-cru.h> #define MAX_CR_LOOP 5
drivers/video/rockchip/rk_lvds.c +2 -1
@@ -13,8 +13,9 @@#include <asm/gpio.h> #include <asm/io.h> #include <asm/arch-rockchip/clock.h> -#include <asm/arch-rockchip/lvds_rk3288.h> #include <asm/arch-rockchip/grf_rk3288.h> +#include <asm/arch-rockchip/hardware.h> +#include <asm/arch-rockchip/lvds_rk3288.h> #include <dt-bindings/clock/rk3288-cru.h> #include <dt-bindings/video/rk3288.h>
Signature · 1 line
2.26.1
PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers
Quoted 5 lines · On Mon, 20 Apr 2020 19:18:25 +0100 Peter Robinson pbrobinson at gmail.com wrote:
The
rk_edp.candrk_lvds.cfiles referencerk_setregwhich is declared inhardware.hso include it so the drivers build. Adjustrk_lvds.cso includes are in alphabetical order while updating.Signed-off-by Peter Robinson <[email protected]>
--
Anatolij
PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers
In reply to Peter RobinsonQuoted 6 lines · Peter Robinson
The
rk_edp.candrk_lvds.cfiles referencerk_setregwhich is declared inhardware.hso include it so the drivers build. Adjustrk_lvds.cso includes are in alphabetical order while updating.Signed-off-by Peter Robinson <[email protected]>Reviewed-by Anatolij Gustschin <[email protected]>
This fixed the build I was having with the pinebook pro patches when applied to v2020.04, built on both Debian and GNU Guix.
Thanks!
Quoted 22 lines
--- drivers/video/rockchip/rk_edp.c | 1 + drivers/video/rockchip/rk_lvds.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)drivers/video/rockchip/rk_edp.c +1
-0@@ -18,6 +18,7 @@#include <asm/arch-rockchip/clock.h> #include <asm/arch-rockchip/edp_rk3288.h> #include <asm/arch-rockchip/grf_rk3288.h> +#include <asm/arch-rockchip/hardware.h> #include <dt-bindings/clock/rk3288-cru.h> #define MAX_CR_LOOP 5drivers/video/rockchip/rk_lvds.c +0
-0
drivers/video/rockchip/rk_lvds.c line 21
Quoted 10 lines
drivers/video/rockchip/rk_lvds.c +2
-1@@ -13,8 +13,9 @@#include <asm/gpio.h> #include <asm/io.h> #include <asm/arch-rockchip/clock.h> -#include <asm/arch-rockchip/lvds_rk3288.h> #include <asm/arch-rockchip/grf_rk3288.h> +#include <asm/arch-rockchip/hardware.h> +#include <asm/arch-rockchip/lvds_rk3288.h> #include <dt-bindings/clock/rk3288-cru.h> #include <dt-bindings/video/rk3288.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 227 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200420/cb9c018b/attachment-0001.sig>
PATCH 1/1 drivers: video: rockchip: fix building eDP and LVDS drivers
In reply to Peter RobinsonQuoted 9 lines · On Mon, 20 Apr 2020 19:18:25 +0100 Peter Robinson pbrobinson at gmail.com wrote:
The
rk_edp.candrk_lvds.cfiles referencerk_setregwhich is declared inhardware.hso include it so the drivers build. Adjustrk_lvds.cso includes are in alphabetical order while updating.Signed-off-by Peter Robinson <[email protected]>--- drivers/video/rockchip/rk_edp.c | 1 + drivers/video/rockchip/rk_lvds.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-)
Applied to u-boot-video/master, thanks!
--
Anatolij