imx8qxp_mek: Run with caches enabled
Fabio Estevam
reviewerPATCH 1/1 imx8qxp_mek: Run with caches enabled
There is no need to run with caches disabled.
--- configs/imx8qxp_mek_defconfig | 2 -- 1 file changed, 2 deletions(-)
configs/imx8qxp_mek_defconfig +0 -2
@@ -1,6 +1,4 @@ CONFIG_ARM=y -CONFIG_SPL_SYS_ICACHE_OFF=y -CONFIG_SPL_SYS_DCACHE_OFF=y CONFIG_ARCH_IMX8=y CONFIG_SYS_TEXT_BASE=0x80020000 CONFIG_SPL_GPIO_SUPPORT=y
Signature · 1 line
2.17.1
PATCH 1/1 imx8qxp_mek: Run with caches enabled
Hi Fabio,
Quoted 20 lines
-----Original Message-----
From: Fabio Estevam <[email protected]>
Sent: 2020?4?21? 2:55
To: sbabic at denx.de
Cc: Peng Fan <[email protected]>; dl-uboot-imx <[email protected]>; u-boot at lists.denx.de; Fabio Estevam <[email protected]>
Subject: [PATCH]imx8qxp_mek: Run with caches enabledThere is no need to run with caches disabled.
Signed-off-by Fabio Estevam <[email protected]>--- configs/imx8qxp_mek_defconfig | 2 -- 1 file changed, 2 deletions(-)configs/imx8qxp_mek_defconfig +0
-0
configs/imx8qxp_mek_defconfig line 3
Quoted 3 lines
configs/imx8qxp_mek_defconfig +0
-2@@ -1,6 +1,4 @@ CONFIG_ARM=y -CONFIG_SPL_SYS_ICACHE_OFF=y -CONFIG_SPL_SYS_DCACHE_OFF=y
Currently there is no mmu setup in SPL stage.
Regards,
Peng.
Quoted 5 lines
configs/imx8qxp_mek_defconfig +0
-1CONFIG_ARCH_IMX8=y CONFIG_SYS_TEXT_BASE=0x80020000 CONFIG_SPL_GPIO_SUPPORT=y --2.17.1
Fabio Estevam
reviewerPATCH 1/1 imx8qxp_mek: Run with caches enabled
Hi Peng,
Quoted 4 lines · Peng Fan
configs/imx8qxp_mek_defconfig line 3
Quoted 2 lines
configs/imx8qxp_mek_defconfig +0
-2-CONFIG_SPL_SYS_ICACHE_OFF=y -CONFIG_SPL_SYS_DCACHE_OFF=yCurrently there is no mmu setup in SPL stage.
Could you please expand the explanation a bit?
Why do we need to select these options only for i.MX8 boards?
What would be the correct fix in your opinion?
Please advise.
PATCH 1/1 imx8qxp_mek: Run with caches enabled
Hi Fabio,
Quoted 11 lines
Subject: Re: [PATCH]
imx8qxp_mek: Run with caches enabledHi Peng,
Quoted 4 lines · Peng Fan
configs/imx8qxp_mek_defconfig line 3
Quoted 2 lines
configs/imx8qxp_mek_defconfig +0
-2-CONFIG_SPL_SYS_ICACHE_OFF=y -CONFIG_SPL_SYS_DCACHE_OFF=yCurrently there is no mmu setup in SPL stage.
Quoted 5 lines
Could you please expand the explanation a bit?
Why do we need to select these options only for i.MX8 boards?
What would be the correct fix in your opinion?
As I recall, icache could be enabled, but if enable dcache, we might need setup mmu for SPL.
Regards,
Peng.
Quoted 2 lines
Please advise.
Fabio Estevam
reviewerPATCH 1/1 imx8qxp_mek: Run with caches enabled
Hi Peng,
Quoted 2 lines · Peng Fan
As I recall, icache could be enabled, but if enable dcache, we might need setup mmu for SPL.
Does this requirement apply only for iMX8? I don't see it for i.MX6/i.MX7.
So still confused about your comment.
With this patch, SPL still loads U-Boot proper, so didn't notice an error.
Thanks
PATCH 1/1 imx8qxp_mek: Run with caches enabled
Quoted 6 lines
Subject: Re: [PATCH]
imx8qxp_mek: Run with caches enabledHi Peng,
On Tue, Apr 21, 2020 at 9:22 AM Peng Fan <[email protected]> wrote:
Quoted 8 lines
Quoted 2 lines
As I recall, icache could be enabled, but if enable dcache, we might need setup mmu for SPL.
Does this requirement apply only for iMX8? I don't see it for i.MX6/i.MX7.
So still confused about your comment.
With this patch, SPL still loads U-Boot proper, so didn't notice an error.
Just checked the code.
In SPL stage dcache is off, icache is enabled with your patch. So it is ok.
Regards,
Peng.
Quoted 2 lines
Thanks
Fabio Estevam
reviewerPATCH 1/1 imx8qxp_mek: Run with caches enabled
Hi Peng,
Quoted 3 lines · Peng Fan
Just checked the code.
In SPL stage dcache is off, icache is enabled with your patch. So it is ok.
Thanks, I will send patches doing the same for the other i.MX8 boards.
Thanks
PATCH 1/1 imx8qxp_mek: Run with caches enabled
In reply to Fabio EstevamQuoted 5 lines
Subject: [PATCH]
imx8qxp_mek: Run with caches enabledThere is no need to run with caches disabled.
Signed-off-by Fabio Estevam <[email protected]>
Quoted 17 lines
--- configs/imx8qxp_mek_defconfig | 2 -- 1 file changed, 2 deletions(-)configs/imx8qxp_mek_defconfig +0
-3@@ -1,6 +1,4 @@ CONFIG_ARM=y -CONFIG_SPL_SYS_ICACHE_OFF=y -CONFIG_SPL_SYS_DCACHE_OFF=y CONFIG_ARCH_IMX8=y CONFIG_SYS_TEXT_BASE=0x80020000 CONFIG_SPL_GPIO_SUPPORT=y --2.17.1
PATCH 1/1 imx8qxp_mek: Run with caches enabled
In reply to Fabio EstevamQuoted 3 lines
There is no need to run with caches disabled.
Signed-off-by Fabio Estevam <[email protected]>Reviewed-by Peng Fan <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================