Skip to contentSkip to conversation

platform/x86: touchscreen_dmi: Add info for the ONDA V891 v5 tablet

PATCH In review Maksim Karasev 2 participants 5 messages Apr 21, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: touchscreen_dmi: Add info for the ONDA V891 v5 tablet

Add touchscreen info for the ONDA V891 v5 tablet.

---
 drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +27 -0
index 6ec8923dec1a..cc2a2e0a0585 100644
@@ -448,6 +448,24 @@ static const struct ts_dmi_data onda_v820w_32g_data = {
 	.properties	= onda_v820w_32g_props,
 };
 
+static const struct property_entry onda_v891_v5_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_STRING("firmware-name",
+			      "gsl3676-onda-v891-v5.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data onda_v891_v5_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= onda_v891_v5_props,
+};
+
 static const struct property_entry onda_v891w_v1_props[] = {
 	PROPERTY_ENTRY_U32("touchscreen-min-x", 46),
 	PROPERTY_ENTRY_U32("touchscreen-min-y",  8),
@@ -940,6 +958,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
 			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "V820w DualOS")
 		},
 	},
+	{
+		/* ONDA V891 v5 */
+		.driver_data = (void *)&onda_v891_v5_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"),
+			DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D869CJABNRBA06"),
+		},
+	},
 	{
 		/* ONDA V891w revision P891WBEBV1B00 aka v1 */
 		.driver_data = (void *)&onda_v891w_v1_data,
Signature · 1 line
2.26.1
#1 lore raw

Hi,

Quoted 1 line · Maksim Karasev

Add touchscreen info for the ONDA V891 v5 tablet.

Thank you for the patch.

Can you please replace v891 with v891w everywhere to be consistent with the existing v891 entries; and ...

Quoted 22 lines
---
  drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +8 -0
index 6ec8923dec1a..cc2a2e0a0585 100644
@@ -448,6 +448,24 @@ static const struct ts_dmi_data onda_v820w_32g_data = {
  	.properties	= onda_v820w_32g_props,
  };
 
+static const struct property_entry onda_v891_v5_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_STRING("firmware-name",
+			      "gsl3676-onda-v891-v5.fw"),

drivers/platform/x86/touchscreen_dmi.c static const struct ts_dmi_data onda_v820w_32g_data = { · line 468

Quoted 10 lines
drivers/platform/x86/touchscreen_dmi.c +10 -0
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data onda_v891_v5_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= onda_v891_v5_props,
+};
+

Put this after the v891w_v3 entry please so that we have in order v1, v3 and then v5.

Thanks,

Hans

Quoted 20 lines
drivers/platform/x86/touchscreen_dmi.c +9 -0
  static const struct property_entry onda_v891w_v1_props[] = {
  	PROPERTY_ENTRY_U32("touchscreen-min-x", 46),
  	PROPERTY_ENTRY_U32("touchscreen-min-y",  8),
@@ -940,6 +958,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "V820w DualOS")
  		},
  	},
+	{
+		/* ONDA V891 v5 */
+		.driver_data = (void *)&onda_v891_v5_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"),
+			DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D869CJABNRBA06"),
+		},
+	},
  	{
  		/* ONDA V891w revision P891WBEBV1B00 aka v1 */
  		.driver_data = (void *)&onda_v891w_v1_data,
#2 lore raw

Hello,
Sorry, but I think you are mistaken,
the v891 and v891w are 2 different tablets (different screen, battery, camera, and internal storage).
My patch is for the v891.
Thanks.

-------------------------
Maksim Karasev

#3 lore raw

Hi,

Quoted 5 lines · Maksim Karasev

Hello,
Sorry, but I think you are mistaken,
the v891 and v891w are 2 different tablets (different screen, battery, camera, and internal storage).
My patch is for the v891.

Ah I see, so the v891w has a 1920x1200 screen and the v891 has a 1280x800 screen, ok.

Regards,

Hans

Reviewed-by on v1 1/1
#4 lore raw
In reply to Maksim Karasev

Hi,

Quoted 3 lines · Maksim Karasev

Add touchscreen info for the ONDA V891 v5 tablet.

Patch looks good to me:

Regards,

Hans

Quoted 50 lines
---
  drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++
  1 file changed, 27 insertions(+)
drivers/platform/x86/touchscreen_dmi.c +27 -0
index 6ec8923dec1a..cc2a2e0a0585 100644
@@ -448,6 +448,24 @@ static const struct ts_dmi_data onda_v820w_32g_data = {
  	.properties	= onda_v820w_32g_props,
  };
 
+static const struct property_entry onda_v891_v5_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1715),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 1140),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_STRING("firmware-name",
+			      "gsl3676-onda-v891-v5.fw"),
+	PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+	PROPERTY_ENTRY_BOOL("silead,home-button"),
+	{ }
+};
+
+static const struct ts_dmi_data onda_v891_v5_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= onda_v891_v5_props,
+};
+
  static const struct property_entry onda_v891w_v1_props[] = {
  	PROPERTY_ENTRY_U32("touchscreen-min-x", 46),
  	PROPERTY_ENTRY_U32("touchscreen-min-y",  8),
@@ -940,6 +958,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "V820w DualOS")
  		},
  	},
+	{
+		/* ONDA V891 v5 */
+		.driver_data = (void *)&onda_v891_v5_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "ONDA"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"),
+			DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D869CJABNRBA06"),
+		},
+	},
  	{
  		/* ONDA V891w revision P891WBEBV1B00 aka v1 */
  		.driver_data = (void *)&onda_v891w_v1_data,