hwrng: Use UUID API for exporting the UUID
Subsystems (3)
PATCH 1/1 hwrng: Use UUID API for exporting the UUID
There is export_uuid() function which exports uuid_t to the u8 array. Use it instead of open coding variant.
This allows to hide the uuid_t internals.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/char/hw_random/optee-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/hw_random/optee-rng.c +1 -1
@@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev)return -ENODEV ;/* Open session with hwrng Trusted App */ -memcpy (sess_arg.uuid, rng_device->id.uuid.b,TEE_IOCTL_UUID_LEN ); +export_uuid (sess_arg.uuid, &rng_device->id.uuid); sess_arg.clnt_login =TEE_IOCTL_LOGIN_PUBLIC ; sess_arg.num_params =0 ;
Signature · 1 line
2.26.1
Quoted 11 lines · Andy Shevchenko
There is
export_uuid()function which exportsuuid_tto the u8 array. Use it instead of open coding variant.This allows to hide the
uuid_tinternals.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/char/hw_random/optee-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Sumit Garg <[email protected]>
Quoted 16 lines
drivers/char/hw_random/optee-rng.c +1
-2@@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev)return -ENODEV ;/* Open session with hwrng Trusted App */ -memcpy (sess_arg.uuid, rng_device->id.uuid.b,TEE_IOCTL_UUID_LEN ); +export_uuid (sess_arg.uuid, &rng_device->id.uuid); sess_arg.clnt_login =TEE_IOCTL_LOGIN_PUBLIC ; sess_arg.num_params =0 ; --2.26.1
Herbert Xu
maintainerQuoted 9 lines · Andy Shevchenko
There is
export_uuid()function which exportsuuid_tto the u8 array. Use it instead of open coding variant.This allows to hide the
uuid_tinternals.Signed-off-by Andy Shevchenko <[email protected]>--- drivers/char/hw_random/optee-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt