Skip to contentSkip to conversation

Deferred inode inactivation and nonblocking inode reclaim

DISCUSSION Darrick J. Wong 2 participants 3 messages Apr 22, 2020 – Apr 23, 2020

lore
Share & tools
lore
#0 lore raw

Hi everyone,

Here's a jumping-off point for a discussion about my patchset that implements deferred inode inactivation and Dave's patchset that moves inode buffer flushing out of reclaim.

The inactivation series moves the transactional updates that happen after a file loses its last reference (truncating attr/data forks, freeing the inode) out of drop_inode and reclaim by moving all that work to an intermediate workqueue. This all can be done internally to XFS.

The reclaim series (Dave) removes inode flushing from reclaim, which means that xfs stop holding up memory reclaim on IO. It also contains a fair amount of surgery to the memory shrinker code, which is an added impediment to getting this series reviewed and upstream.

Because of the extra review needed for the reclaim series, does it make sense to keep the two separate? Deferring inactivation alone won't get rid of the inode flushing that goes on in reclaim, but it at least means that we can handle things like "rm -rf $dir" a little more efficiently in that we can do all the directory shrinking at once and then handle the unlinked inodes in on-disk order. It would also, erm, help me reduce the size of my dev tree. :)

--D

#1 lore raw

Heh, only after I sent this did I think about tagging the subject line and sending links to git branches when applicable.

Quoted 7 lines · Darrick J. Wong

Hi everyone,

Here's a jumping-off point for a discussion about my patchset that implements deferred inode inactivation and Dave's patchset that moves inode buffer flushing out of reclaim.

The inactivation series moves the transactional updates that happen

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=deferred-inactivation

Quoted 5 lines

after a file loses its last reference (truncating attr/data forks, freeing the inode) out of drop_inode and reclaim by moving all that work to an intermediate workqueue. This all can be done internally to XFS.

The reclaim series (Dave) removes inode flushing from reclaim, which

https://lore.kernel.org/linux-xfs/[email protected]/

--D

Quoted 13 lines

means that xfs stop holding up memory reclaim on IO. It also contains a fair amount of surgery to the memory shrinker code, which is an added impediment to getting this series reviewed and upstream.

Because of the extra review needed for the reclaim series, does it make sense to keep the two separate? Deferring inactivation alone won't get rid of the inode flushing that goes on in reclaim, but it at least means that we can handle things like "rm -rf $dir" a little more efficiently in that we can do all the directory shrinking at once and then handle the unlinked inodes in on-disk order. It would also, erm, help me reduce the size of my dev tree. :)

--D

#2 lore raw
Quoted 19 lines · Darrick J. Wong

Heh, only after I sent this did I think about tagging the subject line and sending links to git branches when applicable.

Quoted 7 lines · Darrick J. Wong

Hi everyone,

Here's a jumping-off point for a discussion about my patchset that implements deferred inode inactivation and Dave's patchset that moves inode buffer flushing out of reclaim.

The inactivation series moves the transactional updates that happen

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=deferred-inactivation

Quoted 4 lines

after a file loses its last reference (truncating attr/data forks, freeing the inode) out of drop_inode and reclaim by moving all that work to an intermediate workqueue. This all can be done internally to XFS.

Quoted 10 lines
Quoted 1 line

The reclaim series (Dave) removes inode flushing from reclaim, which

https://lore.kernel.org/linux-xfs/[email protected]/

--D

Quoted 4 lines

means that xfs stop holding up memory reclaim on IO. It also contains a fair amount of surgery to the memory shrinker code, which is an added impediment to getting this series reviewed and upstream.

+CC: Chris Mason

And here is a link to one of the famous bug reports:
https://lore.kernel.org/linux-xfs/[email protected]/
which also includes a reference to Chris's simoop reproducer.

How about bringing in some FB engineers to the task force to help with reviewing the memory shrinker changes and with testing?
I believe it is in the best interest of the wider filesystem community to expedite development of this solution.

Thanks,
Amir.