drm/amd/display: remove redundant assignment to variable ret
PATCH 1/1 drm/amd/display: remove redundant assignment to variable ret
From: Colin Ian King <[email protected]>
The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1 -1
@@ -4231,7 +4231,7 @@ void dpcd_set_source_specific_data(struct dc_link *link) {const uint32_t post_oui_delay =30 ;// 30ms uint8_t dspc =0 ; -enum dc_status ret =DC_ERROR_UNEXPECTED ; +enum dc_status ret; ret =core_link_read_dpcd (link,DP_DOWN_STREAM_PORT_COUNT , &dspc,sizeof (dspc));
Signature · 1 line
2.25.1
Alex Deucher
AppliedQuoted 9 lines · Colin King
From: Colin Ian King <[email protected]>
The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>
Applied. Thanks!
Alex
Quoted 24 lines
--- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-2@@ -4231,7 +4231,7 @@ void dpcd_set_source_specific_data(struct dc_link *link) {const uint32_t post_oui_delay =30 ;// 30ms uint8_t dspc =0 ; -enum dc_status ret =DC_ERROR_UNEXPECTED ; +enum dc_status ret; ret =core_link_read_dpcd (link,DP_DOWN_STREAM_PORT_COUNT , &dspc,sizeof (dspc)); --2.25.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel