hsr: remove unnecessary code in hsr_dev_change_mtu()
Subsystems (3)
PATCH 1/1 hsr: remove unnecessary code in hsr_dev_change_mtu()
In the hsr_dev_change_mtu(), the 'dev' and 'master->dev' pointer are same. So, the 'master' variable and some code are unnecessary.
Signed-off-by Taehee Yoo <[email protected]>
--- net/hsr/hsr_device.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
net/hsr/hsr_device.c +1 -3
@@ -125,13 +125,11 @@ int hsr_get_max_mtu(struct hsr_priv *hsr)static int hsr_dev_change_mtu (struct net_device *dev,int new_mtu) {struct hsr_priv *hsr; -struct hsr_port *master; hsr =netdev_priv (dev); - master =hsr_port_get_hsr (hsr,HSR_PT_MASTER );if (new_mtu >hsr_get_max_mtu (hsr)) { -netdev_info (master->dev,"A HSR master's MTU cannot be greater than the smallest MTU of its slaves minus the HSR Tag length (%d octets).\n" , +netdev_info (dev,"A HSR master's MTU cannot be greater than the smallest MTU of its slaves minus the HSR Tag length (%d octets).\n" ,HSR_HLEN );return -EINVAL ; }
Signature · 1 line
2.17.1
From: Taehee Yoo <[email protected]>
Date: Fri, 24 Apr 2020 12:43:09 +0000
Quoted 4 lines
In the
hsr_dev_change_mtu(), the 'dev' and 'master->dev' pointer are same. So, the 'master' variable and some code are unnecessary.Signed-off-by Taehee Yoo <[email protected]>
Applied.