Skip to contentSkip to conversation

unicore32: do not evaluate compiler's library path when cleaning

PATCH In review Masahiro Yamada 2 participants 3 messages Apr 25, 2020 – May 1, 2020 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 unicore32: do not evaluate compiler's library path when cleaning

Since commit a83e4ca26af8 ("kbuild: remove cc-option switch from -Wframe-larger-than="), 'make ARCH=unicore32 clean' emits error messages as follows:

  $ make ARCH=unicore32 clean
  gcc: error: missing argument to '-Wframe-larger-than='
  gcc: error: missing argument to '-Wframe-larger-than='

We do not care compiler flags when cleaning.

Use the '=' operator for lazy expansion because we do not use GNU_LIBC_A or GNU_LIBGCC_A when cleaning.

Fixes a83e4ca26af8 ("kbuild: remove cc-option switch from -Wframe-larger-than=")

---

 arch/unicore32/lib/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/unicore32/lib/Makefile +2 -2
index 098981a01841..5af06645b8f0 100644
@@ -10,12 +10,12 @@ lib-y	+= strncpy_from_user.o strnlen_user.o
 lib-y	+= clear_user.o copy_page.o
 lib-y	+= copy_from_user.o copy_to_user.o
 
-GNU_LIBC_A		:= $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libc.a)
+GNU_LIBC_A		= $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libc.a)
 GNU_LIBC_A_OBJS		:= memchr.o memcpy.o memmove.o memset.o
 GNU_LIBC_A_OBJS		+= strchr.o strrchr.o
 GNU_LIBC_A_OBJS		+= rawmemchr.o			# needed by strrchr.o
 
-GNU_LIBGCC_A		:= $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libgcc.a)
+GNU_LIBGCC_A		= $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libgcc.a)
 GNU_LIBGCC_A_OBJS	:= _ashldi3.o _ashrdi3.o _lshrdi3.o
 GNU_LIBGCC_A_OBJS	+= _divsi3.o _modsi3.o _ucmpdi2.o _umodsi3.o _udivsi3.o
 
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Masahiro Yamada

Since commit a83e4ca26af8 ("kbuild: remove cc-option switch from -Wframe-larger-than="), 'make ARCH=unicore32 clean' emits error messages as follows:

Quoted 8 lines
  $ make ARCH=unicore32 clean
  gcc: error: missing argument to '-Wframe-larger-than='
  gcc: error: missing argument to '-Wframe-larger-than='

We do not care compiler flags when cleaning.

Use the '=' operator for lazy expansion because we do not use GNU_LIBC_A or GNU_LIBGCC_A when cleaning.

So many assignment operators!
https://www.gnu.org/software/make/manual/html_node/Setting.html

Quoted 30 lines
Fixes a83e4ca26af8 ("kbuild: remove cc-option switch from -Wframe-larger-than=")

---

 arch/unicore32/lib/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/unicore32/lib/Makefile +2 -3
index 098981a01841..5af06645b8f0 100644
@@ -10,12 +10,12 @@ lib-y       += strncpy_from_user.o strnlen_user.o
 lib-y  += clear_user.o copy_page.o
 lib-y  += copy_from_user.o copy_to_user.o
 
-GNU_LIBC_A             := $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libc.a)
+GNU_LIBC_A             = $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libc.a)
 GNU_LIBC_A_OBJS                := memchr.o memcpy.o memmove.o memset.o
 GNU_LIBC_A_OBJS                += strchr.o strrchr.o
 GNU_LIBC_A_OBJS                += rawmemchr.o                  # needed by strrchr.o
 
-GNU_LIBGCC_A           := $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libgcc.a)
+GNU_LIBGCC_A           = $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libgcc.a)
 GNU_LIBGCC_A_OBJS      := _ashldi3.o _ashrdi3.o _lshrdi3.o
 GNU_LIBGCC_A_OBJS      += _divsi3.o _modsi3.o _ucmpdi2.o _umodsi3.o _udivsi3.o
 
--

2.25.1

Signature · 2 lines
Thanks,
~Nick Desaulniers
#2 lore raw
In reply to Masahiro Yamada
Quoted 9 lines · Masahiro Yamada

Since commit a83e4ca26af8 ("kbuild: remove cc-option switch from -Wframe-larger-than="), 'make ARCH=unicore32 clean' emits error messages as follows:

  $ make ARCH=unicore32 clean
  gcc: error: missing argument to '-Wframe-larger-than='
  gcc: error: missing argument to '-Wframe-larger-than='
Quoted 9 lines

We do not care compiler flags when cleaning.

Use the '=' operator for lazy expansion because we do not use GNU_LIBC_A or GNU_LIBGCC_A when cleaning.

Fixes a83e4ca26af8 ("kbuild: remove cc-option switch from -Wframe-larger-than=")

---

Applied to linux-kbuild.

Quoted 25 lines
 arch/unicore32/lib/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/unicore32/lib/Makefile +2 -3
index 098981a01841..5af06645b8f0 100644
@@ -10,12 +10,12 @@ lib-y       += strncpy_from_user.o strnlen_user.o
 lib-y  += clear_user.o copy_page.o
 lib-y  += copy_from_user.o copy_to_user.o
 
-GNU_LIBC_A             := $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libc.a)
+GNU_LIBC_A             = $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libc.a)
 GNU_LIBC_A_OBJS                := memchr.o memcpy.o memmove.o memset.o
 GNU_LIBC_A_OBJS                += strchr.o strrchr.o
 GNU_LIBC_A_OBJS                += rawmemchr.o                  # needed by strrchr.o
 
-GNU_LIBGCC_A           := $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libgcc.a)
+GNU_LIBGCC_A           = $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libgcc.a)
 GNU_LIBGCC_A_OBJS      := _ashldi3.o _ashrdi3.o _lshrdi3.o
 GNU_LIBGCC_A_OBJS      += _divsi3.o _modsi3.o _ucmpdi2.o _umodsi3.o _udivsi3.o
 
--

2.25.1

Signature · 2 lines
Best Regards
Masahiro Yamada