rtc: Do not sync CMOS clock when CONFIG_RTC_SYSTOHC is not set
PATCH 1/1 rtc: Do not sync CMOS clock when CONFIG_RTC_SYSTOHC is not set
According to documentation in 'drivers/rtc/Kconfig', if 'CONFIG_RTC_SYSTOHC' is set, then:
'''
The system time (wall clock) will be stored in the RTC specified by RTC_HCTOSYS_DEVICE approximately every 11 minutes if userspace reports synchronized NTP status.
'''
However in reality, even if 'CONFIG_RTC_SYSTOHC' is not set, the RTC is still sometimes synced with the system time: at least when the RTC driver is 'rtc_cmos', in certain situations. This commit prevents that.
--- kernel/time/ntp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/time/ntp.c +3 -3
@@ -535,9 +535,6 @@ static void sync_rtc_clock(void)struct timespec64 adjust, now;int rc; -if (!IS_ENABLED (CONFIG_RTC_SYSTOHC )) -return ; -ktime_get_real_ts64 (&now); adjust = now;
@@ -613,6 +610,9 @@ static bool sync_cmos_clock(void)*/ static void sync_hw_clock (struct work_struct *work) { +if (!IS_ENABLED (CONFIG_RTC_SYSTOHC )) +return ; +if (!ntp_synced ())return ;
Signature · 1 line
2.26.2
Quoted 9 lines · Leonid Bloch
According to documentation in '
drivers/rtc/Kconfig', if 'CONFIG_RTC_SYSTOHC' is set, then:'''
The system time (wall clock) will be stored in the RTC specified byRTC_HCTOSYS_DEVICEapproximately every 11 minutes if userspace reports synchronized NTP status.
'''
Quoted 4 lines
However in reality, even if '
CONFIG_RTC_SYSTOHC' is not set, the RTC is still sometimes synced with the system time: at least when the RTC driver is 'rtc_cmos', in certain situations. This commit prevents that.
But in reality sync_cmos_clock() depends on CONFIG_GENERIC_CMOS_UPDATE and has nothing to do with CONFIG_RTC_SYSTOHC.
That's a historical leftover from the days where RTCs were strictly a platform/architecture specific issue.
Your change would break all architectures which still depend on that.
Thanks,
tglx
Quoted 16 lines · Thomas Gleixner
Quoted 9 lines · Leonid Bloch
According to documentation in '
drivers/rtc/Kconfig', if 'CONFIG_RTC_SYSTOHC' is set, then:'''
The system time (wall clock) will be stored in the RTC specified byRTC_HCTOSYS_DEVICEapproximately every 11 minutes if userspace reports synchronized NTP status.
'''Quoted 4 lines
However in reality, even if '
CONFIG_RTC_SYSTOHC' is not set, the RTC is still sometimes synced with the system time: at least when the RTC driver is 'rtc_cmos', in certain situations. This commit prevents that.
Quoted 7 lines
But in reality
sync_cmos_clock()depends onCONFIG_GENERIC_CMOS_UPDATEand has nothing to do withCONFIG_RTC_SYSTOHC.That's a historical leftover from the days where RTCs were strictly a platform/architecture specific issue.
Your change would break all architectures which still depend on that.
Thanks for your clarification, Thomas!
Then maybe it's worth to reword the help string in drivers/rtc/Kconfig? Because one can unset 'CONFIG_RTC_SYSTOHC' and expect that the RTC clock will not be updated by NTP syncs, while in reality it will be, unless 'CONFIG_GENERIC_CMOS_UPDATE' is unset, and it is selected automatically by X86.
Regards,
Leonid.
___
Quoted 5 lines
Thanks,
tglx