Skip to contentSkip to conversation

arm64: dts: allwinner: h6: Use dedicated CPU OPP table for Tanix TX6

PATCH In review Clément Péron 2 participants 4 messages Apr 26, 2020 – Apr 28, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: allwinner: h6: Use dedicated CPU OPP table for Tanix TX6

Tanix TX6 has a fixed regulator. As DVFS is instructed to change voltage to meet OPP table. The DVFS is not working as expected.

Introduce a dedicated OPP Table where voltage are equals to the fixed regulator.

Fixes add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")
---
 .../sun50i-h6-tanix-tx6-cpu-opp.dtsi          | 116 ++++++++++++++++++
 .../dts/allwinner/sun50i-h6-tanix-tx6.dts     |   2 +-
 2 files changed, 117 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6-cpu-opp.dtsi
arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6-cpu-opp.dtsi new file +116 -0
new file mode 100644
index 000000000000..062940115563
@@ -0,0 +1,116 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (C) 2020 Clément Péron <[email protected]>
+
+/ {
+	cpu_opp_table: cpu-opp-table {
+		compatible = "allwinner,sun50i-h6-operating-points";
+		nvmem-cells = <&cpu_speed_grade>;
+		opp-shared;
+
+		opp@480000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <480000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@720000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <720000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@816000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <816000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@888000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <888000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@1080000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <1080000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@1320000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <1320000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@1488000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <1488000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@1608000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <1608000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@1704000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <1704000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+
+		opp@1800000000 {
+			clock-latency-ns = <244144>; /* 8 32k periods */
+			opp-hz = /bits/ 64 <1800000000>;
+
+			opp-microvolt-speed0 = <1135000>;
+			opp-microvolt-speed1 = <1135000>;
+			opp-microvolt-speed2 = <1135000>;
+		};
+	};
+};
+
+&cpu0 {
+	operating-points-v2 = <&cpu_opp_table>;
+};
+
+&cpu1 {
+	operating-points-v2 = <&cpu_opp_table>;
+};
+
+&cpu2 {
+	operating-points-v2 = <&cpu_opp_table>;
+};
+
+&cpu3 {
+	operating-points-v2 = <&cpu_opp_table>;
+};
arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts +1 -1
index be81330db14f..3eaa4f49e3d3 100644
@@ -4,7 +4,7 @@
 /dts-v1/;
 
 #include "sun50i-h6.dtsi"
-#include "sun50i-h6-cpu-opp.dtsi"
+#inlcude "sun50i-h6-tanix-tx6-cpu-opp.dtsi"
 
 #include <dt-bindings/gpio/gpio.h>
 
Signature · 1 line
2.20.1
#1 lore raw

Hi Warpme,

Quoted 10 lines · Clément Péron

Tanix TX6 has a fixed regulator. As DVFS is instructed to change voltage to meet OPP table. The DVFS is not working as expected.

Introduce a dedicated OPP Table where voltage are equals to the fixed regulator.

Fixes add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")

Could you confirm this patch fixed your issue?

If yes could you add your tested-by tag ?

Thanks,
Clement

Quoted 144 lines
---
 .../sun50i-h6-tanix-tx6-cpu-opp.dtsi          | 116 ++++++++++++++++++
 .../dts/allwinner/sun50i-h6-tanix-tx6.dts     |   2 +-
 2 files changed, 117 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6-cpu-opp.dtsi
arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6-cpu-opp.dtsi new file +116 -0
new file mode 100644
index 000000000000..062940115563
@@ -0,0 +1,116 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+// Copyright (C) 2020 Clément Péron <[email protected]>
+
+/ {
+       cpu_opp_table: cpu-opp-table {
+               compatible = "allwinner,sun50i-h6-operating-points";
+               nvmem-cells = <&cpu_speed_grade>;
+               opp-shared;
+
+               opp@480000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <480000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@720000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <720000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@816000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <816000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@888000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <888000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@1080000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <1080000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@1320000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <1320000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@1488000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <1488000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@1608000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <1608000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@1704000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <1704000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+
+               opp@1800000000 {
+                       clock-latency-ns = <244144>; /* 8 32k periods */
+                       opp-hz = /bits/ 64 <1800000000>;
+
+                       opp-microvolt-speed0 = <1135000>;
+                       opp-microvolt-speed1 = <1135000>;
+                       opp-microvolt-speed2 = <1135000>;
+               };
+       };
+};
+
+&cpu0 {
+       operating-points-v2 = <&cpu_opp_table>;
+};
+
+&cpu1 {
+       operating-points-v2 = <&cpu_opp_table>;
+};
+
+&cpu2 {
+       operating-points-v2 = <&cpu_opp_table>;
+};
+
+&cpu3 {
+       operating-points-v2 = <&cpu_opp_table>;
+};
arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts +1 -2
index be81330db14f..3eaa4f49e3d3 100644
@@ -4,7 +4,7 @@
 /dts-v1/;
 
 #include "sun50i-h6.dtsi"
-#include "sun50i-h6-cpu-opp.dtsi"
+#inlcude "sun50i-h6-tanix-tx6-cpu-opp.dtsi"
 
 #include <dt-bindings/gpio/gpio.h>
 
--

2.20.1

#2 lore raw
In reply to Clément Péron
Quoted 9 lines · Clément Péron

Tanix TX6 has a fixed regulator. As DVFS is instructed to change voltage to meet OPP table. The DVFS is not working as expected.

Introduce a dedicated OPP Table where voltage are equals to the fixed regulator.

Fixes add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")

I'm not really a big fan of duplicating the OPPs, since that would make an update of those very likely to be overlooked for that particular board (and since it's a board that not a lot of people have, it would be harder to notice too).

IIRC, removing the cpu-supply property should work as well?

Maxime

#3 lore raw

Hi Maxime,

Quoted 12 lines · Maxime Ripard
Quoted 9 lines · Clément Péron

Tanix TX6 has a fixed regulator. As DVFS is instructed to change voltage to meet OPP table. The DVFS is not working as expected.

Introduce a dedicated OPP Table where voltage are equals to the fixed regulator.

Fixes add1e27fb703 ("arm64: dts: allwinner: h6: Enable CPU opp tables for Tanix TX6")
Quoted 6 lines

I'm not really a big fan of duplicating the OPPs, since that would make an update of those very likely to be overlooked for that particular board (and since it's a board that not a lot of people have, it would be harder to notice too).

IIRC, removing the cpu-supply property should work as well?

Yes it would works also the OPP will provide a dummy regulator.

But as it has been introduced and there is a cpu regulator in the real life. I thought it was a bit a hack to just remove it but as you wish.

Regards,
Clement

Quoted 2 lines

Maxime