ath10k: sdio: add support for rx/tx bitrate reporting
PATCH v2 3/4 ath10k: add bitrate parse for peer stats info
In reply to Wen GongThe rate code and rate kbps report by WMI_TLV_PEER_STATS_INFO_EVENTID from firmware contains all the bitrate info which include OFDM, CCK, HT/VHT, and mac80211 need the struct rate_info which include below parameters:
flags: bitflag of flags from &enum rate_info_flags
mcs: mcs index if struct describes an HT/VHT/HE rate
legacy: bitrate in 100kbit/s for 802.11abg
nss: number of streams (VHT & HE only)
bw: bandwidth (from &enum rate_info_bw)
For OFDM/CCK, its rate kbps indicate the bitrate, for HT/VHT, mac80211 need the above 5 parameters to cacluate the bitrate and show by iw.
After parse the bitrate info, iw show the correct rx bitrate:
localhost ~ # iw wlan0 link
rx bitrate: 234.0 MBit/s VHT-MCS 3 80MHz VHT-NSS 2 rx bitrate: 40.5 MBit/s MCS 2 40MHz rx bitrate: 72.2 MBit/s MCS 7 short GI rx bitrate: 54.0 MBit/s rx bitrate: 48.0 MBit/s
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
--- drivers/net/wireless/ath/ath10k/core.h | 20 +++ drivers/net/wireless/ath/ath10k/mac.c | 161 ++++++++++++++++++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 9 ++ 3 files changed, 190 insertions(+)
drivers/net/wireless/ath/ath10k/core.h +20 -0
@@ -149,6 +149,26 @@ static inline u32 host_interest_item_address(u32 item_offset)return QCA988X_HOST_INTEREST_ADDRESS + item_offset; } +enum ath10k_phy_mode { +ATH10K_PHY_MODE_LEGACY =0 , +ATH10K_PHY_MODE_HT =1 , +ATH10K_PHY_MODE_VHT =2 , +}; + +/* Data rate 100KBPS based on IE Index */ +struct ath10k_index_ht_data_rate_type { +u8 beacon_rate_index; +u16 supported_rate[4 ]; +}; + +/* Data rate 100KBPS based on IE Index */ +struct ath10k_index_vht_data_rate_type { +u8 beacon_rate_index; +u16 supported_VHT80_rate[2 ]; +u16 supported_VHT40_rate[2 ]; +u16 supported_VHT20_rate[2 ]; +}; +struct ath10k_bmi {bool done_sent; };
drivers/net/wireless/ath/ath10k/mac.c +161 -0
173 lines not on this page · raw message
drivers/net/wireless/ath/ath10k/wmi-tlv.h +9 -0
@@ -2174,6 +2174,15 @@ struct wmi_tlv_peer_stats_info {__le32 peer_rssi_per_chain[WMI_TLV_MAX_CHAINS ]; } __packed; +#define HW_RATECODE_PREAM_V1_MASK GENMASK(10, 8) +#define WMI_TLV_GET_HW_RC_PREAM_V1 (rc) FIELD_GET(HW_RATECODE_PREAM_V1_MASK, rc) + +#define HW_RATECODE_NSS_V1_MASK GENMASK(7, 5) +#define WMI_TLV_GET_HW_RC_NSS_V1 (rc) FIELD_GET(HW_RATECODE_NSS_V1_MASK, rc) + +#define HW_RATECODE_RATE_V1_MASK GENMASK(4, 0) +#define WMI_TLV_GET_HW_RC_RATE_V1 (rc) FIELD_GET(HW_RATECODE_RATE_V1_MASK, rc) +struct wmi_tlv_p2p_noa_ev {__le32 vdev_id; } __packed;
Signature · 1 line
2.23.0
PATCH v2 4/4 ath10k: correct tx bitrate of iw for SDIO
In reply to Wen GongFor legacy mode, tx bitrate not show correct sometimes, for example:
iw wlan0 link
Connected to 8c:21:0a:b3:5a:64 (on wlan0)
SSID: tplinkgw
freq: 2462
RX: 19672 bytes (184 packets)
TX: 9851 bytes (87 packets)
signal: -51 dBm
rx bitrate: 54.0 MBit/s
tx bitrate: 2.8 MBit/sThis patch use the tx bitrate info from WMI_TLV_PEER_STATS_INFO_EVENTID report from firmware, and tx bitrate show correct.
iw wlan0 link
Connected to 8c:21:0a:b3:5a:64 (on wlan0)
SSID: tplinkgw
freq: 2462
RX: 13973 bytes (120 packets)
TX: 6737 bytes (57 packets)
signal: -52 dBm
rx bitrate: 54.0 MBit/s
tx bitrate: 54.0 MBit/sThis patch only effect SDIO chip, ath10k_mac_sta_get_peer_stats_info has check for bitrate_statistics of hw_params, it is enabled only for "qca6174 hw3.2 sdio".
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
--- drivers/net/wireless/ath/ath10k/core.h | 2 ++ drivers/net/wireless/ath/ath10k/mac.c | 10 ++++++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 ++ 3 files changed, 14 insertions(+)
drivers/net/wireless/ath/ath10k/core.h +2 -0
@@ -526,6 +526,8 @@ struct ath10k_sta {u32 rx_rate_code;u32 rx_bitrate_kbps; +u32 tx_rate_code; +u32 tx_bitrate_kbps;struct work_struct update_wk;u64 rx_duration;struct ath10k_htt_tx_stats *tx_stats;
drivers/net/wireless/ath/ath10k/mac.c +10 -0
@@ -8502,6 +8502,16 @@ static void ath10k_mac_sta_get_peer_stats_info(struct ath10k *ar, arsta->rx_rate_code =0 ; arsta->rx_bitrate_kbps =0 ; } + +if (arsta->tx_rate_code !=0 && arsta->tx_bitrate_kbps !=0 ) { +ath10k_mac_parse_bitrate (ar, arsta->tx_rate_code, + arsta->tx_bitrate_kbps, + &sinfo->txrate); + + sinfo->filled |=BIT_ULL (NL80211_STA_INFO_TX_BITRATE ); + arsta->tx_rate_code =0 ; + arsta->tx_bitrate_kbps =0 ; + } } static void ath10k_sta_statistics(struct ieee80211_hw *hw,
drivers/net/wireless/ath/ath10k/wmi-tlv.c +2 -0
@@ -249,6 +249,8 @@ static int ath10k_wmi_tlv_parse_peer_stats_info(struct ath10k *ar, u16 tag, u16 arsta = (struct ath10k_sta *)sta->drv_priv; arsta->rx_rate_code =__le32_to_cpu (stat->last_rx_rate_code); arsta->rx_bitrate_kbps =__le32_to_cpu (stat->last_rx_bitrate_kbps); + arsta->tx_rate_code =__le32_to_cpu (stat->last_tx_rate_code); + arsta->tx_bitrate_kbps =__le32_to_cpu (stat->last_tx_bitrate_kbps);return 0 ; }
Signature · 1 line
2.23.0
v2 cover ath10k: sdio: add support for rx/tx bitrate reporting
v2: rebased to ath-next of 04/27
iw wlan0 link/iw wlan0 station dump show the wrong bitrate for rx/tx. wrong example:
rx bitrate: 6.0 MBit/s
tx bitrate: 2.8 MBit/s
These patches correct them.
rx bitrate: 234.0 MBit/s VHT-MCS 3 80MHz VHT-NSS 2 rx bitrate: 40.5 MBit/s MCS 2 40MHz
rx bitrate: 72.2 MBit/s MCS 7 short GI
rx bitrate: 54.0 MBit/s
rx bitrate: 48.0 MBit/s
tx bitrate: 54.0 MBit/s
Wen Gong (4):
ath10k: enable firmware peer stats info for wmi tlv
ath10k: add rx bitrate report for SDIO
ath10k: add bitrate parse for peer stats info
ath10k: correct tx bitrate of iw for SDIO
drivers/net/wireless/ath/ath10k/core.c | 2 + drivers/net/wireless/ath/ath10k/core.h | 25 +++ drivers/net/wireless/ath/ath10k/hw.h | 3 + drivers/net/wireless/ath/ath10k/mac.c | 216 ++++++++++++++++++++++ drivers/net/wireless/ath/ath10k/wmi-ops.h | 30 +++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 121 ++++++++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 110 +++++++++++ drivers/net/wireless/ath/ath10k/wmi.h | 9 + 8 files changed, 516 insertions(+)
Signature · 6 lines
2.23.0 _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
PATCH v2 1/4 ath10k: enable firmware peer stats info for wmi tlv
For wmi tlv type, firmware disable peer stats info by default, after enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware.
Enable it will only set a flag in firmware, firmware will not report it without receive request WMI command.
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
--- drivers/net/wireless/ath/ath10k/mac.c | 5 +++++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 1 + drivers/net/wireless/ath/ath10k/wmi-tlv.h | 1 + drivers/net/wireless/ath/ath10k/wmi.h | 1 + 4 files changed, 8 insertions(+)
drivers/net/wireless/ath/ath10k/mac.c +5 -0
@@ -2959,6 +2959,11 @@ static void ath10k_bss_assoc(struct ieee80211_hw *hw, arvif->aid = bss_conf->aid;ether_addr_copy (arvif->bssid, bss_conf->bssid); + ret =ath10k_wmi_pdev_set_param (ar, + ar->wmi.pdev_param->peer_stats_info_enable,1 ); +if (ret) +ath10k_warn (ar,"failed to enable peer stats info: %d\n" , ret); + ret =ath10k_wmi_vdev_up (ar, arvif->vdev_id, arvif->aid, arvif->bssid);if (ret) { ath10k_warn(ar, "failed to set vdev %d up: %d\n",
drivers/net/wireless/ath/ath10k/wmi-tlv.c +1 -0
@@ -4269,6 +4269,7 @@ static struct wmi_pdev_param_map wmi_tlv_pdev_param_map = { .arp_dstaddr = WMI_PDEV_PARAM_UNSUPPORTED, .rfkill_config = WMI_TLV_PDEV_PARAM_HW_RFKILL_CONFIG, .rfkill_enable = WMI_TLV_PDEV_PARAM_RFKILL_ENABLE, + .peer_stats_info_enable = WMI_TLV_PDEV_PARAM_PEER_STATS_INFO_ENABLE, };static struct wmi_peer_param_map wmi_tlv_peer_param_map = {
drivers/net/wireless/ath/ath10k/wmi-tlv.h +1 -0
@@ -451,6 +451,7 @@ enum wmi_tlv_pdev_param {WMI_TLV_PDEV_PARAM_VDEV_RATE_STATS_UPDATE_PERIOD ,WMI_TLV_PDEV_PARAM_TXPOWER_REASON_NONE ,WMI_TLV_PDEV_PARAM_TXPOWER_REASON_SAR , +WMI_TLV_PDEV_PARAM_PEER_STATS_INFO_ENABLE =0x8b , WMI_TLV_PDEV_PARAM_TXPOWER_REASON_MAX, };
drivers/net/wireless/ath/ath10k/wmi.h +1 -0
@@ -3798,6 +3798,7 @@ struct wmi_pdev_param_map {u32 enable_btcoex;u32 rfkill_config;u32 rfkill_enable; +u32 peer_stats_info_enable; };#define WMI_PDEV_PARAM_UNSUPPORTED 0
Signature · 1 line
2.23.0
PATCH v2 2/4 ath10k: add rx bitrate report for SDIO
In reply to Wen GongFor SDIO chip, its rx indication is struct htt_rx_indication_hl, which does not include the bitrate info as well as PCIe, for PCIe, it use function ath10k_htt_rx_h_rates to parse the bitrate info in struct rx_ppdu_start and then report it to mac80211 via ieee80211_rx_status.
SDIO does not have the same info as PCIe, then iw command can not get the rx bitrate by "iw wlan0 station dump".
for example, it always show 6.0 MBit/s
localhost ~ # iw wlan0 link
Connected to 3c:28:6d:96:fd:69 (on wlan0)
SSID: kukui_test freq: 5180 RX: 111800 bytes (595 packets) TX: 35419 bytes (202 packets) signal: -41 dBm rx bitrate: 6.0 MBit/s
This patch is to send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware for ath10k_sta_statistics and save the rx bitrate for WMI event WMI_TLV_PEER_STATS_INFO_EVENTID.
This patch only effect SDIO chip, ath10k_mac_sta_get_peer_stats_info has check for bitrate_statistics of hw_params, this patch only enable it for "qca6174 hw3.2 sdio".
Tested with QCA6174 SDIO firmware WLAN.RMH.4.4.1-00042.
--- drivers/net/wireless/ath/ath10k/core.c | 2 + drivers/net/wireless/ath/ath10k/core.h | 3 + drivers/net/wireless/ath/ath10k/hw.h | 3 + drivers/net/wireless/ath/ath10k/mac.c | 40 ++++++++ drivers/net/wireless/ath/ath10k/wmi-ops.h | 30 ++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.c | 118 ++++++++++++++++++++++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 100 ++++++++++++++++++ drivers/net/wireless/ath/ath10k/wmi.h | 8 ++ 8 files changed, 304 insertions(+)
drivers/net/wireless/ath/ath10k/core.c +2 -0
@@ -190,6 +190,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { .uart_pin_workaround = true, .tx_stats_over_pktlog = false, .bmi_large_size_download = true, + .supports_peer_stats_info = true, }, { .id = QCA6174_HW_2_1_VERSION,
@@ -3277,6 +3278,7 @@ struct ath10k *ath10k_core_create(size_t priv_size, struct device *dev,init_completion (&ar->thermal.wmi_sync);init_completion (&ar->bss_survey_done);init_completion (&ar->peer_delete_done); +init_completion (&ar->peer_stats_info_complete);INIT_DELAYED_WORK (&ar->scan.timeout, ath10k_scan_timeout_work);
drivers/net/wireless/ath/ath10k/core.h +3 -0
@@ -504,6 +504,8 @@ struct ath10k_sta {u32 tx_failed;u32 last_tx_bitrate; +u32 rx_rate_code; +u32 rx_bitrate_kbps;struct work_struct update_wk;u64 rx_duration;struct ath10k_htt_tx_stats *tx_stats;
@@ -1089,6 +1091,7 @@ struct ath10k {int last_wmi_vdev_start_status;struct completion vdev_setup_done;struct completion vdev_delete_done; +struct completion peer_stats_info_complete;struct workqueue_struct *workqueue;/* Auxiliary workqueue */
drivers/net/wireless/ath/ath10k/hw.h +3 -0
@@ -623,6 +623,9 @@ struct ath10k_hw_params {/* tx stats support over pktlog */ bool tx_stats_over_pktlog; + +/* provides bitrates for sta_statistics using WMI_TLV_PEER_STATS_INFO_EVENTID */ +bool supports_peer_stats_info; };struct htt_rx_desc ;
drivers/net/wireless/ath/ath10k/mac.c +40 -0
@@ -8305,6 +8305,44 @@ static void ath10k_mac_op_sta_pre_rcu_remove(struct ieee80211_hw *hw, peer->removed = true; } +static void ath10k_mac_sta_get_peer_stats_info (struct ath10k *ar, +struct ieee80211_sta *sta, +struct station_info *sinfo) +{ +struct ath10k_sta *arsta = (struct ath10k_sta *)sta->drv_priv; +struct ath10k_peer *peer; +unsigned long time_left; +int ret; + +if (!(ar->hw_params.supports_peer_stats_info && + arsta->arvif->vdev_type ==WMI_VDEV_TYPE_STA )) +return ; + +spin_lock_bh (&ar->data_lock); + peer =ath10k_peer_find (ar, arsta->arvif->vdev_id, sta->addr); +spin_unlock_bh (&ar->data_lock); +if (!peer) +return ; + +reinit_completion (&ar->peer_stats_info_complete); + + ret =ath10k_wmi_request_peer_stats_info (ar, + arsta->arvif->vdev_id, +WMI_REQUEST_ONE_PEER_STATS_INFO , + arsta->arvif->bssid, +0 ); +if (ret && ret != -EOPNOTSUPP ) { +ath10k_warn (ar,"could not request peer stats info: %d\n" , ret); +return ; + } + + time_left =wait_for_completion_timeout (&ar->peer_stats_info_complete,3 *HZ ); +if (time_left ==0 ) { +ath10k_warn (ar,"timed out waiting peer stats info\n" ); +return ; + } +} + static void ath10k_sta_statistics(struct ieee80211_hw *hw, struct ieee80211_vif *vif, struct ieee80211_sta *sta,
@@ -8340,6 +8378,8 @@ static void ath10k_sta_statistics(struct ieee80211_hw *hw, sinfo->tx_failed = arsta->tx_failed; sinfo->filled |=BIT_ULL (NL80211_STA_INFO_TX_FAILED ); } + +ath10k_mac_sta_get_peer_stats_info (ar, sta, sinfo); }static const struct ieee80211_ops ath10k_ops = {
drivers/net/wireless/ath/ath10k/wmi-ops.h +30 -0
@@ -126,6 +126,13 @@ struct wmi_ops {struct sk_buff *(*gen_pdev_set_wmm)(struct ath10k *ar,const struct wmi_wmm_params_all_arg *arg);struct sk_buff *(*gen_request_stats)(struct ath10k *ar,u32 stats_mask); +struct sk_buff *(*gen_request_peer_stats_info)(struct ath10k *ar, +u32 vdev_id, +enum +wmi_peer_stats_info_request_type + type, +u8 *addr, +u32 reset);struct sk_buff *(*gen_force_fw_hang)(struct ath10k *ar,enum wmi_force_fw_hang_type type,u32 delay_ms);
@@ -1064,6 +1071,29 @@ ath10k_wmi_request_stats(struct ath10k *ar, u32 stats_mask)return ath10k_wmi_cmd_send (ar, skb, ar->wmi.cmd->request_stats_cmdid); } +static inline int +ath10k_wmi_request_peer_stats_info (struct ath10k *ar, +u32 vdev_id, +enum wmi_peer_stats_info_request_type type, +u8 *addr, +u32 reset) +{ +struct sk_buff *skb; + +if (!ar->wmi.ops->gen_request_peer_stats_info) +return -EOPNOTSUPP ; + + skb = ar->wmi.ops->gen_request_peer_stats_info (ar, + vdev_id, + type, + addr, + reset); +if (IS_ERR (skb)) +return PTR_ERR (skb); + +return ath10k_wmi_cmd_send (ar, skb, ar->wmi.cmd->request_peer_stats_info_cmdid); +} +static inline int ath10k_wmi_force_fw_hang (struct ath10k *ar,enum wmi_force_fw_hang_type type,u32 delay_ms)
drivers/net/wireless/ath/ath10k/wmi-tlv.c +118 -0
148 lines not on this page · raw message
drivers/net/wireless/ath/ath10k/wmi-tlv.h +100 -0
124 lines not on this page · raw message
drivers/net/wireless/ath/ath10k/wmi.h +8 -0
@@ -940,6 +940,7 @@ struct wmi_cmd_map {u32 vdev_spectral_scan_configure_cmdid;u32 vdev_spectral_scan_enable_cmdid;u32 request_stats_cmdid; +u32 request_peer_stats_info_cmdid;u32 set_arp_ns_offload_cmdid;u32 network_list_offload_config_cmdid;u32 gtk_offload_cmdid;
@@ -4579,6 +4580,13 @@ struct wmi_request_stats_cmd {struct wlan_inst_rssi_args inst_rssi_args; } __packed; +enum wmi_peer_stats_info_request_type { +/* request stats of one specified peer */ +WMI_REQUEST_ONE_PEER_STATS_INFO =0x01 , +/* request stats of all peers belong to specified VDEV */ +WMI_REQUEST_VDEV_ALL_PEER_STATS_INFO =0x02 , +}; +/* Suspend option */ enum {/* suspend */
Signature · 1 line
2.23.0
Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv
In reply to Wen GongQuoted 11 lines · Wen Gong
For wmi tlv type, firmware disable peer stats info by default, after enable it, firmware will report
WMI_TLV_PEER_STATS_INFO_EVENTIDif ath10k sendWMI_TLV_REQUEST_PEER_STATS_INFO_CMDIDto firmware.Enable it will only set a flag in firmware, firmware will not report it without receive request WMI command.
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
Signed-off-by Wen Gong <[email protected]>Signed-off-by Kalle Valo <[email protected]>
4 patches applied to ath-next branch of ath.git, thanks.
2289bef25e32 ath10k: enable firmware peer stats info for wmi tlv 0f7cb26830a6 ath10k: add rx bitrate report for SDIO 3344b99d69ab ath10k: add bitrate parse for peer stats info 4cc02c7c1494 ath10k: correct tx bitrate of iw for SDIO
Signature · 8 lines
https://patchwork.kernel.org/patch/11511409/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list [email protected] http://lists.infradead.org/mailman/listinfo/ath10k
Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv
In reply to Wen GongQuoted 11 lines · Wen Gong
For wmi tlv type, firmware disable peer stats info by default, after enable it, firmware will report
WMI_TLV_PEER_STATS_INFO_EVENTIDif ath10k sendWMI_TLV_REQUEST_PEER_STATS_INFO_CMDIDto firmware.Enable it will only set a flag in firmware, firmware will not report it without receive request WMI command.
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
Signed-off-by Wen Gong <[email protected]>Signed-off-by Kalle Valo <[email protected]>
4 patches applied to ath-next branch of ath.git, thanks.
2289bef25e32 ath10k: enable firmware peer stats info for wmi tlv 0f7cb26830a6 ath10k: add rx bitrate report for SDIO 3344b99d69ab ath10k: add bitrate parse for peer stats info 4cc02c7c1494 ath10k: correct tx bitrate of iw for SDIO
Signature · 3 lines
https://patchwork.kernel.org/patch/11511409/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv
In reply to Kalle ValoQuoted 14 lines · Kalle Valo
Quoted 11 lines · Wen Gong
For wmi tlv type, firmware disable peer stats info by default, after enable it, firmware will report
WMI_TLV_PEER_STATS_INFO_EVENTIDif ath10k sendWMI_TLV_REQUEST_PEER_STATS_INFO_CMDIDto firmware.Enable it will only set a flag in firmware, firmware will not report it without receive request WMI command.
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
Signed-off-by Wen Gong <[email protected]>Signed-off-by Kalle Valo <[email protected]>
Quoted 6 lines
4 patches applied to ath-next branch of ath.git, thanks.
2289bef25e32ath10k: enable firmware peer stats info for wmi tlv0f7cb26830a6ath10k: add rx bitrate report for SDIO3344b99d69abath10k: add bitrate parse for peer stats info4cc02c7c1494ath10k: correct tx bitrate of iw for SDIO
I think these caused a new warning which I missed:
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: warning: incorrect type in assignment (different base types)drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: expected restricted __le32 [usertype] reset_after_requestdrivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: got unsigned int [usertype] reset
Please send a followup patch to fix that.
Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv
Quoted 23 lines · Kalle Valo
Quoted 14 lines · Kalle Valo
Quoted 11 lines · Wen Gong
For wmi tlv type, firmware disable peer stats info by default, after enable it, firmware will report
WMI_TLV_PEER_STATS_INFO_EVENTIDif ath10k sendWMI_TLV_REQUEST_PEER_STATS_INFO_CMDIDto firmware.Enable it will only set a flag in firmware, firmware will not report it without receive request WMI command.
Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
Signed-off-by Wen Gong <[email protected]>Signed-off-by Kalle Valo <[email protected]>Quoted 6 lines
4 patches applied to ath-next branch of ath.git, thanks.
2289bef25e32ath10k: enable firmware peer stats info for wmi tlv0f7cb26830a6ath10k: add rx bitrate report for SDIO3344b99d69abath10k: add bitrate parse for peer stats info4cc02c7c1494ath10k: correct tx bitrate of iw for SDIO
Quoted 8 lines
I think these caused a new warning which I missed:
drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: warning: incorrect type in assignment (different base types)drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: expected
restricted__le32[usertype]reset_after_requestdrivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: got unsigned int
[usertype] reset
ok. I will give new patch to fix the 3 warning.
Quoted 2 lines
Please send a followup patch to fix that.
_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k