Skip to contentSkip to conversation

perf scripts python: fix passing arguments to stackcollapse report

PATCH Michael Petlan 2 participants 3 messages Sep 6, 2021 – Sep 9, 2021 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Arnaldo, could you merge this?
It seems still valid.

Thank you.
Michael

Quoted 22 lines · Michael Petlan

The '--' prevented arguments from being passed to the script, such as:

  $ perf script report stackcollapse -i my_perf.data
---
 tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/scripts/python/bin/stackcollapse-report +1 -1
index 356b9656393d..21a356bd27f6 100755
@@ -1,3 +1,3 @@
 #!/bin/sh
 # description: produce callgraphs in short form for scripting use
-perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
+perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
Signature · 1 line
2.18.1
#2 lore raw

Em Mon, Sep 06, 2021 at 04:16:21PM +0200, Michael Petlan escreveu:

Quoted 2 lines

Hi Arnaldo, could you merge this?
It seems still valid.

Next time please reply to the original patch, that way b4 will find it from the Message-ID from your reply message.

I'm digging it from my inboxes, thanks for resending!

- Arnaldo

Quoted 27 lines

Thank you.
Michael

Quoted 22 lines · Michael Petlan

The '--' prevented arguments from being passed to the script, such as:

  $ perf script report stackcollapse -i my_perf.data
---
 tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/scripts/python/bin/stackcollapse-report +1 -1
index 356b9656393d..21a356bd27f6 100755
@@ -1,3 +1,3 @@
 #!/bin/sh
 # description: produce callgraphs in short form for scripting use
-perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
+perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
Signature · 1 line
2.18.1
Signature · 1 line
- Arnaldo
#3 lore raw
In reply to a message not in the archive

Em Mon, Apr 27, 2020 at 04:23:27PM +0200, Michael Petlan escreveu:

Quoted 3 lines

The '--' prevented arguments from being passed to the script, such as:

  $ perf script report stackcollapse -i my_perf.data

Thanks for resending, applied,

- Arnaldo

Quoted 17 lines
---
 tools/perf/scripts/python/bin/stackcollapse-report | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/scripts/python/bin/stackcollapse-report +1 -1
index 356b9656393d..21a356bd27f6 100755
@@ -1,3 +1,3 @@
 #!/bin/sh
 # description: produce callgraphs in short form for scripting use
-perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py -- "$@"
+perf script -s "$PERF_EXEC_PATH"/scripts/python/stackcollapse.py "$@"
Signature · 1 line
2.18.1
Signature · 1 line
- Arnaldo