Skip to contentSkip to conversation

Revert "Revert "driver core: Set fw_devlink to "permissive" behavior by default""

PATCH New Saravana Kannan 1 participant 1 message Apr 28, 2020 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "Revert "driver core: Set fw_devlink to "permissive" behavior by default""

This reverts commit 18555cb6db2373b9a5ec1f7572773fd58c77f9ba.

The reason[1] for the original revert has now been fixed by commit 00b247557858 ("driver core: Fix handling of fw_devlink=permissive"). So, this patch reverts the revert. Marek has also tested this patch with the fix mentioned above and confirmed that the issue has been fixed.

[1] - https://lore.kernel.org/lkml/CAGETcx8nbz-J1gLvoEKE_HgCcVGyV2o8rZeq_USFKM6=s7WmNg@mail.gmail.com/T/#m12dfb5dfd23805b84c49f4bb2238a8cce436c2f7
[2] - https://lore.kernel.org/lkml/CAGETcx8nbz-J1gLvoEKE_HgCcVGyV2o8rZeq_USFKM6=s7WmNg@mail.gmail.com/T/#m2408a6ce098b2ebf583ca8534329695923ae57fe

---
Greg,

Can you please queue this for 5.8?

Thanks,
Saravana

 drivers/base/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/core.c +1 -1
index 073045cb214e..c9045521596f 100644
@@ -2345,7 +2345,7 @@ static int device_private_init(struct device *dev)
 	return 0;
 }
 
-static u32 fw_devlink_flags;
+static u32 fw_devlink_flags = DL_FLAG_SYNC_STATE_ONLY;
 static int __init fw_devlink_setup(char *arg)
 {
 	if (!arg)
Signature · 1 line
2.26.2.303.gf8c07b1a785-goog