workqueue: Use IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO to remove redundant definitions and checks.
PATCH 1/1 workqueue: Use IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO to remove redundant definitions and checks.
Reduce code size.
Before:
text data bss dec hex filename 47510 5979 840 54329 d439 kernel/workqueue.o After: text data bss dec hex filename 47474 5979 840 54293 d415 kernel/workqueue.o
Signed-off-by Sean Fu <[email protected]>
--- kernel/workqueue.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
kernel/workqueue.c +2 -4
@@ -4197,7 +4197,6 @@ static int wq_clamp_max_active(int max_active, unsigned int flags,static int init_rescuer (struct workqueue_struct *wq) {struct worker *rescuer; -int ret;if (!(wq->flags &WQ_MEM_RECLAIM ))return 0 ;
@@ -4208,10 +4207,9 @@ static int init_rescuer(struct workqueue_struct *wq) rescuer->rescue_wq = wq; rescuer->task =kthread_create (rescuer_thread, rescuer,"%s" , wq->name); - ret =PTR_ERR_OR_ZERO (rescuer->task); -if (ret) { +if (IS_ERR (rescuer->task)) {kfree (rescuer); -return ret; +return PTR_ERR (rescuer->task); } wq->rescuer = rescuer;
Signature · 1 line
2.16.4
PATCH v2 1/1 workqueue: Use IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO.
Replace inline function PTR_ERR_OR_ZERO with IS_ERR and PTR_ERR to remove redundant parameter definitions and checks. Reduce code size.
Before:
text data bss dec hex filename 47510 5979 840 54329 d439 kernel/workqueue.o After: text data bss dec hex filename 47474 5979 840 54293 d415 kernel/workqueue.o
Signed-off-by Sean Fu <[email protected]>
---
Changes in v2:
- make commit message more clear.
kernel/workqueue.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
kernel/workqueue.c +2 -4
@@ -4197,7 +4197,6 @@ static int wq_clamp_max_active(int max_active, unsigned int flags,static int init_rescuer (struct workqueue_struct *wq) {struct worker *rescuer; -int ret;if (!(wq->flags &WQ_MEM_RECLAIM ))return 0 ;
@@ -4208,10 +4207,9 @@ static int init_rescuer(struct workqueue_struct *wq) rescuer->rescue_wq = wq; rescuer->task =kthread_create (rescuer_thread, rescuer,"%s" , wq->name); - ret =PTR_ERR_OR_ZERO (rescuer->task); -if (ret) { +if (IS_ERR (rescuer->task)) {kfree (rescuer); -return ret; +return PTR_ERR (rescuer->task); } wq->rescuer = rescuer;
--
2.16.4
Re: [PATCH v2] workqueue: Use IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO.
Quoted 11 lines · Sean Fu
Replace inline function
PTR_ERR_OR_ZEROwithIS_ERRandPTR_ERRto remove redundant parameter definitions and checks. Reduce code size.
Before:text data bss dec hex filename 47510 5979 840 54329 d439 kernel/workqueue.o After: text data bss dec hex filename 47474 5979 840 54293 d415 kernel/workqueue.oSigned-off-by Sean Fu <[email protected]>
Applied to wq/for-5.8.
Thanks.
Signature · 1 line
tejun