powerpc/64s: Fix early_init_mmu section mismatch
Nicholas Piggin
reviewerPATCH 1/1 powerpc/64s: Fix early_init_mmu section mismatch
Christian reports:
MODPOST vmlinux.o
WARNING: modpost: vmlinux.o(.text.unlikely+0x1a0): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.radix__early_init_mmu()
The function .early_init_mmu() references
the function __init .radix__early_init_mmu().
This is often because .early_init_mmu lacks a __init annotation or the annotation of .radix__early_init_mmu is wrong.
WARNING: modpost: vmlinux.o(.text.unlikely+0x1ac): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.hash__early_init_mmu()
The function .early_init_mmu() references
the function __init .hash__early_init_mmu().
This is often because .early_init_mmu lacks a __init annotation or the annotation of .hash__early_init_mmu is wrong.
The compiler is uninlining early_init_mmu and not putting it in an init section because there is no annotation. Add it.
--- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/include/asm/book3s/64/mmu.h +1 -1
@@ -208,7 +208,7 @@ void hash__early_init_devtree(void);void radix__early_init_devtree (void );extern void hash__early_init_mmu (void );extern void radix__early_init_mmu (void ); -static inline void early_init_mmu (void ) +static inline void __init early_init_mmu (void ) {if (radix_enabled ())return radix__early_init_mmu ();
Signature · 1 line
2.23.0
Hi All,
This patch wasn't included in the PowerPC fixes 5.7-4. Please add it.
Thanks,
Christian
Quoted 42 lines · Nicholas Piggin
Christian reports:
MODPOST vmlinux.o
WARNING: modpost:vmlinux.o(.text.unlikely+0x1a0): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.radix__early_init_mmu()
The function .early_init_mmu() references
the function__init.radix__early_init_mmu().
This is often because .early_init_mmu lacks a__initannotation or the annotation of .radix__early_init_mmu is wrong.WARNING: modpost:
vmlinux.o(.text.unlikely+0x1ac): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.hash__early_init_mmu()
The function .early_init_mmu() references
the function__init.hash__early_init_mmu().
This is often because .early_init_mmu lacks a__initannotation or the annotation of .hash__early_init_mmu is wrong.The compiler is uninlining
early_init_mmuand not putting it in an init section because there is no annotation. Add it.Reported-by Christian Zigotzky <[email protected]>Tested-by Christian Zigotzky <[email protected]>Signed-off-by Nicholas Piggin <[email protected]>--- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/include/asm/book3s/64/mmu.h +1
-1@@ -208,7 +208,7 @@ void hash__early_init_devtree(void);void radix__early_init_devtree (void );extern void hash__early_init_mmu (void );extern void radix__early_init_mmu (void ); -static inline void early_init_mmu (void ) +static inline void __init early_init_mmu (void ) {if (radix_enabled ())return radix__early_init_mmu ();
Michael Ellerman
reviewerQuoted 3 lines · Christian Zigotzky
Hi All,
This patch wasn't included in the PowerPC fixes 5.7-4. Please add it.
It's not an important bug. I'll take the patch for v5.8
cheers
Quoted 43 lines · Nicholas Piggin
Quoted 42 lines
Christian reports:
MODPOST vmlinux.o
WARNING: modpost:vmlinux.o(.text.unlikely+0x1a0): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.radix__early_init_mmu()
The function .early_init_mmu() references
the function__init.radix__early_init_mmu().
This is often because .early_init_mmu lacks a__initannotation or the annotation of .radix__early_init_mmu is wrong.WARNING: modpost:
vmlinux.o(.text.unlikely+0x1ac): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.hash__early_init_mmu()
The function .early_init_mmu() references
the function__init.hash__early_init_mmu().
This is often because .early_init_mmu lacks a__initannotation or the annotation of .hash__early_init_mmu is wrong.The compiler is uninlining
early_init_mmuand not putting it in an init section because there is no annotation. Add it.Reported-by Christian Zigotzky <[email protected]>Tested-by Christian Zigotzky <[email protected]>Signed-off-by Nicholas Piggin <[email protected]>--- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/include/asm/book3s/64/mmu.h +1
-1@@ -208,7 +208,7 @@ void hash__early_init_devtree(void);void radix__early_init_devtree (void );extern void hash__early_init_mmu (void );extern void radix__early_init_mmu (void ); -static inline void early_init_mmu (void ) +static inline void __init early_init_mmu (void ) {if (radix_enabled ())return radix__early_init_mmu ();
OK, thanks.
Quoted 54 lines · Michael Ellerman
Quoted 3 lines · Christian Zigotzky
Hi All,
This patch wasn't included in the PowerPC fixes 5.7-4. Please add it.
It's not an important bug. I'll take the patch for v5.8
cheers
Quoted 43 lines
Quoted 43 lines · Nicholas Piggin
Christian reports:
MODPOST vmlinux.o
WARNING: modpost:vmlinux.o(.text.unlikely+0x1a0): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.radix__early_init_mmu()
The function .early_init_mmu() references
the function__init.radix__early_init_mmu().
This is often because .early_init_mmu lacks a__initannotation or the annotation of .radix__early_init_mmu is wrong.WARNING: modpost:
vmlinux.o(.text.unlikely+0x1ac): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.hash__early_init_mmu()
The function .early_init_mmu() references
the function__init.hash__early_init_mmu().
This is often because .early_init_mmu lacks a__initannotation or the annotation of .hash__early_init_mmu is wrong.The compiler is uninlining
early_init_mmuand not putting it in an init section because there is no annotation. Add it.Reported-by Christian Zigotzky <[email protected]>Tested-by Christian Zigotzky <[email protected]>Signed-off-by Nicholas Piggin <[email protected]>--- arch/powerpc/include/asm/book3s/64/mmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/powerpc/include/asm/book3s/64/mmu.h +1
-1@@ -208,7 +208,7 @@ void hash__early_init_devtree(void);void radix__early_init_devtree (void );extern void hash__early_init_mmu (void );extern void radix__early_init_mmu (void ); -static inline void early_init_mmu (void ) +static inline void __init early_init_mmu (void ) {if (radix_enabled ())return radix__early_init_mmu ();
Michael Ellerman
AppliedQuoted 11 lines · Nicholas Piggin
Christian reports:
MODPOST vmlinux.o
WARNING: modpost:vmlinux.o(.text.unlikely+0x1a0): Section mismatch in reference from the function .early_init_mmu() to the function .init.text:.radix__early_init_mmu()
The function .early_init_mmu() references
the function__init.radix__early_init_mmu().
This is often because .early_init_mmu lacks a__initannotation or the annotation of .radix__early_init_mmu is wrong.
Quoted 1 line
[...]
Applied to powerpc/next.
[1/1] powerpc/64s: Fix early_init_mmu section mismatch
https://git.kernel.org/powerpc/c/9384e552aabb647ec22acb00181ca1715b0fcdfe
cheers