i2c: sh_mobile: eliminate a misreported warning
Subsystems (2)
PATCH 1/1 i2c: sh_mobile: eliminate a misreported warning
The warning is caused by the branches "if (pd->pos == -1)" and "if (pd->pos == 0)", because they appear after "real_pos = pd->pos - 2", so the compiler doesn't known the value of real_pos is negative through these two branches.
To avoid this warning, eliminate the middleman "data".
drivers/i2c/busses/i2c-sh_mobile.c: In function ‘sh_mobile_i2c_isr’:drivers/i2c/busses/i2c-sh_mobile.c:396:26: warning: ‘data’ may be used uninitialized in this function [-Wmaybe-uninitialized]
pd->msg->buf[real_pos] = data;
^drivers/i2c/busses/i2c-sh_mobile.c:369:16: note: ‘data’ was declared here
unsigned char data;
--- drivers/i2c/busses/i2c-sh_mobile.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/i2c/busses/i2c-sh_mobile.c +2 -5
@@ -366,7 +366,6 @@ static int sh_mobile_i2c_isr_tx(struct sh_mobile_i2c_data *pd)static int sh_mobile_i2c_isr_rx (struct sh_mobile_i2c_data *pd) { -unsigned char data;int real_pos;/* switch from TX (address) to RX (data) adds two interrupts */
@@ -387,13 +386,11 @@ static int sh_mobile_i2c_isr_rx(struct sh_mobile_i2c_data *pd)if (real_pos <0 )i2c_op (pd,OP_RX_STOP );else - data =i2c_op (pd,OP_RX_STOP_DATA ); + pd->msg->buf[real_pos] =i2c_op (pd,OP_RX_STOP_DATA ); }else if (real_pos >=0 ) { - data =i2c_op (pd,OP_RX ); + pd->msg->buf[real_pos] =i2c_op (pd,OP_RX ); } -if (real_pos >=0 ) - pd->msg->buf[real_pos] = data; done: pd->pos++;return pd->pos == (pd->msg->len +2 );
Signature · 1 line
2.26.0.106.g9fadedd
Wolfram Sang
maintainerQuoted 7 lines · Zhen Lei
The warning is caused by the branches "if (
pd->pos== -1)" and "if (pd->pos== 0)", because they appear after "real_pos=pd->pos- 2", so the compiler doesn't known the value ofreal_posis negative through these two branches.To avoid this warning, eliminate the middleman "data".
Quoted 8 lines
drivers/i2c/busses/i2c-sh_mobile.c: In function ‘sh_mobile_i2c_isr’:drivers/i2c/busses/i2c-sh_mobile.c:396:26: warning: ‘data’ may be used uninitialized in this function [-Wmaybe-uninitialized]pd->msg->buf[real_pos] = data; ^
drivers/i2c/busses/i2c-sh_mobile.c:369:16: note: ‘data’ was declared here
unsigned char data;Signed-off-by Zhen Lei <[email protected]>
Thanks for the patch and reminding me about the issue, it is correct. However, an identical patch has been sent before and is now applied in for-next: