kbuild: add $(always-y) to 'targets'
PATCH 1/1 kbuild: add $(always-y) to 'targets'
I missed to sync this line in commit 421108c51da4 ("kbuild: rename hostprogs-y/always to hostprogs/always-y").
Since then, the files in always(-y) are needlessly rebuilt.
---
scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/Makefile.build +1 -1
@@ -243,7 +243,7 @@ pbl-%.o: %.S FORCE $(call if_changed_dep,as_o_S) targets += $(real-objs-y) $(real-objs-m) $(lib-y) $(pbl-y) -targets += $(extra-y) $(MAKECMDGOALS) $(always) +targets += $(extra-y) $(always-y) $(MAKECMDGOALS) # Linker scripts preprocessor (.lds.S -> .lds) # ---------------------------------------------------------------------------
Signature · 7 lines
2.25.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Sascha Hauer
AppliedQuoted 8 lines · Masahiro Yamada
I missed to sync this line in commit
421108c51da4("kbuild: rename hostprogs-y/always to hostprogs/always-y").Since then, the files in always(-y) are needlessly rebuilt.
Fixes 421108c51da4 ("kbuild: rename hostprogs-y/always to hostprogs/always-y")Signed-off-by Masahiro Yamada <[email protected]>---
Applied, thanks
Sascha
Quoted 26 lines
scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/Makefile.build +1
-1@@ -243,7 +243,7 @@ pbl-%.o: %.S FORCE $(call if_changed_dep,as_o_S) targets += $(real-objs-y) $(real-objs-m) $(lib-y) $(pbl-y) -targets += $(extra-y) $(MAKECMDGOALS) $(always) +targets += $(extra-y) $(always-y) $(MAKECMDGOALS) # Linker scripts preprocessor (.lds.S -> .lds) # ---------------------------------------------------------------------------Signature · 7 lines
2.25.1 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 5 lines · Masahiro Yamada
I missed to sync this line in commit
421108c51da4("kbuild: rename hostprogs-y/always to hostprogs/always-y").Since then, the files in always(-y) are needlessly rebuilt.
This line is not precise because the files in $(always) are fine. If it is not too late, could you please reword this line as follows ?
Since then, the files in $(always-y) are needlessly rebuilt.
Quoted 24 lines
Fixes 421108c51da4 ("kbuild: rename hostprogs-y/always to hostprogs/always-y")Signed-off-by Masahiro Yamada <[email protected]>---
scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/Makefile.build +1
-2@@ -243,7 +243,7 @@ pbl-%.o: %.S FORCE $(call if_changed_dep,as_o_S) targets += $(real-objs-y) $(real-objs-m) $(lib-y) $(pbl-y) -targets += $(extra-y) $(MAKECMDGOALS) $(always) +targets += $(extra-y) $(always-y) $(MAKECMDGOALS) # Linker scripts preprocessor (.lds.S -> .lds) # --------------------------------------------------------------------------- --2.25.1
Signature · 7 lines
Best Regards Masahiro Yamada _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 5 lines · Masahiro Yamada
Quoted 4 lines · Masahiro Yamada
I missed to sync this line in commit
421108c51da4("kbuild: rename hostprogs-y/always to hostprogs/always-y").
Quoted 7 lines
Quoted 1 line
Since then, the files in always(-y) are needlessly rebuilt.
This line is not precise because the files in $(always) are fine. If it is not too late, could you please reword this line as follows ?
Since then, the files in $(always-y) are needlessly rebuilt.
Sorry, it's too late. I merged this as a fix to master.
Sascha
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox