Skip to contentSkip to conversation

openssl: Fix dependency loop with PACKAGECONFIG cryptodev-linux

PATCH In review Scott Ellis 2 participants 3 messages Apr 30, 2020 – May 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openssl: Fix dependency loop with PACKAGECONFIG cryptodev-linux

Applies to both zeus and dunfell

ERROR: Nothing RPROVIDES 'cryptodev-module-native' (but virtual:native:/home/scott/poky-zeus/meta/recipes-connectivity/openssl/openssl_1.1.1f.bb RDEPENDS on or otherwise requires it)
ERROR: Required build target 'openssl' has no buildable providers.
Missing or unbuildable dependency chain was: ['openssl', 'rpm-native', 'python3-native', 'openssl-native', 'cryptodev-module-native']

---
 meta/recipes-connectivity/openssl/openssl_1.1.1f.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +1 -1
index aa4ef6f48a..a952fae728 100644
@@ -32,7 +32,7 @@ PACKAGECONFIG ?= ""
 PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""
 
-PACKAGECONFIG[cryptodev-linux] = "enable-devcryptoeng,disable-devcryptoeng,cryptodev-linux,,cryptodev-module"
+PACKAGECONFIG[cryptodev-linux] = "enable-devcryptoeng,disable-devcryptoeng,cryptodev-linux"
 
 B = "${WORKDIR}/build"
 do_configure[cleandirs] = "${B}"
Signature · 1 line
2.17.1
#1 lore raw

On Thu, Apr 30, 2020 at 08:23:11PM +0000, Scott Ellis wrote:

Hi, Scott,

Sorry, I'm not trying to discourage you from submitting patches, but there are few issues with your patch here - see below and inline.

First of all, patches for OE-core should be sent to:
[email protected]
https://lists.openembedded.org/g/openembedded-core

Looks like you are building poky-zeus - Poky, as a distro, is composed from multiple components/layers, such as bitbake, oe-core/meta, meta-poky and meta-yocto-bsp. Most of them have own git repos with corresponding mailing lists - usually mentioned in corresponding README files, please check those.

Quoted 1 line

Applies to both zeus and dunfell

The process to get your change backported to older branches/releases is to submit it against master, and once accepted, re-send and ask to backport to other branches, such as zeus and dunfell with the name of the branch in the subject. That is because different branches/versions are usually maintained by different people.

Quoted 3 lines

ERROR: Nothing RPROVIDES 'cryptodev-module-native' (but virtual:native:/home/scott/poky-zeus/meta/recipes-connectivity/openssl/openssl_1.1.1f.bb RDEPENDS on or otherwise requires it)
ERROR: Required build target 'openssl' has no buildable providers.
Missing or unbuildable dependency chain was: ['openssl', 'rpm-native', 'python3-native', 'openssl-native', 'cryptodev-module-native']

Not sure how you were able to set the wrong PACKAGECONFIG for openssl-native, when it gets explicitly emptied in the recipe below.

meta/recipes-connectivity/openssl/openssl_1.1.1f.bb PACKAGECONFIG ?= "" · line 33

Quoted 7 lines
meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +0 -0
index aa4ef6f48a..a952fae728 100644
@@ -32,7 +32,7 @@ PACKAGECONFIG ?= ""
 PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""

Here, ^^^ PACKAGECONFIG should all be empty for native and nativesdk versions of openssl.

meta/recipes-connectivity/openssl/openssl_1.1.1f.bb PACKAGECONFIG ?= "" · line 35

Quoted 2 lines
meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +1 -1
-PACKAGECONFIG[cryptodev-linux] = "enable-devcryptoeng,disable-devcryptoeng,cryptodev-linux,,cryptodev-module"
+PACKAGECONFIG[cryptodev-linux] = "enable-devcryptoeng,disable-devcryptoeng,cryptodev-linux"

This is not a fix, but rather a workaround for a bad setup. Moreover, it actually reverts my recent fix to RDEPENDS on cryptodev-module, which is needed to properly support devcryptoeng in openssl.

Maybe if you share with us how you set your environment, we would be able to help you resolve it properly. Thank you!

Signature · 1 line
Denys
Quoted 7 lines
meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +0 -0
 B = "${WORKDIR}/build"
 do_configure[cleandirs] = "${B}"
Signature · 1 line
2.17.1
#2 lore raw

Enabled via a bbappend in a custom layer

$ cat openssl_%.bbappend
PACKAGECONFIG_append = " cryptodev-linux"

This was working prior to the openssl_1.1.1f.bb recipe change a few days ago.

How are you enabling this PACKAGECONFIG?

Quoted 85 lines · Denys Dmytriyenko

On Thu, Apr 30, 2020 at 08:23:11PM +0000, Scott Ellis wrote:

Hi, Scott,

Sorry, I'm not trying to discourage you from submitting patches, but there are
few issues with your patch here - see below and inline.

First of all, patches for OE-core should be sent to:
[email protected]
https://lists.openembedded.org/g/openembedded-core

Looks like you are building poky-zeus - Poky, as a distro, is composed from
multiple components/layers, such as bitbake, oe-core/meta, meta-poky and meta-yocto-bsp. Most of them have own git repos with corresponding mailing lists - usually mentioned in corresponding README files, please check those.

Quoted 1 line

Applies to both zeus and dunfell

The process to get your change backported to older branches/releases is to submit it against master, and once accepted, re-send and ask to backport to
other branches, such as zeus and dunfell with the name of the branch in the
subject. That is because different branches/versions are usually maintained
by different people.

Quoted 1 line

ERROR: Nothing RPROVIDES 'cryptodev-module-native' (but

virtual:native:/home/scott/poky-zeus/meta/recipes-connectivity/openssl/ openssl_1.1.1f.bb RDEPENDS on or otherwise requires it)

Quoted 2 lines

ERROR: Required build target 'openssl' has no buildable providers. Missing or unbuildable dependency chain was: ['openssl', 'rpm-native',

'python3-native', 'openssl-native', 'cryptodev-module-native']

Not sure how you were able to set the wrong PACKAGECONFIG for openssl-native,
when it gets explicitly emptied in the recipe below.

Review

Quoted 1 line
(quoted diff) +0 -0

b/meta/recipes-connectivity/openssl/openssl_1.1.1f.bb

meta/recipes-connectivity/openssl/openssl_1.1.1f.bb PACKAGECONFIG ?= "" · line 33

Quoted 6 lines

index aa4ef6f48a..a952fae728 100644

meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +0 -0
@@ -32,7 +32,7 @@ PACKAGECONFIG ?= ""
 PACKAGECONFIG_class-native = ""
 PACKAGECONFIG_class-nativesdk = ""

Here, ^^^ PACKAGECONFIG should all be empty for native and nativesdk versions
of openssl.

meta/recipes-connectivity/openssl/openssl_1.1.1f.bb PACKAGECONFIG ?= "" · line 34

Quoted 1 line
meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +0 -1
-PACKAGECONFIG[cryptodev-linux] =

"enable-devcryptoeng,disable-devcryptoeng,cryptodev-linux,,cryptodev-module"

meta/recipes-connectivity/openssl/openssl_1.1.1f.bb PACKAGECONFIG ?= "" · line 34

Quoted 1 line
meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +1 -0
+PACKAGECONFIG[cryptodev-linux] =

"enable-devcryptoeng,disable-devcryptoeng,cryptodev-linux"

This is not a fix, but rather a workaround for a bad setup. Moreover, it actually reverts my recent fix to RDEPENDS on cryptodev-module, which is needed to properly support devcryptoeng in openssl.

Maybe if you share with us how you set your environment, we would be able to
help you resolve it properly. Thank you!

--
Denys

Quoted 7 lines
meta/recipes-connectivity/openssl/openssl_1.1.1f.bb +0 -1
 B = "${WORKDIR}/build"
 do_configure[cleandirs] = "${B}"
--

2.17.1