Skip to contentSkip to conversation

vfio-ccw: Enable transparent CCW IPL from DASD

PATCH Superseded Jared Rossi 2 participants 3 messages Apr 30, 2020 – May 4, 2020

Subsystems (5)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

v2 cover vfio-ccw: Enable transparent CCW IPL from DASD

Remove the explicit prefetch check when using vfio-ccw devices. This check is not needed in practice as all Linux channel programs are intended to use prefetch.

Version 2 improves logging by issuing a warning if a non-prefetch ORB is encountered. A kernel warning is printed when an ORB without the p-bit set is initialized. The warning is limited to once per five seconds because, if encountered, non-prefetch ORBs tend to appear in bursts of hundreds per second.

The commit message is expanded to highlight the potential for future risk if non-prefetch dependent channel programs become prevalent. Furthermore, a note of prefetch only support is added to the limitations section of the vfio-ccw.rst.

Jared Rossi (1):
vfio-ccw: Enable transparent CCW IPL from DASD

 Documentation/s390/vfio-ccw.rst |  4 ++++
 drivers/s390/cio/vfio_ccw_cp.c  | 16 +++++++---------
 2 files changed, 11 insertions(+), 9 deletions(-)
Signature · 1 line
2.17.0
#1 lore raw

PATCH v2 1/1 vfio-ccw: Enable transparent CCW IPL from DASD

Remove the explicit prefetch check when using vfio-ccw devices. This check is not needed in practice as all Linux channel programs are intended to use prefetch.

It is expected that all ORBs issued by Linux will request prefetch. Although non-prefetching ORBs are not rejected, they will prefetch nonetheless. A warning is issued up to once per 5 seconds when a forced prefetch occurs.

A non-prefetch ORB does not necessarily result in an error, however frequent encounters with non-prefetch ORBs indicates that channel programs are being executed in a way that is inconsistent with what the guest is requesting. While there are currently no known errors caused by forced prefetch, it is possible in theory that forced prefetch could result in an error if applied to a channel program that is dependent on non-prefetch.

---
 Documentation/s390/vfio-ccw.rst |  4 ++++
 drivers/s390/cio/vfio_ccw_cp.c  | 16 +++++++---------
 2 files changed, 11 insertions(+), 9 deletions(-)
Documentation/s390/vfio-ccw.rst +4 -0
index fca9c4f5bd9c..8f71071f4403 100644
@@ -335,6 +335,10 @@ device.
 The current code allows the guest to start channel programs via
 START SUBCHANNEL, and to issue HALT SUBCHANNEL and CLEAR SUBCHANNEL.
 
+Currently all channel programs are prefetched, regardless of the
+p-bit setting in the ORB.  As a result, self modifying channel
+programs are not supported (IPL is handled as a special case).
+
 vfio-ccw supports classic (command mode) channel I/O only. Transport
 mode (HPF) is not supported.
 
drivers/s390/cio/vfio_ccw_cp.c +7 -9
index 3645d1720c4b..48802e9827b6 100644
@@ -8,6 +8,7 @@
  *            Xiao Feng Ren <[email protected]>
  */
 
+#include <linux/ratelimit.h>
 #include <linux/mm.h>
 #include <linux/slab.h>
 #include <linux/iommu.h>
@@ -625,23 +626,20 @@ static int ccwchain_fetch_one(struct ccwchain *chain,
  * the target channel program from @orb->cmd.iova to the new ccwchain(s).
  *
  * Limitations:
- * 1. Supports only prefetch enabled mode.
- * 2. Supports idal(c64) ccw chaining.
- * 3. Supports 4k idaw.
+ * 1. Supports idal(c64) ccw chaining.
+ * 2. Supports 4k idaw.
  *
  * Returns:
  *   %0 on success and a negative error value on failure.
  */
 int cp_init(struct channel_program *cp, struct device *mdev, union orb *orb)
 {
+	static DEFINE_RATELIMIT_STATE(ratelimit_state, 5 * HZ, 1);
 	int ret;
 
-	/*
-	 * XXX:
-	 * Only support prefetch enable mode now.
-	 */
-	if (!orb->cmd.pfch)
-		return -EOPNOTSUPP;
+	/* All Linux channel programs are expected to support prefetching */
+	if (!orb->cmd.pfch && __ratelimit(&ratelimit_state))
+		printk(KERN_WARNING "vfio_ccw_cp: prefetch will be forced\n");
 
 	INIT_LIST_HEAD(&cp->ccwchain_list);
 	memcpy(&cp->orb, orb, sizeof(*orb));
Signature · 1 line
2.17.0
#2 lore raw
Quoted 2 lines · On Thu, 30 Apr 2020 17:29:59 -0400 Jared Rossi <[email protected]> wrote:

Remove the explicit prefetch check when using vfio-ccw devices. This check is not needed in practice as all Linux channel programs

s/is not needed/does not trigger/ ?

Quoted 9 lines

are intended to use prefetch.

It is expected that all ORBs issued by Linux will request prefetch. Although non-prefetching ORBs are not rejected, they will prefetch nonetheless. A warning is issued up to once per 5 seconds when a forced prefetch occurs.

A non-prefetch ORB does not necessarily result in an error, however frequent encounters with non-prefetch ORBs indicates that channel

s/indicates/indicate/

Quoted 3 lines

programs are being executed in a way that is inconsistent with what the guest is requesting. While there are currently no known errors caused by forced prefetch, it is possible in theory that forced

"While there is currently no known case of an error caused by forced prefetch, ..." ?

Quoted 14 lines

prefetch could result in an error if applied to a channel program that is dependent on non-prefetch.

---
 Documentation/s390/vfio-ccw.rst |  4 ++++
 drivers/s390/cio/vfio_ccw_cp.c  | 16 +++++++---------
 2 files changed, 11 insertions(+), 9 deletions(-)
Documentation/s390/vfio-ccw.rst +0 -0
index fca9c4f5bd9c..8f71071f4403 100644

Documentation/s390/vfio-ccw.rst device. · line 340

Quoted 6 lines
Documentation/s390/vfio-ccw.rst +3 -0
@@ -335,6 +335,10 @@ device.
 The current code allows the guest to start channel programs via
 START SUBCHANNEL, and to issue HALT SUBCHANNEL and CLEAR SUBCHANNEL.
 
+Currently all channel programs are prefetched, regardless of the
+p-bit setting in the ORB.  As a result, self modifying channel
+programs are not supported (IPL is handled as a special case).

"IPL has to be handled as a special case by a userspace/guest program; this has been implemented in QEMU's s390-ccw bios as of QEMU 4.1" ?

Quoted 31 lines
Documentation/s390/vfio-ccw.rst +1 -0
+
 vfio-ccw supports classic (command mode) channel I/O only. Transport
 mode (HPF) is not supported.
 
drivers/s390/cio/vfio_ccw_cp.c +3 -3
index 3645d1720c4b..48802e9827b6 100644
@@ -8,6 +8,7 @@
  *            Xiao Feng Ren <[email protected]>
  */
 
+#include <linux/ratelimit.h>
 #include <linux/mm.h>
 #include <linux/slab.h>
 #include <linux/iommu.h>
@@ -625,23 +626,20 @@ static int ccwchain_fetch_one(struct ccwchain *chain,
  * the target channel program from @orb->cmd.iova to the new ccwchain(s).
  *
  * Limitations:
- * 1. Supports only prefetch enabled mode.
- * 2. Supports idal(c64) ccw chaining.
- * 3. Supports 4k idaw.
+ * 1. Supports idal(c64) ccw chaining.
+ * 2. Supports 4k idaw.
  *
  * Returns:
  *   %0 on success and a negative error value on failure.
  */
 int cp_init(struct channel_program *cp, struct device *mdev, union orb *orb)
 {

drivers/s390/cio/vfio_ccw_cp.c static int ccwchain_fetch_one(struct ccwchain *chain, · line 640

Quoted 10 lines
drivers/s390/cio/vfio_ccw_cp.c +2 -6
+	static DEFINE_RATELIMIT_STATE(ratelimit_state, 5 * HZ, 1);
 	int ret;
 
-	/*
-	 * XXX:
-	 * Only support prefetch enable mode now.
-	 */
-	if (!orb->cmd.pfch)
-		return -EOPNOTSUPP;
+	/* All Linux channel programs are expected to support prefetching */

I think we want a longer comment here as well, not only in the patch description.

"We only support prefetching the channel program. We assume all channel programs executed by supported guests (i.e. Linux) to support prefetching. If prefetching is not specified, executing the channel program may still work without problems; but log a message to give at least a hint if something goes wrong."

?

drivers/s390/cio/vfio_ccw_cp.c static int ccwchain_fetch_one(struct ccwchain *chain, · line 642

Quoted 2 lines
drivers/s390/cio/vfio_ccw_cp.c +2 -0
+	if (!orb->cmd.pfch && __ratelimit(&ratelimit_state))
+		printk(KERN_WARNING "vfio_ccw_cp: prefetch will be forced\n");

"prefetch will be forced" is a bit misleading: the code does not force the p bit in the orb to be on, it's just the vfio-ccw cp translation code that relies on prefetching. Maybe rather "executing unsupported channel program without prefetch, things may break"?

Also, this message does not mention the affected device, which makes it hard to locate the issuer in the guest. Maybe use dev_warn_ratelimited() instead of the home-grown ratelimiting? Or did you already try the generic ratelimiting?

Quoted 3 lines
drivers/s390/cio/vfio_ccw_cp.c +0 -0
 	INIT_LIST_HEAD(&cp->ccwchain_list);
 	memcpy(&cp->orb, orb, sizeof(*orb));