selftests/bpf: use reno instead of dctcp
Subsystems (5)
PATCH 1/1 selftests/bpf: use reno instead of dctcp
Andrey pointed out that we can use reno instead of dctcp for CC tests and drop CONFIG_TCP_CONG_DCTCP=y requirement.
Fixes beecf11bc218 ("bpf: Bpf_{g,s}etsockopt for struct bpf_sock_addr")
Suggested-by Andrey Ignatov <[email protected]>
Signed-off-by Stanislav Fomichev <[email protected]>
--- tools/testing/selftests/bpf/config | 1 - tools/testing/selftests/bpf/progs/connect4_prog.c | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-)
tools/testing/selftests/bpf/config +0 -1
@@ -37,4 +37,3 @@ CONFIG_IPV6_SIT=m CONFIG_BPF_JIT=y CONFIG_BPF_LSM=y CONFIG_SECURITY=y -CONFIG_TCP_CONG_DCTCP=y
tools/testing/selftests/bpf/progs/connect4_prog.c +3 -3
@@ -59,12 +59,12 @@ static __inline int verify_cc(struct bpf_sock_addr *ctx,static __inlineint set_cc (struct bpf_sock_addr *ctx) { -char dctcp[TCP_CA_NAME_MAX ] ="dctcp" ; +char reno[TCP_CA_NAME_MAX ] ="reno" ;char cubic[TCP_CA_NAME_MAX ] ="cubic" ; -if (bpf_setsockopt (ctx,SOL_TCP ,TCP_CONGESTION , &dctcp,sizeof (dctcp))) +if (bpf_setsockopt (ctx,SOL_TCP ,TCP_CONGESTION , &reno,sizeof (reno)))return 1 ; -if (verify_cc (ctx, dctcp)) +if (verify_cc (ctx, reno))return 1 ;if (bpf_setsockopt (ctx,SOL_TCP ,TCP_CONGESTION , &cubic,sizeof (cubic)))
Signature · 1 line
2.26.2.526.g744177e7f7-goog
Quoted 2 lines · Stanislav Fomichev
Andrey pointed out that we can use reno instead of dctcp for CC tests and drop
CONFIG_TCP_CONG_DCTCP=yrequirement.
Acked-by Martin KaFai Lau <[email protected]>
Alexei Starovoitov
AppliedQuoted 5 lines · Martin KaFai Lau
Quoted 2 lines · Stanislav Fomichev
Andrey pointed out that we can use reno instead of dctcp for CC tests and drop
CONFIG_TCP_CONG_DCTCP=yrequirement.Acked-by Martin KaFai Lau <[email protected]>
Applied. Thanks