Skip to contentSkip to conversation

pseudo_ipc.h: Fix enum typedef

PATCH In review Jacob Kroon 3 participants 8 messages May 3, 2020 – May 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pseudo_ipc.h: Fix enum typedef

'pseudo_access_t' is a type, so use typedef.

Fixes building pseudo with gcc 10 where -fno-common is the default.

---
 pseudo_ipc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
pseudo_ipc.h +1 -1
index caeae5c..d945257 100644
@@ -29,7 +29,7 @@ typedef struct {
 	char path[];
 } pseudo_msg_t;
 
-enum {
+typedef enum {
 	PSA_EXEC = 1,
 	PSA_WRITE = (PSA_EXEC << 1),
 	PSA_READ = (PSA_WRITE << 1),
Signature · 1 line
2.26.2
#1 lore raw

✗ patchtest: failure for pseudo_ipc.h: Fix enum typedef

== Series Details ==

Series: pseudo_ipc.h: Fix enum typedef
Revision: 1
URL : https://patchwork.openembedded.org/series/23915/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at e44ca998c2)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#2 lore raw

Re: ✗ patchtest: failure for pseudo_ipc.h: Fix enum typedef

Pseudo README states that patches should be directed to openembedded-core ml.

Is there some special magic that needs to go in the message header ?

/Jacob

Quoted 34 lines · Patchwork

== Series Details ==

Series: pseudo_ipc.h: Fix enum typedef
Revision: 1
URL : https://patchwork.openembedded.org/series/23915/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue             Series does not apply on top of target branch [test_series_merge_on_head]
   Suggested fix    Rebase your series on top of targeted branch
   Targeted branch  master (currently at e44ca998c2)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#3 lore raw
In reply to Jacob Kroon
Quoted 3 lines · On Sun, 3 May 2020 06:27:12 +0200 "Jacob Kroon" <[email protected]> wrote:

'pseudo_access_t' is a type, so use typedef.

Fixes building pseudo with gcc 10 where -fno-common is the default.

Wow! That's amazing, and yes, that's a bug, and the fix looks right to me. I don't know how that got missed all these years. (But don't rely on this evaluation too heavily just yet, I haven't actually looked at the code more carefully, but this seems obvious.)

-s

#4 lore raw
Quoted 5 lines · Seebs
Quoted 2 lines · On Sun, 3 May 2020 06:27:12 +0200 "Jacob Kroon" <[email protected]> wrote:

'pseudo_access_t' is a type, so use typedef.

Quoted 9 lines
Quoted 1 line

Fixes building pseudo with gcc 10 where -fno-common is the default.

Wow! That's amazing, and yes, that's a bug, and the fix looks right to me. I don't know how that got missed all these years. (But don't rely on this evaluation too heavily just yet, I haven't actually looked at the code more carefully, but this seems obvious.)

-s

The type has never been used, so an alternative fix would be to get rid of it altogether, and just keep the enum identifiers.

/Jacob

#5 lore raw
Quoted 2 lines · On Sun, 3 May 2020 17:49:09 +0200 "Jacob Kroon" <[email protected]> wrote:

The type has never been used, so an alternative fix would be to get rid of it altogether, and just keep the enum identifiers.

I think I anticipated the type being used for something but it did indeed not happen. It could also just be changed to 'enum [type] { ... }', I guess.

But I think your fix is the simplest and closest to what I probably thought I was doing at the time.

-s

#6 lore raw

Hi Peter,

Quoted 6 lines · Seebs
Quoted 2 lines · On Sun, 3 May 2020 17:49:09 +0200 "Jacob Kroon" <[email protected]> wrote:

The type has never been used, so an alternative fix would be to get rid of it altogether, and just keep the enum identifiers.

Quoted 7 lines

I think I anticipated the type being used for something but it did indeed not happen. It could also just be changed to 'enum [type] { ... }', I guess.

But I think your fix is the simplest and closest to what I probably thought I was doing at the time.

Do you have any plans on merging this, and also the pending patches in oe-core, anytime soon ? Then we could bump the pseudo git rev in oe-core and remove those patches, if not then I can add the patch to the pseudo recipe. Any way you'd prefer ?

/Jacob

#7 lore raw
Quoted 13 lines · On Fri, 8 May 2020 08:09:58 +0200 Jacob Kroon <[email protected]> wrote:

Hi Peter,

Quoted 10 lines · Seebs
Quoted 2 lines · On Sun, 3 May 2020 17:49:09 +0200 "Jacob Kroon" <[email protected]> wrote:

The type has never been used, so an alternative fix would be to get rid of it altogether, and just keep the enum identifiers.

I think I anticipated the type being used for something but it did indeed not happen. It could also just be changed to 'enum [type] { ... }', I guess.

Quoted 8 lines
Quoted 3 lines

But I think your fix is the simplest and closest to what I probably thought I was doing at the time.

Do you have any plans on merging this, and also the pending patches in oe-core, anytime soon ? Then we could bump the pseudo git rev in oe-core and remove those patches, if not then I can add the patch to the pseudo recipe. Any way you'd prefer ?

It probably makes sense to add things to the pseudo recipe for now, I'm still trying to catch up on my task backlog from March.

-s