initscripts/init-system-helpers: fix mountnfs.sh dependency
PATCH v3 1/1 initscripts/init-system-helpers: fix mountnfs.sh dependency
With commit c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
Author: Yue Tao <[email protected]>
Date: Fri May 25 10:48:08 2018 +0800
initscripts: Avoid starting rpcbind daemon twice
Check the status before start it to avoid duplicates.
the use of a script {/usr/sbin/}service is introduced - maybe earlier provided by systemd, nowadays mostly by init-system-helpers from debian project.
For the very first shot, maybe discussions and improvements based on that script collection, use just the init-system-helpers-service in initscripts/mountnfs.sh to avoid problems mounting NFS in later boot stage.
--- meta/conf/distro/include/maintainers.inc | 1 + .../initscripts/init-system-helpers_1.57.bb | 51 +++++++++++++++++++ .../initscripts/initscripts_1.0.bb | 1 + 3 files changed, 53 insertions(+) create mode 100644 meta/recipes-core/initscripts/init-system-helpers_1.57.bb
meta/conf/distro/include/maintainers.inc +1 -0
@@ -266,6 +266,7 @@ RECIPE_MAINTAINER_pn-icu = "Alexander Kanavin <[email protected]>" RECIPE_MAINTAINER_pn-ifupdown = "Anuj Mittal <[email protected]>" RECIPE_MAINTAINER_pn-inetutils = "Tom Rini <[email protected]>" RECIPE_MAINTAINER_pn-init-ifupdown = "Anuj Mittal <[email protected]>" +RECIPE_MAINTAINER_pn-init-system-helpers = "Anuj Mittal <[email protected]>" RECIPE_MAINTAINER_pn-initramfs-boot = "Otavio Salvador <[email protected]>" RECIPE_MAINTAINER_pn-initramfs-framework = "Otavio Salvador <[email protected]>" RECIPE_MAINTAINER_pn-initramfs-live-boot = "Anuj Mittal <[email protected]>"
meta/recipes-core/initscripts/init-system-helpers_1.57.bb new file +51 -0
51 lines not on this page · raw message
meta/recipes-core/initscripts/initscripts_1.0.bb +1 -0
@@ -50,6 +50,7 @@ PACKAGE_WRITE_DEPS_append = " ${@bb.utils.contains('DISTRO_FEATURES','systemd',' PACKAGES =+ "${PN}-functions ${PN}-sushell" RDEPENDS_${PN} = "initd-functions \ ${@bb.utils.contains('DISTRO_FEATURES','selinux','${PN}-sushell','',d)} \ + init-system-helpers-service \ " # Recommend pn-functions so that it will be a preferred default provider for initd-functions RRECOMMENDS_${PN} = "${PN}-functions"
Signature · 1 line
2.17.1
Quoted 19 lines · Jens Rehsack
With commit
c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
Author: Yue Tao <[email protected]>
Date: Fri May 25 10:48:08 2018 +0800initscripts: Avoid starting rpcbind daemon twice
Check the status before start it to avoid duplicates.
the use of a script {
/usr/sbin/}serviceis introduced - maybe earlier provided by systemd, nowadays mostly by init-system-helpers from debian project.For the very first shot, maybe discussions and improvements based on that script collection, use just the init-system-helpers-service in
initscripts/mountnfs.shto avoid problems mounting NFS in later boot stage.Signed-off-by Jens Rehsack <[email protected]>
...
Quoted 1 line
+RDEPENDS_${PN}-update-rc.d = "perl"
Can't it be replaced? using perl here is not nice.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Quoted 23 lines
Am 04.05.2020 um 16:21 schrieb Otavio Salvador <[email protected]>:
Quoted 18 lines · Jens Rehsack
With commit
c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
Author: Yue Tao <[email protected]>
Date: Fri May 25 10:48:08 2018 +0800initscripts: Avoid starting rpcbind daemon twice
Check the status before start it to avoid duplicates.
the use of a script {
/usr/sbin/}serviceis introduced - maybe earlier provided by systemd, nowadays mostly by init-system-helpers from debian project.For the very first shot, maybe discussions and improvements based on that script collection, use just the init-system-helpers-service in
initscripts/mountnfs.shto avoid problems mounting NFS in later boot stage.
Quoted 5 lines
Quoted 1 line
Signed-off-by Jens Rehsack <[email protected]>...
Quoted 1 line
+RDEPENDS_${PN}-update-rc.d = "perl"
Can't it be replaced? using perl here is not nice.
Be careful :P
Seriously - it uses perl only for it's update-rc.d (which I didn't ripped off to give community a chance to discuss it). Generally - especially with the runit, s6, openrc ... in mind - we have to grow from there anyway and I like our current update-rc.d implementation anyway.
But I would like then to have a 2nd commit (for documentation purposes) to kill it or we just provide it and let people choose to use this one over meta/recipes-core/update-rc.d
Cheers
--
Jens Rehsack - [email protected]
Quoted 21 lines · Jens Rehsack
Quoted 21 lines
Am 04.05.2020 um 16:21 schrieb Otavio Salvador <[email protected]>:
Quoted 18 lines · Jens Rehsack
With commit
c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
Author: Yue Tao <[email protected]>
Date: Fri May 25 10:48:08 2018 +0800initscripts: Avoid starting rpcbind daemon twice
Check the status before start it to avoid duplicates.
the use of a script {
/usr/sbin/}serviceis introduced - maybe earlier provided by systemd, nowadays mostly by init-system-helpers from debian project.For the very first shot, maybe discussions and improvements based on that script collection, use just the init-system-helpers-service in
initscripts/mountnfs.shto avoid problems mounting NFS in later boot stage.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Jens Rehsack <[email protected]>...
Quoted 1 line
+RDEPENDS_${PN}-update-rc.d = "perl"
Can't it be replaced? using perl here is not nice.
Be careful :P
Everyone has the right to do bad choices in life ;-P
Quoted 8 lines
Seriously - it uses perl only for it's update-rc.d (which I didn't ripped off to give community a chance to discuss it). Generally - especially with the runit, s6, openrc ... in mind - we have to grow from there anyway and I like our current update-rc.d implementation anyway.
But I would like then to have a 2nd commit (for documentation purposes) to kill it or we just provide it and let people choose to use this one over meta/recipes-core/update-rc.d
Generally, I'd prefer to not give the option as it causes more troubles for supporting it in future. I am totally fine with it being dropped on a second commit for sure.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
Quoted 27 lines
Am 05.05.2020 um 16:56 schrieb Otavio Salvador <[email protected]>:
Quoted 22 lines · Jens Rehsack
Quoted 22 lines
Am 04.05.2020 um 16:21 schrieb Otavio Salvador <[email protected]>:
Quoted 19 lines · Jens Rehsack
With commit
c9fc9110be33fe0f24bc3a7c242b584a4ca33e04
Author: Yue Tao <[email protected]>
Date: Fri May 25 10:48:08 2018 +0800initscripts: Avoid starting rpcbind daemon twice
Check the status before start it to avoid duplicates.
the use of a script {
/usr/sbin/}serviceis introduced - maybe earlier provided by systemd, nowadays mostly by init-system-helpers from debian project.For the very first shot, maybe discussions and improvements based on that script collection, use just the init-system-helpers-service in
initscripts/mountnfs.shto avoid problems mounting NFS in later boot stage.Signed-off-by Jens Rehsack <[email protected]>
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
...
Quoted 1 line
+RDEPENDS_${PN}-update-rc.d = "perl"
Can't it be replaced? using perl here is not nice.
Be careful :P
Everyone has the right to do bad choices in life ;-P
/me nods
But comparing to up-river alternatives, there isn't much better :)
Quoted 5 lines
Quoted 5 lines
Seriously - it uses perl only for it's update-rc.d (which I didn't ripped off to give community a chance to discuss it). Generally - especially with the runit, s6, openrc ... in mind - we have to grow from there anyway and I like our current update-rc.d implementation anyway.
Quoted 7 lines
Quoted 3 lines
But I would like then to have a 2nd commit (for documentation purposes) to kill it or we just provide it and let people choose to use this one over meta/recipes-core/update-rc.d
Generally, I'd prefer to not give the option as it causes more troubles for supporting it in future. I am totally fine with it being dropped on a second commit for sure.
What do others (Richard, Anuj, Khem) say?
And - making a patch series from that or let someone else kicking it?
Cheers
--
Jens Rehsack - [email protected]