Skip to contentSkip to conversation

KVM: VMX: Fix operand constraint of PUSH instructions

PATCH Superseded Uros Bizjak 1 participant 1 message May 4, 2020

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: VMX: Fix operand constraint of PUSH instructions

PUSH instructions can't handle 64-bit immediate operands, so "i" operand constraint is not correct. Use "re" operand constraint to limit the range of the immediate operand to a signed 32-bit value and also to leave the compiler the freedom to pass the value via a register.

Please note that memory operands are not allowed here. These operands include stack slots, and these are not valid in this asm block due to the clobbered %rsp register.

Cc Paolo Bonzini <[email protected]>
Cc Sean Christopherson <[email protected]>
---
 arch/x86/kvm/vmx/vmx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kvm/vmx/vmx.c +2 -2
index 22f3324600e1..56c742effb30 100644
@@ -6299,9 +6299,9 @@ static void handle_external_interrupt_irqoff(struct kvm_vcpu *vcpu)
 		:
 		[thunk_target]"r"(entry),
 #ifdef CONFIG_X86_64
-		[ss]"i"(__KERNEL_DS),
+		[ss]"re"(__KERNEL_DS),
 #endif
-		[cs]"i"(__KERNEL_CS)
+		[cs]"re"(__KERNEL_CS)
 	);
 
 	kvm_after_interrupt(vcpu);
Signature · 1 line
2.25.4