Skip to contentSkip to conversation

ceph: demote quotarealm lookup warning to a debug message

PATCH In review Luis Henriques 3 participants 4 messages May 5, 2020 – May 7, 2020 Ceph client

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ceph: demote quotarealm lookup warning to a debug message

A misconfigured cephx can easily result in having the kernel client flooding the logs with:

ceph: Can't lookup inode 1 (err: -13)

Change his message to debug level.

---
Hi!

This patch should fix some harmless warnings when using cephx to restrict users access to certain filesystem paths. I've added a comment to the tracker where removing this warning could result (unlikely, IMHO!) in an admin to miss not-so-harmless bogus configurations.

Cheers,
--
Luís

 fs/ceph/quota.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ceph/quota.c +2 -2
index de56dee60540..19507e2fdb57 100644
@@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
 	}
 
 	if (IS_ERR(in)) {
-		pr_warn("Can't lookup inode %llx (err: %ld)\n",
-			realm->ino, PTR_ERR(in));
+		dout("Can't lookup inode %llx (err: %ld)\n",
+		     realm->ino, PTR_ERR(in));
 		qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
 	} else {
 		qri->timeout = 0;
#1 lore raw
Quoted 30 lines · Luis Henriques

A misconfigured cephx can easily result in having the kernel client flooding the logs with:

ceph: Can't lookup inode 1 (err: -13)

Change his message to debug level.

---
Hi!

This patch should fix some harmless warnings when using cephx to restrict users access to certain filesystem paths. I've added a comment to the tracker where removing this warning could result (unlikely, IMHO!) in an admin to miss not-so-harmless bogus configurations.

Cheers,
--
Luís

 fs/ceph/quota.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ceph/quota.c +0 -0
index de56dee60540..19507e2fdb57 100644

fs/ceph/quota.c static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc, · line 166

Quoted 10 lines
fs/ceph/quota.c +2 -2
@@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
 	}
 
 	if (IS_ERR(in)) {
-		pr_warn("Can't lookup inode %llx (err: %ld)\n",
-			realm->ino, PTR_ERR(in));
+		dout("Can't lookup inode %llx (err: %ld)\n",
+		     realm->ino, PTR_ERR(in));
 		qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
 	} else {
 		qri->timeout = 0;

Merged into testing.

Thanks Luis!

Signature · 1 line
Jeff Layton <[email protected]>
#2 lore raw
In reply to Luis Henriques
Quoted 30 lines · Luis Henriques

A misconfigured cephx can easily result in having the kernel client flooding the logs with:

ceph: Can't lookup inode 1 (err: -13)

Change his message to debug level.

---
Hi!

This patch should fix some harmless warnings when using cephx to restrict users access to certain filesystem paths. I've added a comment to the tracker where removing this warning could result (unlikely, IMHO!) in an admin to miss not-so-harmless bogus configurations.

Cheers,
--
Luís

 fs/ceph/quota.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ceph/quota.c +0 -0
index de56dee60540..19507e2fdb57 100644

fs/ceph/quota.c static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc, · line 166

Quoted 10 lines
fs/ceph/quota.c +2 -2
@@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
 	}
 
 	if (IS_ERR(in)) {
-		pr_warn("Can't lookup inode %llx (err: %ld)\n",
-			realm->ino, PTR_ERR(in));
+		dout("Can't lookup inode %llx (err: %ld)\n",
+		     realm->ino, PTR_ERR(in));
 		qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
 	} else {
 		qri->timeout = 0;

Ilya,

We've had a number of reports where people get a ton of kernel log spam when they hit this problem. I think we probably ought to mark this patch for stable and go ahead and send it to Linus for v5.7 -- any objection?

Signature · 1 line
Jeff Layton <[email protected]>
maintainer
#3 lore raw
Quoted 45 lines · Jeff Layton
Quoted 30 lines · Luis Henriques

A misconfigured cephx can easily result in having the kernel client flooding the logs with:

ceph: Can't lookup inode 1 (err: -13)

Change his message to debug level.

---
Hi!

This patch should fix some harmless warnings when using cephx to restrict users access to certain filesystem paths. I've added a comment to the tracker where removing this warning could result (unlikely, IMHO!) in an admin to miss not-so-harmless bogus configurations.

Cheers,
--
Luís

 fs/ceph/quota.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ceph/quota.c +0 -0
index de56dee60540..19507e2fdb57 100644

fs/ceph/quota.c static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc, · line 166

Quoted 10 lines
fs/ceph/quota.c +2 -2
@@ -159,8 +159,8 @@ static struct inode *lookup_quotarealm_inode(struct ceph_mds_client *mdsc,
      }
 
      if (IS_ERR(in)) {
-             pr_warn("Can't lookup inode %llx (err: %ld)\n",
-                     realm->ino, PTR_ERR(in));
+             dout("Can't lookup inode %llx (err: %ld)\n",
+                  realm->ino, PTR_ERR(in));
              qri->timeout = jiffies + msecs_to_jiffies(60 * 1000); /* XXX */
      } else {
              qri->timeout = 0;

Ilya,

Quoted 3 lines

We've had a number of reports where people get a ton of kernel log spam when they hit this problem. I think we probably ought to mark this patch for stable and go ahead and send it to Linus for v5.7 -- any objection?

Sure, I'll queue it up.

Thanks,

Ilya