Skip to contentSkip to conversation

enetc: Fix use after free in stream_filter_unref()

PATCH In review Dan Carpenter 2 participants 2 messages May 5, 2020 – May 8, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 enetc: Fix use after free in stream_filter_unref()

This code frees "sfi" and then dereferences it on the next line.

Fixes 888ae5a3952b ("net: enetc: add tc flower psfp offload driver")
---
 drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/enetc_qos.c +1 -1
index 48e589e9d0f7c..10d79eb46c2e8 100644
@@ -902,8 +902,8 @@ static void stream_filter_unref(struct enetc_ndev_priv *priv, u32 index)
 	if (z) {
 		enetc_streamfilter_hw_set(priv, sfi, false);
 		hlist_del(&sfi->node);
-		kfree(sfi);
 		clear_bit(sfi->index, epsfp.psfp_sfi_bitmap);
+		kfree(sfi);
 	}
 }
 
Signature · 1 line
2.26.2
maintainer
#1 lore raw

From: Dan Carpenter <[email protected]>
Date: Tue, 5 May 2020 23:47:21 +0300

Quoted 4 lines

This code frees "sfi" and then dereferences it on the next line.

Fixes 888ae5a3952b ("net: enetc: add tc flower psfp offload driver")

This was fixed in another patch by using the local variable 'index'.