enetc: Fix use after free in stream_filter_unref()
PATCH 1/1 enetc: Fix use after free in stream_filter_unref()
This code frees "sfi" and then dereferences it on the next line.
Fixes 888ae5a3952b ("net: enetc: add tc flower psfp offload driver")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/enetc/enetc_qos.c +1 -1
@@ -902,8 +902,8 @@ static void stream_filter_unref(struct enetc_ndev_priv *priv, u32 index)if (z) {enetc_streamfilter_hw_set (priv, sfi, false);hlist_del (&sfi->node); -kfree (sfi);clear_bit (sfi->index, epsfp.psfp_sfi_bitmap); +kfree (sfi); } }
Signature · 1 line
2.26.2
David Miller
maintainerFrom: Dan Carpenter <[email protected]>
Date: Tue, 5 May 2020 23:47:21 +0300
Quoted 4 lines
This code frees "sfi" and then dereferences it on the next line.
Fixes 888ae5a3952b ("net: enetc: add tc flower psfp offload driver")Signed-off-by Dan Carpenter <[email protected]>
This was fixed in another patch by using the local variable 'index'.